[jira] [Commented] (KAFKA-14419) Failed SyncGroup leading to partitions lost due to processing during rebalances

2024-08-06 Thread Mikael Carlstedt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871546#comment-17871546 ] Mikael Carlstedt commented on KAFKA-14419: -- We hadn't seen this issue for a ver

[PR] KAFKA-17270: Let test code use Exit.java rather than Exit.scala [kafka]

2024-08-06 Thread via GitHub
frankvicky opened a new pull request, #16821: URL: https://github.com/apache/kafka/pull/16821 JIRA: [KAFKA-17270](https://issues.apache.org/jira/browse/KAFKA-17270) `Exit.scala` is a wrapper around `Exit.java`, and its main benefit is that it allows methods to throw exceptions by retu

[PR] KAFKA-17067: Fix Candidate transition [kafka]

2024-08-06 Thread via GitHub
ahuang98 opened a new pull request, #16820: URL: https://github.com/apache/kafka/pull/16820 Only voters should be able to transition to Candidate state. This factors `VoterState` into a subclass of `UnattachedState`. While the subclass isn't necessary, I felt it is clean enough and allows

Re: [PR] KAFKA-17276: KRaft client should reser the replicaDirectoryId if the version is smaller than 17 [kafka]

2024-08-06 Thread via GitHub
m1a2st commented on PR #16819: URL: https://github.com/apache/kafka/pull/16819#issuecomment-2272615580 Yes, I updated the topic, and I will run the e2e tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (KAFKA-17282) pollUnattachedAsObserver should not consider electionTimeoutMs

2024-08-06 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17282: Summary: pollUnattachedAsObserver should not consider electionTimeoutMs Key: KAFKA-17282 URL: https://issues.apache.org/jira/browse/KAFKA-17282 Project: Kafka

[jira] [Assigned] (KAFKA-17282) pollUnattachedAsObserver should not consider electionTimeoutMs

2024-08-06 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang reassigned KAFKA-17282: Assignee: Alyssa Huang > pollUnattachedAsObserver should not consider electionTimeoutMs >

[jira] [Updated] (KAFKA-17276) Add "ignorable=true" to `replicaDirectoryId` (FetchSnapshotRequest and FetchRequest) to make it work with older version

2024-08-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17276: --- Summary: Add "ignorable=true" to `replicaDirectoryId` (FetchSnapshotRequest and FetchRequest

[jira] [Commented] (KAFKA-17276) Add "ignorable=true" to `replicaDirectoryId` to make it work with <17 version

2024-08-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871536#comment-17871536 ] Chia-Ping Tsai commented on KAFKA-17276: [~m1a2st] I have assigned this ticket t

[jira] [Assigned] (KAFKA-17276) Add "ignorable=true" to `replicaDirectoryId` to make it work with <17 version

2024-08-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17276: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Add "ignorable=true" to `replicaDirectoryId` t

[jira] [Updated] (KAFKA-17276) Add "ignorable=true" to `replicaDirectoryId` to make it work with <17 version

2024-08-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17276: --- Summary: Add "ignorable=true" to `replicaDirectoryId` to make it work with <17 version (was

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
chia7712 commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706356186 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "defaul

[PR] [DO NOT MERGE]: KRaft client should reser the replicaDirectoryId if the version is smaller than 17 [kafka]

2024-08-06 Thread via GitHub
m1a2st opened a new pull request, #16819: URL: https://github.com/apache/kafka/pull/16819 Jira: https://issues.apache.org/jira/browse/KAFKA-17276 mark `FetchRequest.json` and `FetchSnapshotRequest.json` replicaDirectory is ignorable ### Committer Checklist (excluded from commit me

Re: [PR] KAFKA-15344: Commit leader epoch where possible [kafka]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #14454: URL: https://github.com/apache/kafka/pull/14454#issuecomment-2272549672 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Updated] (KAFKA-17273) Migrate BootstrapControllersIntegrationTest to use ClusterTestExtensions

2024-08-06 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-17273: -- Summary: Migrate BootstrapControllersIntegrationTest to use ClusterTestExtensions (was: Migrate Boots

Re: [PR] KAFKA-17137:Ensure Admin APIs are properly tested [kafka]

2024-08-06 Thread via GitHub
gongxuanzhang commented on code in PR #16658: URL: https://github.com/apache/kafka/pull/16658#discussion_r1706323945 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2599,6 +2599,33 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

[jira] [Commented] (KAFKA-17280) Remove deprecated methods from DeserializationExceptionHandler as ProductionExceptionHandler

2024-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871526#comment-17871526 ] 黃竣陽 commented on KAFKA-17280: - Thanks for your reminder, I will wait for version 5.0. > Rem

[jira] [Commented] (KAFKA-17280) Remove deprecated methods from DeserializationExceptionHandler as ProductionExceptionHandler

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871524#comment-17871524 ] Matthias J. Sax commented on KAFKA-17280: - This is an item for 5.0 release. We c

[jira] [Updated] (KAFKA-17253) Remove leaking getter methods in Joined helper class

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17253: Labels: kip (was: needs-kip) > Remove leaking getter methods in Joined helper class > ---

[jira] [Updated] (KAFKA-17253) Remove leaking getter methods in Joined helper class

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17253: Description: The helper class `Joined` has four getter methods `gracePeriod()`, `keySerde

[jira] [Updated] (KAFKA-17224) Make ForeachProcessor internal

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17224: Description: `ForeachProcessor` is in public package `org.apache.kafka.streams.kstream` bu

[jira] [Updated] (KAFKA-17224) Make ForeachProcessor internal

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17224: Description: `ForeachProcessor` is in public package `org.apache.kafka.streams.kstream` bu

[jira] [Updated] (KAFKA-17224) Make ForeachProcessor internal

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17224: Labels: kip (was: needs-kip) > Make ForeachProcessor internal > -

[jira] [Updated] (KAFKA-16338) Removed Deprecated configs from StreamsConfig

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16338: Description: * "buffered.records.per.partition" was deprecated via [https://cwiki.apache.

[jira] [Commented] (KAFKA-17280) Remove deprecated methods from DeserializationExceptionHandler as ProductionExceptionHandler

2024-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871517#comment-17871517 ] 黃竣陽 commented on KAFKA-17280: - Im interesting in this issue, Could you assign to me? Thanks

[jira] [Created] (KAFKA-17281) Remove old PAPI methods

2024-08-06 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-17281: --- Summary: Remove old PAPI methods Key: KAFKA-17281 URL: https://issues.apache.org/jira/browse/KAFKA-17281 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-17280) Remove deprecated methods from DeserializationExceptionHandler as ProductionExceptionHandler

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17280: Description: Existing handler got changed in 3.9, to have new `ErrorHandlerContext` input

[jira] [Created] (KAFKA-17280) Remove deprecated methods from DeserializationExceptionHandler as ProductionExceptionHandler

2024-08-06 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-17280: --- Summary: Remove deprecated methods from DeserializationExceptionHandler as ProductionExceptionHandler Key: KAFKA-17280 URL: https://issues.apache.org/jira/browse/KAFKA-17280

[jira] [Commented] (KAFKA-17229) Multiple punctuators that together exceed the transaction timeout cause ProducerFencedException

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871515#comment-17871515 ] Matthias J. Sax commented on KAFKA-17229: - Thanks for clarification. This makes

[jira] [Assigned] (KAFKA-17270) Let test code use Exit.java rather than Exit.scala

2024-08-06 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-17270: --- Assignee: TengYao Chi > Let test code use Exit.java rather than Exit.scala > --

[jira] [Commented] (KAFKA-17270) Let test code use Exit.java rather than Exit.scala

2024-08-06 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871514#comment-17871514 ] Ming-Yen Chung commented on KAFKA-17270: Thank you Chia-Ping and Greg. Since I

[jira] [Assigned] (KAFKA-17270) Let test code use Exit.java rather than Exit.scala

2024-08-06 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung reassigned KAFKA-17270: -- Assignee: (was: Ming-Yen Chung) > Let test code use Exit.java rather than Exit.sc

[jira] [Commented] (KAFKA-17270) Let test code use Exit.java rather than Exit.scala

2024-08-06 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871513#comment-17871513 ] TengYao Chi commented on KAFKA-17270: - Hi [~mingyen066]  I also interested in this i

Re: [PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

2024-08-06 Thread via GitHub
mjsax closed pull request #14951: KAFKA-15662: Add support for clientInstanceIds in Kafka Stream URL: https://github.com/apache/kafka/pull/14951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

2024-08-06 Thread via GitHub
mjsax commented on PR #14951: URL: https://github.com/apache/kafka/pull/14951#issuecomment-2272474949 Closing this PR. We are heading into 4.0 for which we plan to remove EOSv1, so maybe we won't need this any longer. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] POC - DO NO MERGE: refactor StreamsConfig [kafka]

2024-08-06 Thread via GitHub
mjsax commented on PR #14548: URL: https://github.com/apache/kafka/pull/14548#issuecomment-2272474338 Closing this PR for now. Was only a POC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14911: Add system tests for rolling upgrade path of KIP-904 [kafka]

2024-08-06 Thread via GitHub
mjsax closed pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904 URL: https://github.com/apache/kafka/pull/13656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] POC - DO NO MERGE: refactor StreamsConfig [kafka]

2024-08-06 Thread via GitHub
mjsax closed pull request #14548: POC - DO NO MERGE: refactor StreamsConfig URL: https://github.com/apache/kafka/pull/14548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] KAFKA-14911: Add system tests for rolling upgrade path of KIP-904 [kafka]

2024-08-06 Thread via GitHub
mjsax commented on PR #13656: URL: https://github.com/apache/kafka/pull/13656#issuecomment-2272474018 Closing PR for now -- we still have the Jira ticket... Can create a new one when I find time to resume this. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2024-08-06 Thread via GitHub
menghe999 commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1706286321 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1499 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] KAFKA-17268: Fix NPE when closing a non-started acceptor [kafka]

2024-08-06 Thread via GitHub
xijiu opened a new pull request, #16818: URL: https://github.com/apache/kafka/pull/16818 As titile, the `serverChannel` will be null if `Acceptor`'s thread is not started. Hence, closing a non-started will produce NPE ### Committer Checklist (excluded from commit message) - [ ]

[jira] [Created] (KAFKA-17279) Handle retriable errors from offset fetches in ConsumerCoordinator

2024-08-06 Thread Sean Quah (Jira)
Sean Quah created KAFKA-17279: - Summary: Handle retriable errors from offset fetches in ConsumerCoordinator Key: KAFKA-17279 URL: https://issues.apache.org/jira/browse/KAFKA-17279 Project: Kafka

[jira] [Comment Edited] (KAFKA-17276) KRaft client should reser the replicaDirectoryId if the version is smaller than 17

2024-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871500#comment-17871500 ] 黃竣陽 edited comment on KAFKA-17276 at 8/7/24 1:26 AM: - When we build

[jira] [Commented] (KAFKA-17276) KRaft client should reser the replicaDirectoryId if the version is smaller than 17

2024-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871500#comment-17871500 ] 黃竣陽 commented on KAFKA-17276: - When we build `FetchRequest`, we should check that it's versi

[jira] [Resolved] (KAFKA-12828) Remove Deprecated methods under KeyQueryMetadata

2024-08-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12828. - Resolution: Fixed > Remove Deprecated methods under KeyQueryMetadata > -

Re: [PR] KAFKA-12828: Removed Deprecated methods under KeyQueryMetadata [kafka]

2024-08-06 Thread via GitHub
mjsax commented on PR #16747: URL: https://github.com/apache/kafka/pull/16747#issuecomment-2272441886 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-12828: Removed Deprecated methods under KeyQueryMetadata [kafka]

2024-08-06 Thread via GitHub
mjsax merged PR #16747: URL: https://github.com/apache/kafka/pull/16747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] Fix ConcurrentModificationException caused by NioEchoServer.closeNewChannels [kafka]

2024-08-06 Thread via GitHub
bboyleonp666 commented on PR #16817: URL: https://github.com/apache/kafka/pull/16817#issuecomment-2272418055 While handling this issue, I found there's another method `NioEchoServer#closeSocketChannels` that might have potential risk like this one. It's now only used by 2 tests in `SslTrans

[PR] Fix ConcurrentModificationException caused by NioEchoServer.closeNewChannels [kafka]

2024-08-06 Thread via GitHub
bboyleonp666 opened a new pull request, #16817: URL: https://github.com/apache/kafka/pull/16817 `NioEchoServer#closeNewChannels` did not handle multi-threading synchronization. Add `synchronized` handling to prevent `java.util.ConcurrentModificationException`. ### Committer Checklist

Re: [PR] KAFKA-17252: Always track last-read session key from config topic in Kafka Connect, even during startup [kafka]

2024-08-06 Thread via GitHub
gharris1727 commented on PR #16788: URL: https://github.com/apache/kafka/pull/16788#issuecomment-2272393801 > No, it does not affect correctness, it's just a useful signal to help narrow down the cause of failure. This confused me, and I realized it's because my question was poorly fo

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
jolshan commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706208615 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "default

[jira] [Created] (KAFKA-17278) Figure out and fix why the RPC version tests in KafkaRaftClientTest didn't catch a bug in the Fetch schema

2024-08-06 Thread Jira
José Armando García Sancio created KAFKA-17278: -- Summary: Figure out and fix why the RPC version tests in KafkaRaftClientTest didn't catch a bug in the Fetch schema Key: KAFKA-17278 URL: https://issue

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
jolshan commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706208615 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "default

[jira] [Commented] (KAFKA-17276) KRaft client should reser the replicaDirectoryId if the version is smaller than 17

2024-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871487#comment-17871487 ] José Armando García Sancio commented on KAFKA-17276: [~chia7712] I t

[jira] [Updated] (KAFKA-17276) KRaft client should reser the replicaDirectoryId if the version is smaller than 17

2024-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-17276: --- Fix Version/s: 3.9.0 > KRaft client should reser the replicaDirector

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706206849 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "default

Re: [PR] KAFKA-17252: Always track last-read session key from config topic in Kafka Connect, even during startup [kafka]

2024-08-06 Thread via GitHub
C0urante commented on PR #16788: URL: https://github.com/apache/kafka/pull/16788#issuecomment-2272303659 > If we're reading expired session keys during startup, there are brief periods of time when expired keys are used to validate requests. We read to the end of the config topic befo

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706197212 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "default

Re: [PR] KAFKA-17252: Always track last-read session key from config topic in Kafka Connect, even during startup [kafka]

2024-08-06 Thread via GitHub
gharris1727 commented on PR #16788: URL: https://github.com/apache/kafka/pull/16788#issuecomment-2272264286 > We could possibly add retry logic for followers to wait for a session key to be published... this would probably require unrelated changes to this PR and can probably be considered

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

2024-08-06 Thread via GitHub
TaiJuWu commented on PR #16127: URL: https://github.com/apache/kafka/pull/16127#issuecomment-2272254283 > @TaiJuWu Could you please rebase code to trigger QA again? Done. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-17252: Always track last-read session key from config topic in Kafka Connect, even during startup [kafka]

2024-08-06 Thread via GitHub
C0urante commented on PR #16788: URL: https://github.com/apache/kafka/pull/16788#issuecomment-2272238495 > I think that's still possible, if we're the first leader and don't get a chance to write a key to the topic before executing a request from a caller. As long as we're using the `

Re: [PR] KAFKA-17252: Always track last-read session key from config topic in Kafka Connect, even during startup [kafka]

2024-08-06 Thread via GitHub
gharris1727 commented on PR #16788: URL: https://github.com/apache/kafka/pull/16788#issuecomment-2272199968 > requests for zombie fencing that any other workers send to it will fail. Okay, thanks for clarifying, that makes sense. I see that when the key is null, requests are rejected

[jira] [Created] (KAFKA-17277) KIP-1022 : Add version mapping and feature dependencies commands to tools

2024-08-06 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-17277: Summary: KIP-1022 : Add version mapping and feature dependencies commands to tools Key: KAFKA-17277 URL: https://issues.apache.org/jira/browse/KAFKA-17277 Project: Ka

[jira] [Updated] (KAFKA-17277) Add version mapping and feature dependencies commands to tools (KIP-1022)

2024-08-06 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-17277: - Summary: Add version mapping and feature dependencies commands to tools (KIP-1022) (was: Add ve

[jira] [Updated] (KAFKA-17277) Add version mapping and feature dependencies commands to tools (KIP-1022 )

2024-08-06 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-17277: - Summary: Add version mapping and feature dependencies commands to tools (KIP-1022 ) (was: KIP-1

Re: [PR] MINOR: Bump trunk to 3.10.0-SNAPSHOT [kafka]

2024-08-06 Thread via GitHub
gharris1727 closed pull request #16732: MINOR: Bump trunk to 3.10.0-SNAPSHOT URL: https://github.com/apache/kafka/pull/16732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
jolshan commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706085027 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "default

Re: [PR] KAFKA-17242: MirrorCheckpointTask prints spurious timeout for startin… [kafka]

2024-08-06 Thread via GitHub
C0urante commented on PR #16773: URL: https://github.com/apache/kafka/pull/16773#issuecomment-2272076237 @wernerdv You don't have to keep merging `trunk` into this branch. I'll let you know if I see an issue with the CI build but there's a lot of flakiness on there so don't worry if you see

[jira] [Updated] (KAFKA-17276) KRaft client should reser the replicaDirectoryId if the version is smaller than 17

2024-08-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17276: --- Priority: Blocker (was: Major) > KRaft client should reser the replicaDirectoryId if the ve

[jira] [Created] (KAFKA-17276) KRaft client should reser the replicaDirectoryId if the version is smaller than 17

2024-08-06 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17276: -- Summary: KRaft client should reser the replicaDirectoryId if the version is smaller than 17 Key: KAFKA-17276 URL: https://issues.apache.org/jira/browse/KAFKA-17276

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
chia7712 commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706046846 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "defaul

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-08-06 Thread via GitHub
chia7712 commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1706045071 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -100,7 +102,9 @@ { "name": "LogStartOffset", "type": "int64", "versions": "5+", "defaul

Re: [PR] MINOR: Remove unused `FeatureLevelListener` [kafka]

2024-08-06 Thread via GitHub
wernerdv commented on PR #16815: URL: https://github.com/apache/kafka/pull/16815#issuecomment-2271985143 @chia7712 Hello, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] MINOR: Remove unused `FeatureLevelListener` [kafka]

2024-08-06 Thread via GitHub
wernerdv opened a new pull request, #16815: URL: https://github.com/apache/kafka/pull/16815 It looks like this interface has not been used anywhere since the merger https://github.com/apache/kafka/pull/12050/files#diff-77dc2adb187fd078084644613cff2b53021c8a5fbcdcfa116515734609d1332a.

Re: [PR] KAFKA-16584: Make log processing summary configurable or debug--update upgrade-guide [kafka]

2024-08-06 Thread via GitHub
mjsax commented on PR #16709: URL: https://github.com/apache/kafka/pull/16709#issuecomment-2271969362 Thank you! Merged to `trunk` and cherry-picked to `3.9` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (KAFKA-15935) Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15935. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test: testRestartReplication() – > or

[jira] [Commented] (KAFKA-15935) Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871454#comment-17871454 ] Chris Egerton commented on KAFKA-15935: --- This test is no longer failing on trunk a

[jira] [Resolved] (KAFKA-16919) Flaky test testNoCheckpointsIfNoRecordsAreMirrored() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-16919. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test testNoCheckpointsIfNoRecordsAreM

Re: [PR] KAFKA-16584: Make log processing summary configurable or debug--update upgrade-guide [kafka]

2024-08-06 Thread via GitHub
mjsax merged PR #16709: URL: https://github.com/apache/kafka/pull/16709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-16919) Flaky test testNoCheckpointsIfNoRecordsAreMirrored() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871455#comment-17871455 ] Chris Egerton commented on KAFKA-16919: --- This test has only [failed once on trunk

[jira] [Commented] (KAFKA-15933) Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTransactionsTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871452#comment-17871452 ] Chris Egerton commented on KAFKA-15933: --- This test is no longer failing on trunk a

[jira] [Resolved] (KAFKA-15933) Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTransactionsTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15933. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test: testRestartReplication() – > or

[jira] [Commented] (KAFKA-10812) Unclean worker shutdown in MirrorConnectorsIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871449#comment-17871449 ] Chris Egerton commented on KAFKA-10812: --- Not seeing this anymore in our MM2 integr

[jira] [Resolved] (KAFKA-10812) Unclean worker shutdown in MirrorConnectorsIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-10812. --- Fix Version/s: 4.0.0 Resolution: Fixed > Unclean worker shutdown in MirrorConnectorsI

[jira] [Resolved] (KAFKA-15524) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testResetSinkConnectorOffsetsZombieSinkTasks

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15524. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test > org.apache.kafka.connect.integ

[jira] [Resolved] (KAFKA-15892) Flaky test: testAlterSinkConnectorOffsets – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15892. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test: testAlterSinkConnectorOffsets –

[jira] [Commented] (KAFKA-15892) Flaky test: testAlterSinkConnectorOffsets – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871447#comment-17871447 ] Chris Egerton commented on KAFKA-15892: --- This test is no longer failing on trunk a

[jira] [Resolved] (KAFKA-15914) Flaky test - testAlterSinkConnectorOffsetsOverriddenConsumerGroupId - OffsetsApiIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15914. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test - testAlterSinkConnectorOffsetsOv

[jira] [Commented] (KAFKA-15914) Flaky test - testAlterSinkConnectorOffsetsOverriddenConsumerGroupId - OffsetsApiIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871446#comment-17871446 ] Chris Egerton commented on KAFKA-15914: --- This test is no longer failing on trunk a

Re: [PR] KAFKA-17227: Refactor compression code to only load codecs when used … [kafka]

2024-08-06 Thread via GitHub
mimaison merged PR #16811: URL: https://github.com/apache/kafka/pull/16811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-15524) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testResetSinkConnectorOffsetsZombieSinkTasks

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871445#comment-17871445 ] Chris Egerton commented on KAFKA-15524: --- This test is no longer failing on trunk a

Re: [PR] KAFKA-17227: Refactor compression code to only load codecs when used … [kafka]

2024-08-06 Thread via GitHub
mimaison commented on PR #16811: URL: https://github.com/apache/kafka/pull/16811#issuecomment-2271942191 None of the failures are related, merging to 3.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Resolved] (KAFKA-15918) Flaky test - OffsetsApiIntegrationTest.testResetSinkConnectorOffsets

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15918. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test - OffsetsApiIntegrationTest.testR

[jira] [Commented] (KAFKA-15918) Flaky test - OffsetsApiIntegrationTest.testResetSinkConnectorOffsets

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871444#comment-17871444 ] Chris Egerton commented on KAFKA-15918: --- This test is no longer failing on trunk a

[jira] [Resolved] (KAFKA-15197) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15197. --- Fix Version/s: 4.0.0 (was: 3.9.0) Resolution: Fixed > Flaky te

[jira] [Commented] (KAFKA-15197) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871443#comment-17871443 ] Chris Egerton commented on KAFKA-15197: --- This test suite is no longer failing on t

[jira] [Commented] (KAFKA-15292) Flaky test IdentityReplicationIntegrationTest#testReplicateSourceDefault()

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871442#comment-17871442 ] Chris Egerton commented on KAFKA-15292: --- This test is no longer failing on trunk a

[jira] [Resolved] (KAFKA-15292) Flaky test IdentityReplicationIntegrationTest#testReplicateSourceDefault()

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15292. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test IdentityReplicationIntegrationTes

[jira] [Resolved] (KAFKA-15072) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testReplicationWithEmptyPartition

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15072. --- Fix Version/s: 4.0.0 Resolution: Fixed > Flaky test > MirrorConnectorsIntegrationExa

[jira] [Commented] (KAFKA-15072) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testReplicationWithEmptyPartition

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871441#comment-17871441 ] Chris Egerton commented on KAFKA-15072: --- This test suite is no longer failing on t

[jira] [Comment Edited] (KAFKA-14453) Flaky test suite MirrorConnectorsWithCustomForwardingAdminIntegrationTest

2024-08-06 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871440#comment-17871440 ] Chris Egerton edited comment on KAFKA-14453 at 8/6/24 6:51 PM: ---

  1   2   3   >