raminqaf commented on code in PR #16914:
URL: https://github.com/apache/kafka/pull/16914#discussion_r1729780927
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##
@@ -436,6 +430,8 @@ private StateConsumer initialize() {
} c
wernerdv commented on PR #16986:
URL: https://github.com/apache/kafka/pull/16986#issuecomment-2308141964
@chia7712 Hello, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
xijiu commented on PR #16906:
URL: https://github.com/apache/kafka/pull/16906#issuecomment-2308109703
@mjsax Thanks very much for these professional comments, they have greatly
improved my understanding of the work.
I have revised the code, PTAL again
--
This is an automated message f
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1729748670
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -84,6 +85,9 @@ private enum SubscriptionType {
/* the pat
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1729747540
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -13,6 +13,8 @@
// See the License for the specific language governing per
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1729747540
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -13,6 +13,8 @@
// See the License for the specific language governing per
chia7712 commented on code in PR #16858:
URL: https://github.com/apache/kafka/pull/16858#discussion_r1729742192
##
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##
@@ -520,6 +524,44 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegration
xijiu commented on PR #16979:
URL: https://github.com/apache/kafka/pull/16979#issuecomment-2308099212
> @xijiu could you please rebase code to have latest github CI :)
@chia7712 Sure, I have rebased the branch.
--
This is an automated message from the Apache Git Service.
To respond
xijiu commented on code in PR #16987:
URL: https://github.com/apache/kafka/pull/16987#discussion_r1729715993
##
tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:
##
@@ -130,25 +134,31 @@ public void writeTo(ConsumerRecord
consumerRecord, PrintStr
xijiu commented on code in PR #16987:
URL: https://github.com/apache/kafka/pull/16987#discussion_r1729715993
##
tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:
##
@@ -130,25 +134,31 @@ public void writeTo(ConsumerRecord
consumerRecord, PrintStr
xijiu commented on code in PR #16987:
URL: https://github.com/apache/kafka/pull/16987#discussion_r1729715993
##
tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:
##
@@ -130,25 +134,31 @@ public void writeTo(ConsumerRecord
consumerRecord, PrintStr
[
https://issues.apache.org/jira/browse/KAFKA-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876399#comment-17876399
]
Kirk True commented on KAFKA-17335:
---
No worries, [~bachmanity1]!
Regarding 3.9.0, I t
github-actions[bot] commented on PR #15298:
URL: https://github.com/apache/kafka/pull/15298#issuecomment-2308030294
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-17410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876397#comment-17876397
]
TengYao Chi commented on KAFKA-17410:
-
Hello [~lianetm] ,
I have reviewed the `test
TaiJuWu opened a new pull request, #16992:
URL: https://github.com/apache/kafka/pull/16992
Jira: https://issues.apache.org/jira/browse/KAFKA-17390
*More detailed description of your change,
Remove broker-list in GetOffsetShell
*Summary of testing strategy (including ratio
chia7712 commented on PR #16979:
URL: https://github.com/apache/kafka/pull/16979#issuecomment-2308019138
@xijiu could you please rebase code to have latest github CI :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
chia7712 commented on code in PR #16987:
URL: https://github.com/apache/kafka/pull/16987#discussion_r1729685661
##
tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:
##
@@ -130,25 +134,31 @@ public void writeTo(ConsumerRecord
consumerRecord, Print
[
https://issues.apache.org/jira/browse/KAFKA-17415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17415:
--
Assignee: TengYao Chi (was: Chia-Ping Tsai)
> Avoid overflow of expiried timestamp
>
[
https://issues.apache.org/jira/browse/KAFKA-17415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876396#comment-17876396
]
TengYao Chi commented on KAFKA-17415:
-
Hi [~chia7712]
I would like to take this iss
Chia-Ping Tsai created KAFKA-17415:
--
Summary: Avoid overflow of expiried timestamp
Key: KAFKA-17415
URL: https://issues.apache.org/jira/browse/KAFKA-17415
Project: Kafka
Issue Type: Bug
chia7712 commented on code in PR #16905:
URL: https://github.com/apache/kafka/pull/16905#discussion_r1729677137
##
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##
@@ -331,6 +332,52 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegration
[
https://issues.apache.org/jira/browse/KAFKA-17415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-17415:
---
Fix Version/s: 4.0.0
> Avoid overflow of expiried timestamp
> --
frankvicky commented on code in PR #16803:
URL: https://github.com/apache/kafka/pull/16803#discussion_r1729559044
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -450,22 +450,6 @@ public KStream peek(final ForeachAction action,
TaiJuWu commented on PR #16852:
URL: https://github.com/apache/kafka/pull/16852#issuecomment-2308005311
> @TaiJuWu any updates?
@chia7712 Thanks for review. Update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
TaiJuWu commented on code in PR #16905:
URL: https://github.com/apache/kafka/pull/16905#discussion_r1729656258
##
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##
@@ -331,6 +332,52 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationT
kamalcph commented on code in PR #16959:
URL: https://github.com/apache/kafka/pull/16959#discussion_r1729655598
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1254,6 +1255,20 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, Executio
chia7712 commented on PR #16957:
URL: https://github.com/apache/kafka/pull/16957#issuecomment-2307970417
> I think I should add a constant in TestUtils for 30 second, It will be
more easy to controll this parameter. WDYT?
there are only 3 annotations needing the `@Timeout(30)`, so it
m1a2st commented on PR #16957:
URL: https://github.com/apache/kafka/pull/16957#issuecomment-2307955764
> @m1a2st can you pull in the latest trunk changes? I have added code to
report the JUnit failures in the Github Actions workflows. I want to do a few
runs with this change to ensure we h
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876390#comment-17876390
]
Chia-Ping Tsai edited comment on KAFKA-17360 at 8/24/24 12:13 AM:
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876390#comment-17876390
]
Chia-Ping Tsai edited comment on KAFKA-17360 at 8/24/24 12:11 AM:
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876390#comment-17876390
]
Chia-Ping Tsai commented on KAFKA-17360:
[~cmccabe] this bug affects 3.8 and ear
[
https://issues.apache.org/jira/browse/KAFKA-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876389#comment-17876389
]
Chia-Ping Tsai commented on KAFKA-17315:
[~cmccabe] thanks for offering the bett
[
https://issues.apache.org/jira/browse/KAFKA-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876387#comment-17876387
]
Matthias J. Sax commented on KAFKA-16863:
-
[~muralibasani] – You close the VOTE
mjsax commented on code in PR #16816:
URL: https://github.com/apache/kafka/pull/16816#discussion_r1729602744
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1075,6 +1079,11 @@ public String toString() {
DefaultKafkaClientSupplier
rreddy-22 closed pull request #16026: MINOR: Aesthetic, Uniformity Changes and
Reducing warnings
URL: https://github.com/apache/kafka/pull/16026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
mjsax commented on code in PR #16816:
URL: https://github.com/apache/kafka/pull/16816#discussion_r1729601744
##
docs/streams/developer-guide/config-streams.html:
##
@@ -92,7 +93,6 @@
task.assignor.class
topology.optimization
windowed.
mjsax commented on code in PR #15482:
URL: https://github.com/apache/kafka/pull/15482#discussion_r1729590669
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##
@@ -1229,7 +1229,7 @@ private KTable
doJoinOnForeignKey(final KTable forei
mjsax commented on code in PR #15482:
URL: https://github.com/apache/kafka/pull/15482#discussion_r1729590669
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##
@@ -1229,7 +1229,7 @@ private KTable
doJoinOnForeignKey(final KTable forei
mjsax commented on code in PR #15482:
URL: https://github.com/apache/kafka/pull/15482#discussion_r1729588622
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##
@@ -1229,7 +1229,7 @@ private KTable
doJoinOnForeignKey(final KTable forei
cmccabe opened a new pull request, #16991:
URL: https://github.com/apache/kafka/pull/16991
Add ReconfigurableQuorumIntegrationTest to test creating a cluster with
KIP-853 enabled, to verify that the feature flag is set. Introduce functions
such as TestKitNodes.setFeature that can set the le
mjsax commented on code in PR #16914:
URL: https://github.com/apache/kafka/pull/16914#discussion_r1729586240
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##
@@ -436,6 +430,8 @@ private StateConsumer initialize() {
} catc
jolshan commented on PR #15968:
URL: https://github.com/apache/kafka/pull/15968#issuecomment-2307899719
I haven't forgotten about this. I will see if anyone can take a look. Sorry
for the delay @OmniaGM
--
This is an automated message from the Apache Git Service.
To respond to the messag
frankvicky commented on code in PR #16803:
URL: https://github.com/apache/kafka/pull/16803#discussion_r1729559044
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -450,22 +450,6 @@ public KStream peek(final ForeachAction action,
jolshan commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1729551412
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -980,6 +1002,28 @@ void handleCoordinatorReady() {
bachmanity1 commented on code in PR #16990:
URL: https://github.com/apache/kafka/pull/16990#discussion_r1729537368
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java:
##
@@ -209,6 +209,19 @@ public String validateStrin
[
https://issues.apache.org/jira/browse/KAFKA-17404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nelson B. closed KAFKA-17404.
-
> Return the actual controller id or -1 instead of a random broker id when
> calling DescribeCluster or Top
[
https://issues.apache.org/jira/browse/KAFKA-17404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nelson B. resolved KAFKA-17404.
---
Resolution: Not A Problem
> Return the actual controller id or -1 instead of a random broker id when
[
https://issues.apache.org/jira/browse/KAFKA-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876370#comment-17876370
]
Nelson B. commented on KAFKA-17335:
---
Hi [~kirktrue], thank you for catching this! I'm
kirktrue commented on PR #16951:
URL: https://github.com/apache/kafka/pull/16951#issuecomment-2307819820
Note: there are lots of test failures for `PlaintextConsumerTest`’s
`testPerPartitionLagMetricsCleanUpWithSubscribe` and
`testPerPartitionLeadMetricsCleanUpWithSubscribe`. This PR _shoul
kirktrue commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2307817804
Note: the test failures in the latest CI build appear unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gharris1727 commented on code in PR #16479:
URL: https://github.com/apache/kafka/pull/16479#discussion_r1729520016
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -253,6 +253,7 @@ public class KafkaProducer implements Producer {
private
kirktrue commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2307815244
> I agree with @lianetm here. If my application is closing with some timeout
and the user tries to interrupt the program, what do we want it to do? We want
an orderly close with as littl
[
https://issues.apache.org/jira/browse/KAFKA-16331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876369#comment-17876369
]
Matthias J. Sax commented on KAFKA-16331:
-
We had some more discussion about thi
junrao commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1729499882
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -0,0 +1,271 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * cont
gharris1727 commented on PR #16950:
URL: https://github.com/apache/kafka/pull/16950#issuecomment-2307791737
Hey @chia7712 @KTKTK-HZ, this PR contents does not match the ticket or the
PR title. By restructuring the build.gradle, I meant that the shadowJar block
should be moved above the publ
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876360#comment-17876360
]
Colin McCabe commented on KAFKA-17360:
--
I apologize for a silly question, but can y
[
https://issues.apache.org/jira/browse/KAFKA-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876359#comment-17876359
]
Colin McCabe edited comment on KAFKA-17315 at 8/23/24 8:24 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-17315:
-
Summary: Fix the behavior of delegation tokens that expire immediately upon
creation in KRaft mo
[
https://issues.apache.org/jira/browse/KAFKA-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876359#comment-17876359
]
Colin McCabe commented on KAFKA-17315:
--
Thanks for the JIRA, [~chia7712]. Does this
[
https://issues.apache.org/jira/browse/KAFKA-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-17315:
-
Summary: Fix the behavior of delegation tokens that expire immediately on
creation in KRaft mode
cmccabe commented on PR #16968:
URL: https://github.com/apache/kafka/pull/16968#issuecomment-2307739224
@bachmanity1, but I have to give a -1, because this would be a breaking
change for clients. It also would require a KIP if we wanted to to it.
--
This is an automated message from the A
cmccabe closed pull request #16968: KAFKA-17404: Return the actual controller
ID or -1 instead of a random broker ID when calling DescribeCluster
URL: https://github.com/apache/kafka/pull/16968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
cmccabe commented on code in PR #16968:
URL: https://github.com/apache/kafka/pull/16968#discussion_r1729461523
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1397,20 +1397,15 @@ class KafkaApis(val requestChannel: RequestChannel,
trace("Sending topic metadata
[
https://issues.apache.org/jira/browse/KAFKA-17053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876357#comment-17876357
]
Greg Harris commented on KAFKA-17053:
-
I copied my original upstream bug report to t
mjsax commented on code in PR #16803:
URL: https://github.com/apache/kafka/pull/16803#discussion_r1729440374
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -450,22 +450,6 @@ public KStream peek(final ForeachAction action,
mumrah commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1729433979
##
core/src/main/java/kafka/server/share/DelayedShareFetchKey.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
[
https://issues.apache.org/jira/browse/KAFKA-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-12818.
-
Resolution: Duplicate
> Memory leakage when kafka connect 2.7 uses directory config provider
> -
[
https://issues.apache.org/jira/browse/KAFKA-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876353#comment-17876353
]
Greg Harris commented on KAFKA-12818:
-
Thanks [~dnk] for finding the duplicate!
> M
[
https://issues.apache.org/jira/browse/KAFKA-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-17291.
--
Resolution: Fixed
> Add integration test for share group list and describe admin calls
mumrah commented on code in PR #16921:
URL: https://github.com/apache/kafka/pull/16921#discussion_r1729403619
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/PersisterOffsetsStateBatch.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Founda
kirktrue opened a new pull request, #16990:
URL: https://github.com/apache/kafka/pull/16990
`AccessTokenRetrieverFactory` uses the value of
`sasl.oauthbearer.header.urlencode` provided by the user, or `null` if no value
was provided for that configuration. When the `HttpAccessTokenRetriever
[
https://issues.apache.org/jira/browse/KAFKA-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17335:
--
Summary: Lack of default for URL encoding configuration for OAuth causes
NPE (was: Lack of default fo
kirktrue commented on code in PR #16951:
URL: https://github.com/apache/kafka/pull/16951#discussion_r1729340166
##
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##
@@ -529,6 +530,24 @@ private static ArgumentParser argParser() {
.metavar("T
kirktrue commented on PR #16951:
URL: https://github.com/apache/kafka/pull/16951#issuecomment-2307563286
@chia7712 @lucasbru @cadonna—would one of you be willing to review this
cherry-pick? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
mumrah opened a new pull request, #16989:
URL: https://github.com/apache/kafka/pull/16989
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
chia7712 merged PR #16975:
URL: https://github.com/apache/kafka/pull/16975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on code in PR #16956:
URL: https://github.com/apache/kafka/pull/16956#discussion_r1729291803
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -881,6 +881,7 @@ private void initialize() {
TopicData state = response.topicsData().get(0
abhishekgiri23 opened a new pull request, #16988:
URL: https://github.com/apache/kafka/pull/16988
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
mumrah merged PR #41:
URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@
mumrah opened a new pull request, #41:
URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/41
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
mumrah merged PR #40:
URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@
mumrah opened a new pull request, #40:
URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/40
For now, this file just contains a mapping of Github ID to ASF ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
junrao commented on code in PR #16339:
URL: https://github.com/apache/kafka/pull/16339#discussion_r1729262714
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -632,6 +711,524 @@ private boolean checkForFullMatch(InFlightBatch
inFlightBatch, long firstOffsetT
chia7712 commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1729241006
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -71,7 +71,7 @@ public class GroupCoordinatorConfig {
/**
AndrewJSchofield commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1729222379
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -533,178 +538,52 @@ void maybeProcessFetchQueue() {
shareFetchP
AndrewJSchofield commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1729216536
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -533,178 +538,52 @@ void maybeProcessFetchQueue() {
shareFetchP
gharris1727 commented on code in PR #16914:
URL: https://github.com/apache/kafka/pull/16914#discussion_r1729200162
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##
@@ -436,6 +430,8 @@ private StateConsumer initialize() {
chia7712 commented on PR #16957:
URL: https://github.com/apache/kafka/pull/16957#issuecomment-2307375843
@m1a2st could you please add timeout to `@ClusterTemplate`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
chia7712 commented on code in PR #16957:
URL: https://github.com/apache/kafka/pull/16957#discussion_r1729196478
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -34,6 +35,7 @@
@Target({METHOD})
@Retention(RUNTIME)
@TestTemplate
+@Timeout(30)
Review Comment
jolshan commented on code in PR #16719:
URL: https://github.com/apache/kafka/pull/16719#discussion_r1729197382
##
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##
@@ -517,47 +526,90 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
[
https://issues.apache.org/jira/browse/KAFKA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-14572:
-
Assignee: Omnia Ibrahim (was: Matthew de Detrich)
> Migrate EmbeddedKafkaCluster used
[
https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876305#comment-17876305
]
zhengke zhou commented on KAFKA-16538:
--
Hi @José Armando García Sancio, I'm current
jolshan commented on code in PR #16873:
URL: https://github.com/apache/kafka/pull/16873#discussion_r1729181192
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1103,35 +1103,41 @@ class KafkaApis(val requestChannel: RequestChannel,
val responseTopics = authoriz
bachmanity1 commented on code in PR #16968:
URL: https://github.com/apache/kafka/pull/16968#discussion_r1729178685
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1397,20 +1397,15 @@ class KafkaApis(val requestChannel: RequestChannel,
trace("Sending topic meta
FrankYang0529 commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1729165197
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2471,6 +2477,8 @@ public void testCurrentLag(GroupProtocol groupProtocol
mumrah commented on code in PR #16968:
URL: https://github.com/apache/kafka/pull/16968#discussion_r1729147848
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1397,20 +1397,15 @@ class KafkaApis(val requestChannel: RequestChannel,
trace("Sending topic metadata
dajac commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1729122211
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -256,6 +278,32 @@ public void testDynamicBrokerConfigUpdateUsingKraft()
throws Exception {
mumrah commented on PR #16960:
URL: https://github.com/apache/kafka/pull/16960#issuecomment-2307287590
Thanks for the patch @mimaison! I missed that second point in the INFRA
policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mumrah commented on PR #16957:
URL: https://github.com/apache/kafka/pull/16957#issuecomment-2307276425
@m1a2st can you pull in the latest trunk changes? I have added code to
report the JUnit failures in the Github Actions workflows. I want to do a few
runs with this change to ensure we have
xijiu opened a new pull request, #16987:
URL: https://github.com/apache/kafka/pull/16987
As title, setting `print.epoch=true` can show the
`ConsumerRecord#leaderEpoch`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify tes
1 - 100 of 170 matches
Mail list logo
