chia7712 commented on code in PR #16493:
URL: https://github.com/apache/kafka/pull/16493#discussion_r1743152201
##
core/src/test/java/kafka/admin/AclCommandTest.java:
##
@@ -246,32 +275,54 @@ public void
testProducerConsumerCliWithAuthorizer(ClusterInstance cluster) {
frankvicky opened a new pull request, #17083:
URL: https://github.com/apache/kafka/pull/17083
JIRA: [KAFKA-16207](https://issues.apache.org/jira/browse/KAFKA-16027)
> MetadataTest#testUpdatePartitionLeadership is extremely long. I think it
is pretty close to the 160 line method limit
gongxuanzhang opened a new pull request, #17082:
URL: https://github.com/apache/kafka/pull/17082
handle https://issues.apache.org/jira/browse/KAFKA-12601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gongxuanzhang commented on PR #17027:
URL: https://github.com/apache/kafka/pull/17027#issuecomment-2327984958
@chia7712 i updated `upgrade.html` PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/KAFKA-17057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17057:
Labels: kip (was: )
> Add "retry" option to ProductionExceptionHandler
>
[
https://issues.apache.org/jira/browse/KAFKA-17475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17475:
--
Assignee: Eric Chang (was: Chia-Ping Tsai)
> Change the base image of e2e from openj
[
https://issues.apache.org/jira/browse/KAFKA-12601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879101#comment-17879101
]
xuanzhang gong commented on KAFKA-12601:
Hi,I noticed that this issue hasn't be
Chia-Ping Tsai created KAFKA-17475:
--
Summary: Change the base image of e2e from openjdk to
eclipse-temurin
Key: KAFKA-17475
URL: https://issues.apache.org/jira/browse/KAFKA-17475
Project: Kafka
chia7712 commented on code in PR #16991:
URL: https://github.com/apache/kafka/pull/16991#discussion_r1743091284
##
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##
@@ -247,52 +241,16 @@ public Map controllers() {
public void format() throws Ex
TaiJuWu opened a new pull request, #17080:
URL: https://github.com/apache/kafka/pull/17080
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
rich-c-shop opened a new pull request, #17079:
URL: https://github.com/apache/kafka/pull/17079
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=125310116
https://issues.apache.org/jira/browse/KAFKA-8830
*Summary of testing strategy (including rationale)
for the fe
m1a2st commented on code in PR #16899:
URL: https://github.com/apache/kafka/pull/16899#discussion_r1742852336
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -727,6 +731,20 @@ private void checkGroupRemoteAssignor() {
}
}
+
FrankYang0529 commented on PR #16493:
URL: https://github.com/apache/kafka/pull/16493#issuecomment-2327691307
Hi @chia7712, I addressed all comments. Could you take a look again? Thank
you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
FrankYang0529 commented on code in PR #16213:
URL: https://github.com/apache/kafka/pull/16213#discussion_r1742844527
##
build.gradle:
##
@@ -2311,6 +2311,12 @@ project(':tools') {
exclude group: 'junit', module: 'junit'
}
testImplementation libs.reload4j
+te
[
https://issues.apache.org/jira/browse/KAFKA-15198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
João Pedro Fonseca reassigned KAFKA-15198:
--
Assignee: João Pedro Fonseca
> Improve version release scripts
>
[
https://issues.apache.org/jira/browse/KAFKA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879062#comment-17879062
]
黃竣陽 commented on KAFKA-17338:
-
Thanks you, [~kirktrue]
> ConsumerConfig should prevent usi
[
https://issues.apache.org/jira/browse/KAFKA-17445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879060#comment-17879060
]
Rohit Bobade edited comment on KAFKA-17445 at 9/4/24 12:19 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-17445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879061#comment-17879061
]
Rohit Bobade commented on KAFKA-17445:
--
Acceptable recovery lag was set to 0 becaus
[
https://issues.apache.org/jira/browse/KAFKA-17445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879060#comment-17879060
]
Rohit Bobade commented on KAFKA-17445:
--
[~cadonna] we set the group instance id fo
[
https://issues.apache.org/jira/browse/KAFKA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879058#comment-17879058
]
João Pedro Fonseca commented on KAFKA-16871:
[~ableegoldman], as stated by W
[
https://issues.apache.org/jira/browse/KAFKA-16339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879057#comment-17879057
]
Matthias J. Sax commented on KAFKA-16339:
-
[~vrushankpatel] – when do you plan t
mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1742819290
##
docs/streams/developer-guide/config-streams.html:
##
@@ -83,6 +83,7 @@
probing.rebalance.interval.ms
processing.exception.handler
fonsdant commented on code in PR #17038:
URL: https://github.com/apache/kafka/pull/17038#discussion_r1742821094
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnectorTest.java:
##
@@ -151,7 +155,14 @@ public void testFindConsumerGroups() throws
mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1742819658
##
docs/streams/developer-guide/config-streams.html:
##
@@ -70,11 +70,11 @@
Optional configuration
parameters
acceptable.recovery
mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1742819478
##
docs/streams/developer-guide/config-streams.html:
##
@@ -70,11 +70,11 @@
Optional configuration
parameters
acceptable.recovery
mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1742819290
##
docs/streams/developer-guide/config-streams.html:
##
@@ -83,6 +83,7 @@
probing.rebalance.interval.ms
processing.exception.handler
mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1742817450
##
docs/streams/upgrade-guide.html:
##
@@ -135,6 +135,12 @@ <
Streams API changes in 4.0.0
+
+In this release two configs default.deserialization.exc
[
https://issues.apache.org/jira/browse/KAFKA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
João Pedro Fonseca reassigned KAFKA-16871:
--
Assignee: João Pedro Fonseca
> Clean up internal AssignmentConfigs class in S
mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1742816586
##
docs/streams/upgrade-guide.html:
##
@@ -135,6 +135,12 @@ <
Streams API changes in 4.0.0
+
+In this release two configs default.deserialization.exc
[
https://issues.apache.org/jira/browse/KAFKA-17170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879055#comment-17879055
]
João Pedro Fonseca commented on KAFKA-17170:
[~lianetm], many thanks! I have
mjsax commented on PR #16988:
URL: https://github.com/apache/kafka/pull/16988#issuecomment-2327631024
@abhishekgiri23 -- Any updates on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
fonsdant commented on PR #17038:
URL: https://github.com/apache/kafka/pull/17038#issuecomment-2327622037
@gharris1727, thank you for the appointed issues! As suggested, the public
access modifier has been removed, a single groupSpec for map entries has been
created, and tests have been mock
eduwercamacaro commented on PR #16705:
URL: https://github.com/apache/kafka/pull/16705#issuecomment-2327622257
Sure, no objections here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/KAFKA-16138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16138:
--
Component/s: system tests
> QuotaTest system test fails consistently in 3.7
>
[
https://issues.apache.org/jira/browse/KAFKA-16138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16138:
-
Assignee: Philip Nee
> QuotaTest system test fails consistently in 3.7
> --
[
https://issues.apache.org/jira/browse/KAFKA-16138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16138:
--
Component/s: clients
consumer
> QuotaTest system test fails consistently in 3.7
> ---
mjsax commented on code in PR #17054:
URL: https://github.com/apache/kafka/pull/17054#discussion_r1742802877
##
streams/src/test/java/org/apache/kafka/streams/integration/ProcessingExceptionHandlerIntegrationTest.java:
##
@@ -61,6 +61,8 @@
public class ProcessingExceptionHandle
mjsax commented on code in PR #17054:
URL: https://github.com/apache/kafka/pull/17054#discussion_r1742802585
##
streams/src/test/java/org/apache/kafka/streams/integration/ProcessingExceptionHandlerIntegrationTest.java:
##
@@ -61,6 +61,8 @@
public class ProcessingExceptionHandle
cmccabe merged PR #17037:
URL: https://github.com/apache/kafka/pull/17037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe merged PR #17051:
URL: https://github.com/apache/kafka/pull/17051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mjsax commented on PR #17054:
URL: https://github.com/apache/kafka/pull/17054#issuecomment-2327596627
Build failed:
```
Task :streams:checkstyleTest
--
| 3985 | 01:49:01 AM | [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-17054/streams/src/
jolshan merged PR #16973:
URL: https://github.com/apache/kafka/pull/16973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-17466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17466:
--
Component/s: clients
consumer
> Revisit failAndRemoveExpiredCommitRequests method
> -
[
https://issues.apache.org/jira/browse/KAFKA-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17456:
--
Component/s: clients
consumer
> Make sure FindCoordinatorResponse get created before
apoorvmittal10 commented on code in PR #17070:
URL: https://github.com/apache/kafka/pull/17070#discussion_r1742724978
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -193,11 +194,16 @@ public static RecordState forId(byte id) {
*/
private final int
kirktrue commented on PR #17035:
URL: https://github.com/apache/kafka/pull/17035#issuecomment-2327495687
@AndrewJSchofield, et al.—it can be helpful to compare the flow of
`ClassicKafkaConsumer.poll()` and `AsyncKafkaConsumer.poll()`, specifically how
it invokes fetch. Note that the `sendFe
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1742728621
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -683,10 +683,6 @@ public ConsumerRecords poll(final Duration timeou
kirktrue commented on PR #17035:
URL: https://github.com/apache/kafka/pull/17035#issuecomment-2327491994
Hi @AndrewJSchofield!
Thanks for the review 👍
> First, I think it better not to overload the PollEvent because that's
already used in the share consumer.
Agreed. I'v
smjn commented on PR #17011:
URL: https://github.com/apache/kafka/pull/17011#issuecomment-2327480006
@junrao Thanks for the review, incorporated comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
apoorvmittal10 commented on code in PR #16916:
URL: https://github.com/apache/kafka/pull/16916#discussion_r1742713694
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -0,0 +1,1861 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
mjsax commented on code in PR #17078:
URL: https://github.com/apache/kafka/pull/17078#discussion_r1742707126
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##
@@ -288,7 +288,6 @@ public void run() {
return;
mjsax opened a new pull request, #17078:
URL: https://github.com/apache/kafka/pull/17078
KAFKA-17100 changed the behavior of GlobalStreamThread introducing a race
condition for state changes, that was exposed by failing (flaky) tests in
GlobalStreamThreadTest.
This PR moves the state
[
https://issues.apache.org/jira/browse/KAFKA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879025#comment-17879025
]
Matthias J. Sax commented on KAFKA-15344:
-
Should we close this one, in favor of
[
https://issues.apache.org/jira/browse/KAFKA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15344:
---
Assignee: Alieh Saeedi (was: Lucas Brutschy)
> Kafka Streams should include the me
[
https://issues.apache.org/jira/browse/KAFKA-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-16502:
-
> Fix flaky
> EOSUncleanShutdownIntegrationTest#shouldWorkWithUncleanShutdownWipeOutStateSt
[
https://issues.apache.org/jira/browse/KAFKA-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-16502.
-
Resolution: Fixed
> Fix flaky
> EOSUncleanShutdownIntegrationTest#shouldWorkWithUnclean
[
https://issues.apache.org/jira/browse/KAFKA-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-16502:
---
Assignee: (was: Matthias J. Sax)
> Fix flaky
> EOSUncleanShutdownIntegrationTe
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1742688610
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -159,6 +159,9 @@ private void process(final PollEvent
[
https://issues.apache.org/jira/browse/KAFKA-17467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-17467.
-
Resolution: Duplicate
> Flaky test shouldStayDeadAfterTwoCloses
> org.apache.kafka.stre
chia7712 commented on PR #17067:
URL: https://github.com/apache/kafka/pull/17067#issuecomment-2327405737
> let me know if we need to backport
Yes, it needs to be backport to 3.9. Other branches (3.8 and 3.7) have no
such issue in e2e (I have left the root cause in the jira)
--
This
kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1742664983
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -683,10 +683,6 @@ public ConsumerRecords poll(final Duration timeou
[
https://issues.apache.org/jira/browse/KAFKA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879020#comment-17879020
]
Kirk True commented on KAFKA-17338:
---
[~m1a2st]—I assigned this to you and updated the
[
https://issues.apache.org/jira/browse/KAFKA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17338:
--
Fix Version/s: 4.0.0
> ConsumerConfig should prevent using partition assignors with CONSUMER group
>
kirktrue commented on code in PR #16899:
URL: https://github.com/apache/kafka/pull/16899#discussion_r1742655561
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -727,6 +731,20 @@ private void checkGroupRemoteAssignor() {
}
}
+
[
https://issues.apache.org/jira/browse/KAFKA-17474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-17474:
---
Assignee: Matthias J. Sax
> Flaky tests in GlobalStreamThreadTest
> ---
smjn commented on code in PR #17011:
URL: https://github.com/apache/kafka/pull/17011#discussion_r1742647736
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##
@@ -17,58 +17,552 @@
package org.apache.kafka.coordinator.share;
[
https://issues.apache.org/jira/browse/KAFKA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-17338:
-
Assignee: 黃竣陽 (was: Kirk True)
> ConsumerConfig should prevent using partition assignors with
[
https://issues.apache.org/jira/browse/KAFKA-17474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879010#comment-17879010
]
Matthias J. Sax commented on KAFKA-17474:
-
Did find
[https://github.com/apache/
cmccabe merged PR #16517:
URL: https://github.com/apache/kafka/pull/16517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kirktrue commented on PR #16951:
URL: https://github.com/apache/kafka/pull/16951#issuecomment-2327335265
Thanks @lianetm!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-17410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878999#comment-17878999
]
Lianet Magrans commented on KAFKA-17410:
Hey [~frankvicky], I would say it's exp
lianetm merged PR #16951:
URL: https://github.com/apache/kafka/pull/16951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
smjn commented on code in PR #17011:
URL: https://github.com/apache/kafka/pull/17011#discussion_r1742573707
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1689,8 +1694,8 @@ class KafkaApis(val requestChannel: RequestChannel,
(txnCoordinator.partitionFor(k
kamalcph commented on PR #16602:
URL: https://github.com/apache/kafka/pull/16602#issuecomment-2327203060
@showuon @chia7712 @satishd @clolov
The diff is ready for review. PTAL. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
omkreddy merged PR #17039:
URL: https://github.com/apache/kafka/pull/17039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on code in PR #17011:
URL: https://github.com/apache/kafka/pull/17011#discussion_r1739451920
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##
@@ -17,58 +17,552 @@
package org.apache.kafka.coordinator.share;
chia7712 merged PR #17073:
URL: https://github.com/apache/kafka/pull/17073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
wernerdv commented on code in PR #16967:
URL: https://github.com/apache/kafka/pull/16967#discussion_r1742504820
##
server-common/src/main/java/org/apache/kafka/common/ClientIdAndBroker.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
mumrah opened a new pull request, #17077:
URL: https://github.com/apache/kafka/pull/17077
We are using short-lived access tokens for ge.apache.org. The default expiry
time is 2 hours which is not long enough for some of our CI workflows. This
patch increases the expiry to 4 hours. This give
gharris1727 commented on code in PR #16950:
URL: https://github.com/apache/kafka/pull/16950#discussion_r1742487183
##
build.gradle:
##
@@ -1674,7 +1730,6 @@ project(':clients') {
configurations {
generator
-shadowed
Review Comment:
I don't really know what this
[
https://issues.apache.org/jira/browse/KAFKA-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17468.
Fix Version/s: 4.0.0
Resolution: Fixed
> Move kafka.log.remote.quota to storage mod
[
https://issues.apache.org/jira/browse/KAFKA-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878971#comment-17878971
]
Chia-Ping Tsai commented on KAFKA-16412:
[~gendong1] sorry for late response. th
chia7712 merged PR #17074:
URL: https://github.com/apache/kafka/pull/17074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gharris1727 commented on code in PR #17038:
URL: https://github.com/apache/kafka/pull/17038#discussion_r1742462093
##
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java:
##
@@ -40,7 +40,7 @@ public class ListConsumerGroupOffsetsResult {
chia7712 commented on code in PR #17027:
URL: https://github.com/apache/kafka/pull/17027#discussion_r1742464133
##
docs/upgrade.html:
##
@@ -30,6 +30,9 @@ Notable changes in 4
Review Comment:
Please add the docs for the removed configs explicitly.
--
This i
mimaison commented on code in PR #16967:
URL: https://github.com/apache/kafka/pull/16967#discussion_r1742457005
##
server-common/src/main/java/org/apache/kafka/common/ClientIdAndBroker.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
chia7712 commented on code in PR #16899:
URL: https://github.com/apache/kafka/pull/16899#discussion_r1742455301
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java:
##
@@ -237,4 +238,26 @@ public void testProtocolConfigValidation(String protocol,
jolshan commented on code in PR #16898:
URL: https://github.com/apache/kafka/pull/16898#discussion_r1742450414
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3438,15 +3477,30 @@ public void replay(
String groupId
chia7712 commented on code in PR #16991:
URL: https://github.com/apache/kafka/pull/16991#discussion_r1742439377
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -404,22 +423,44 @@ private void formatNode(
boolean writeMetadataDirectory
) {
jolshan commented on code in PR #16898:
URL: https://github.com/apache/kafka/pull/16898#discussion_r1742434132
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -848,26 +844,32 @@ ConsumerGroup consumerGroup(
ConsumerGrou
[
https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17116:
--
Labels: kip-848-client-support needs-kip (was: kip-848-client-support)
> New consumer may not send ef
[
https://issues.apache.org/jira/browse/KAFKA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878956#comment-17878956
]
Kirk True commented on KAFKA-17338:
---
[~m1a2st] do you want to assign this to yourself,
cmccabe commented on code in PR #16991:
URL: https://github.com/apache/kafka/pull/16991#discussion_r1742411462
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -404,22 +423,44 @@ private void formatNode(
boolean writeMetadataDirectory
) {
cmccabe commented on code in PR #16991:
URL: https://github.com/apache/kafka/pull/16991#discussion_r1742410514
##
core/src/main/java/kafka/server/ServerSocketFactory.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
cmccabe commented on code in PR #16991:
URL: https://github.com/apache/kafka/pull/16991#discussion_r1742405774
##
core/src/test/java/kafka/testkit/PreboundSocketFactoryManager.java:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
kirktrue commented on PR #16951:
URL: https://github.com/apache/kafka/pull/16951#issuecomment-2327027667
> Is there a run of the system tests with this change?
Yes, there's we ran this internally a few times and the tests were able to
run successfully.
--
This is an automated messa
nicktelford commented on code in PR #16922:
URL: https://github.com/apache/kafka/pull/16922#discussion_r1742399624
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##
@@ -182,6 +206,118 @@ private boolean lockStateDirectory() {
nicktelford commented on code in PR #16922:
URL: https://github.com/apache/kafka/pull/16922#discussion_r1742159162
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##
@@ -182,6 +206,118 @@ private boolean lockStateDirectory() {
junrao commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1742393681
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -564,16 +592,29 @@ void maybeProcessFetchQueue() {
);
squah-confluent commented on code in PR #17072:
URL: https://github.com/apache/kafka/pull/17072#discussion_r1742385814
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -1140,20 +1154,22 @@ public void testFetchOffsets(
1 - 100 of 190 matches
Mail list logo
