FrankYang0529 commented on PR #17233:
URL: https://github.com/apache/kafka/pull/17233#issuecomment-2365030214
Hi @dajac, I fixed both `testGroupEpochBumpWhenNewStaticMemberJoins` and
`testNewJoiningMemberTriggersNewTargetAssignment`. Originally, different
`partitionRacks` triggers subscript
TaiJuWu commented on code in PR #17080:
URL: https://github.com/apache/kafka/pull/17080#discussion_r1769485396
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4143,19 +4140,27 @@ public RemoveMembersFromConsumerGroupResult
removeMembersFrom
frankvicky commented on code in PR #17080:
URL: https://github.com/apache/kafka/pull/17080#discussion_r1769459881
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4143,19 +4140,27 @@ public RemoveMembersFromConsumerGroupResult
removeMembersF
frankvicky commented on code in PR #17026:
URL: https://github.com/apache/kafka/pull/17026#discussion_r1769459432
##
core/src/main/scala/kafka/server/DelegationTokenManagerZk.scala:
##
@@ -292,6 +298,8 @@ class DelegationTokenManagerZk(config: KafkaConfig,
expireR
TaiJuWu commented on code in PR #17080:
URL: https://github.com/apache/kafka/pull/17080#discussion_r1769451569
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4114,27 +4114,28 @@ private Integer nodeFor(ConfigResource resource) {
}
mumrah commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1769451414
##
.github/workflows/ci-complete.yml:
##
@@ -118,3 +118,16 @@ jobs:
description: 'The build scan was successfully published'
context: 'Gradle Build
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2364835739
Hi, @mumrah! I have made some modifications. I have used `switch` as it
seems more semantic. Instead of merge, I have chosen to use `reset --hard` to
prevent any conflicts that `merge` c
chia7712 commented on code in PR #17205:
URL: https://github.com/apache/kafka/pull/17205#discussion_r1769380792
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java:
##
@@ -73,68 +69,95 @@ public T deseriali
chia7712 closed pull request #16575: MINOR: Remove incompatible system ducktape
upgrade tests
URL: https://github.com/apache/kafka/pull/16575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
chia7712 commented on PR #16575:
URL: https://github.com/apache/kafka/pull/16575#issuecomment-2364792434
@lzyLuke thanks for your contribution and sorry that we did not review your
PR in time. The issue was fixed by #17024 already. Hence, I'm going to close
this PR.
--
This is an automat
chia7712 commented on PR #17207:
URL: https://github.com/apache/kafka/pull/17207#issuecomment-2364791530
@mjsax Could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on code in PR #17212:
URL: https://github.com/apache/kafka/pull/17212#discussion_r1769375309
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java:
##
@@ -318,14 +314,7 @@ Map producerMetrics() {
}
Set produce
[
https://issues.apache.org/jira/browse/KAFKA-17589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883437#comment-17883437
]
Chia-Ping Tsai commented on KAFKA-17589:
{quote}
In order to avoid compile-time
mjsax commented on code in PR #17170:
URL: https://github.com/apache/kafka/pull/17170#discussion_r1769345829
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java:
##
@@ -102,11 +101,11 @@ public class StreamsProducerTest {
mkEnt
mjsax commented on code in PR #17108:
URL: https://github.com/apache/kafka/pull/17108#discussion_r1769344246
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -742,9 +742,9 @@ boolean runLoop() {
errorMessage.star
unknowntpo commented on code in PR #17240:
URL: https://github.com/apache/kafka/pull/17240#discussion_r1769341079
##
tests/docker/Dockerfile:
##
@@ -62,8 +62,12 @@ LABEL ducker.creator=$ducker_creator
# Update Linux and install necessary utilities.
# we have to install git sin
mjsax merged PR #17170:
URL: https://github.com/apache/kafka/pull/17170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on code in PR #17231:
URL: https://github.com/apache/kafka/pull/17231#discussion_r1769332465
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##
@@ -109,62 +109,34 @@ public class QuorumConfig {
.define(QUORUM_REQUEST_TIMEOUT_MS_CONF
jeffkbkim commented on code in PR #17221:
URL: https://github.com/apache/kafka/pull/17221#discussion_r1769334386
##
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java:
##
@@ -172,4 +177,39 @@ public void testHistogramDataReset() {
chia7712 commented on code in PR #16912:
URL: https://github.com/apache/kafka/pull/16912#discussion_r1769331209
##
core/src/test/java/kafka/security/JaasTestUtils.java:
##
@@ -269,4 +275,108 @@ private static void writeToFile(File file,
List jaasSections) throw
wri
chia7712 commented on code in PR #17026:
URL: https://github.com/apache/kafka/pull/17026#discussion_r1769327949
##
core/src/main/scala/kafka/server/DelegationTokenManagerZk.scala:
##
@@ -292,6 +298,8 @@ class DelegationTokenManagerZk(config: KafkaConfig,
expireRes
chia7712 commented on code in PR #17080:
URL: https://github.com/apache/kafka/pull/17080#discussion_r1769326791
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4114,27 +4114,28 @@ private Integer nodeFor(ConfigResource resource) {
}
chia7712 commented on code in PR #17174:
URL: https://github.com/apache/kafka/pull/17174#discussion_r1769323985
##
storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java:
##
@@ -0,0 +1,809 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
[
https://issues.apache.org/jira/browse/KAFKA-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883421#comment-17883421
]
Chia-Ping Tsai commented on KAFKA-17587:
{quote}
It is possible to automaticall
fonsdant commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2364683492
I am happy to help! :)
Sure! I will give it a try. It seems simpler for me too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883417#comment-17883417
]
David Arthur commented on KAFKA-17587:
--
It is possible to automatically load JUnit
[
https://issues.apache.org/jira/browse/KAFKA-17589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-17589:
-
Description:
Create a new Gradle module "test-common" where our JUnit extensions and
annotation
[
https://issues.apache.org/jira/browse/KAFKA-17567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17567.
Fix Version/s: 4.0.0
Resolution: Fixed
> Remove TestTruncate
> ---
chia7712 merged PR #17234:
URL: https://github.com/apache/kafka/pull/17234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #17240:
URL: https://github.com/apache/kafka/pull/17240#discussion_r1769279329
##
tests/docker/Dockerfile:
##
@@ -62,8 +62,12 @@ LABEL ducker.creator=$ducker_creator
# Update Linux and install necessary utilities.
# we have to install git since
[
https://issues.apache.org/jira/browse/KAFKA-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883413#comment-17883413
]
Chia-Ping Tsai commented on KAFKA-17587:
{quote}
We should refactor our test in
chia7712 commented on code in PR #16686:
URL: https://github.com/apache/kafka/pull/16686#discussion_r1769232359
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1291,6 +1294,10 @@ private void releaseAssignmentAndLeaveGroup(fin
David Arthur created KAFKA-17589:
Summary: Move JUnit extensions to test-common module
Key: KAFKA-17589
URL: https://issues.apache.org/jira/browse/KAFKA-17589
Project: Kafka
Issue Type: Sub-t
David Arthur created KAFKA-17588:
Summary: Remove internal classes from ClusterInstance
Key: KAFKA-17588
URL: https://issues.apache.org/jira/browse/KAFKA-17588
Project: Kafka
Issue Type: Sub-
David Arthur created KAFKA-17587:
Summary: Move test infrastructure out of core
Key: KAFKA-17587
URL: https://issues.apache.org/jira/browse/KAFKA-17587
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-16813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16813.
Fix Version/s: 4.0.0
Resolution: Fixed
> Add global timeout for "@Test" and "@TestT
chia7712 merged PR #16957:
URL: https://github.com/apache/kafka/pull/16957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-17307.
--
Resolution: Duplicate
> Remove junit-platform.properties from test JARs
>
mimaison commented on PR #17223:
URL: https://github.com/apache/kafka/pull/17223#issuecomment-2364167668
> Maybe we can use ApiKeys instead?
Yes that's also an option. I'd really prefer this or pattern matching over
the current code.
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/KAFKA-16779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883351#comment-17883351
]
Nicholas Feinberg commented on KAFKA-16779:
---
This issue seems to only reproduc
mumrah commented on PR #17204:
URL: https://github.com/apache/kafka/pull/17204#issuecomment-2364112462
@fonsdant first off, thanks for all the work on this. I was pondering this
yesterday and had an idea. Instead of managing a tag, I think we can use a
separate branch, something like `trunk
chia7712 commented on PR #17223:
URL: https://github.com/apache/kafka/pull/17223#issuecomment-2364080112
> I wonder if we should wait for server to switch to Java 17 before merging
this. With Java 17, we will be able to use pattern matching and significantly
simplify the logic. The huge lis
fonsdant opened a new pull request, #17245:
URL: https://github.com/apache/kafka/pull/17245
This PR has as base the PR: #17198.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
[
https://issues.apache.org/jira/browse/KAFKA-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri updated KAFKA-17428:
Summary: Add retry mechanism for cleaning up dangling remote segments
(was: Remote segmen
FrankYang0529 commented on PR #17233:
URL: https://github.com/apache/kafka/pull/17233#issuecomment-2364063359
Hi @dajac, thanks for review and suggestion. I addressed all comments.
However, both
`GroupMetadataManagerTest#testGroupEpochBumpWhenNewStaticMemberJoins` and
`GroupMetadataManager
[
https://issues.apache.org/jira/browse/KAFKA-17585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17585:
--
Assignee: kangning.li (was: Chia-Ping Tsai)
> `offsetResetStrategyTimestamp` should
[
https://issues.apache.org/jira/browse/KAFKA-17585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883306#comment-17883306
]
kangning.li commented on KAFKA-17585:
-
[~chia7712] I am interested in this issue.Cl
FrankYang0529 opened a new pull request, #17244:
URL: https://github.com/apache/kafka/pull/17244
If AsyncKafkaConsumer subscribes an invalid topic, the background thread
will keep sending MetadataRequest with invalid topic, so background event queue
will keep receiving ErrorEvent. When Asyn
bbejeck commented on PR #17016:
URL: https://github.com/apache/kafka/pull/17016#issuecomment-2363862789
@OmniaGM I just looked at the build report from my sample PR, and there
were a bunch of failures for the integration tests, where they were all passing
locally so we'll see how it goes f
[
https://issues.apache.org/jira/browse/KAFKA-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883296#comment-17883296
]
Doug Whitfield commented on KAFKA-9228:
---
We performed the test with Mongodb connect
[ https://issues.apache.org/jira/browse/KAFKA-17585 ]
Jie-Kai(Jay) Chang deleted comment on KAFKA-17585:
was (Author: JIRAUSER306922):
I want to do this?
> `offsetResetStrategyTimestamp` should return `long` instead of `Long`
>
Chia-Ping Tsai created KAFKA-17586:
--
Summary: AsyncKafkaConsumer#seek should NOT wait the completion of
backgound
Key: KAFKA-17586
URL: https://issues.apache.org/jira/browse/KAFKA-17586
Project: Kafk
[
https://issues.apache.org/jira/browse/KAFKA-17585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883286#comment-17883286
]
Jie-Kai(Jay) Chang commented on KAFKA-17585:
I want to do this?
> `offsetRe
chia7712 commented on code in PR #17230:
URL: https://github.com/apache/kafka/pull/17230#discussion_r1768677518
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -842,8 +843,8 @@ public void seekToEnd(Collection
partitions) {
chia7712 commented on code in PR #17230:
URL: https://github.com/apache/kafka/pull/17230#discussion_r1768666772
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -842,8 +843,8 @@ public void seekToEnd(Collection
partitions) {
mimaison commented on PR #17223:
URL: https://github.com/apache/kafka/pull/17223#issuecomment-2363790222
I wonder if we should wait for server to switch to Java 17 before merging
this. With Java 17, we will be able to use pattern matching and significantly
simplify the logic. The huge list
Chia-Ping Tsai created KAFKA-17585:
--
Summary: `offsetResetStrategyTimestamp` should return `long`
instead of `Long`
Key: KAFKA-17585
URL: https://issues.apache.org/jira/browse/KAFKA-17585
Project: Ka
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883257#comment-17883257
]
Federico Valeri edited comment on KAFKA-17584 at 9/20/24 1:19 PM:
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883257#comment-17883257
]
Federico Valeri commented on KAFKA-17584:
-
I can confirm the issue as described.
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-17584:
--
Affects Version/s: 3.9.0
> Changing dynamic configurations resets retention
>
OmniaGM commented on PR #17016:
URL: https://github.com/apache/kafka/pull/17016#issuecomment-2363666325
> Hi @OmniaGM - I took a pass and and found the problem.
>
> For the failing tests, the `EmbeddedKafkaCluster` started with time `0`;
subsequently, the log cleaner would run and del
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-17584:
--
Description:
Updating certain dynamic configurations (for example `message.max.bytes`)
causes
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-17584:
--
Description:
Updating certain dynamic configurations (for example `message.max.bytes`)
causes
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-17584:
--
Description:
Updating certain dynamic configurations (for example `message.max.bytes`)
causes
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-17584:
--
Priority: Blocker (was: Major)
> Changing dynamic configurations resets retention
> -
[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-17584:
--
Description:
Updating certain dynamic configurations (for example `message.max.bytes`)
causes
Christo Lolov created KAFKA-17584:
-
Summary: Changing dynamic configurations resets retention
Key: KAFKA-17584
URL: https://issues.apache.org/jira/browse/KAFKA-17584
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov resolved KAFKA-17579.
---
Resolution: Fixed
> Dynamic LogCleaner configurations are not picked up upon restart
> -
[
https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883212#comment-17883212
]
TengYao Chi commented on KAFKA-17518:
-
Hi [~kirktrue] and [~lianetm]
I'm now readi
Linsiyuan9 commented on PR #17243:
URL: https://github.com/apache/kafka/pull/17243#issuecomment-2363291182
I think we just need to boot the way square brackets are configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Linsiyuan9 opened a new pull request, #17243:
URL: https://github.com/apache/kafka/pull/17243
…pact`
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*S
[
https://issues.apache.org/jira/browse/KAFKA-17583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-17583:
-
Assignee: Lin Siyuan
> kafka-config script cannot set `cleanup.policy=delete,compact`
> ---
[
https://issues.apache.org/jira/browse/KAFKA-17583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883181#comment-17883181
]
Luke Chen commented on KAFKA-17583:
---
[~linsiyuan], assigned to you. Thanks.
> kafka-c
[
https://issues.apache.org/jira/browse/KAFKA-17583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883177#comment-17883177
]
Lin Siyuan commented on KAFKA-17583:
Can I have this ticket
> kafka-config script
Luke Chen created KAFKA-17583:
-
Summary: kafka-config script cannot set
`cleanup.policy=delete,compact`
Key: KAFKA-17583
URL: https://issues.apache.org/jira/browse/KAFKA-17583
Project: Kafka
Iss
75 matches
Mail list logo
