Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935146957 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18171: Revert the strict config validation for 3.8 and 3.9 [kafka]

AndrewJSchofield commented on PR #18741: URL: https://github.com/apache/kafka/pull/18741#issuecomment-2623762469 > @mingyen066 Could you please add a unit test to prove that [KAFKA-18171](https://issues.apache.org/jira/browse/KAFKA-18171) gets resolved? The following cases should pass. >

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935146957 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Created] (KAFKA-18672) CoordinatorRecordSerde must validate value versions

David Jacot created KAFKA-18672: --- Summary: CoordinatorRecordSerde must validate value versions Key: KAFKA-18672 URL: https://issues.apache.org/jira/browse/KAFKA-18672 Project: Kafka Issue Type:

Re: [PR] KAFKA-18171: Revert the strict config validation for 3.8 and 3.9 [kafka]

chia7712 commented on PR #18741: URL: https://github.com/apache/kafka/pull/18741#issuecomment-2623740585 @mingyen066 Could you please add a unit test to prove that KAFKA-18171 gets resolved? The following cases should pass. ``` bootstrap.servers: >- br1:9092, br2:9092, b

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935133047 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1243 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935129769 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1243 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18171: Revert the strict config validation for 3.8 and 3.9 [kafka]

chia7712 commented on PR #18741: URL: https://github.com/apache/kafka/pull/18741#issuecomment-2623707430 yes, it needs to be backport to 3.8 > The change in behavior requiring strict validation seems reasonable for 4.0 so we probably ought to mention it in the documentation in docs/u

[jira] [Updated] (KAFKA-18655) Implement the consumer group size counter with scheduled task

[ https://issues.apache.org/jira/browse/KAFKA-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18655: Priority: Blocker (was: Major) > Implement the consumer group size counter with scheduled task >

[jira] [Updated] (KAFKA-18655) Implement the consumer group size counter with scheduled task

[ https://issues.apache.org/jira/browse/KAFKA-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18655: Fix Version/s: 4.0.0 > Implement the consumer group size counter with scheduled task > ---

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935116706 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

lucasbru commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1935117416 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -3062,7 +3062,7 @@ KStream leftJoin(final GlobalKTable globalTable, * @see #map(K

Re: [PR] KAFKA-18660: Transactions Version 2 doesn't handle epoch overflow correctly [kafka]

artemlivshits commented on code in PR #18730: URL: https://github.com/apache/kafka/pull/18730#discussion_r1933274679 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -408,13 +408,13 @@ class TransactionCoordinator(txnConfig: TransactionCon

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

adixitconfluent commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1935001816 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -648,6 +678,29 @@ public ShareAcquiredRecords acquire( }

Re: [PR] MINOR: cleanup KStream JavaDocs (5/N) - stream-globalTable-inner-join [kafka]

mjsax commented on code in PR #18747: URL: https://github.com/apache/kafka/pull/18747#discussion_r1934982323 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2693,137 +2693,110 @@ KStream leftJoin(final KTable table,

Re: [PR] MINOR: cleanup KStream JavaDocs (5/N) - stream-globalTable-inner-join [kafka]

mjsax commented on code in PR #18747: URL: https://github.com/apache/kafka/pull/18747#discussion_r1934980764 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1043,33 +1043,96 @@ public KStream leftJoin(final KTable table, }

Re: [PR] MINOR: cleanup KStream JavaDocs (5/N) - stream-globalTable-inner-join [kafka]

mjsax commented on code in PR #18747: URL: https://github.com/apache/kafka/pull/18747#discussion_r1934976718 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2301,7 +2301,7 @@ KStream join(final KTable table, * {@link ValueJoinerWithKey} will

[PR] MINOR: cleanup KStream JavaDocs (5/N) - stream-globalTable-inner-join [kafka]

mjsax opened a new pull request, #18747: URL: https://github.com/apache/kafka/pull/18747 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1934954309 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2097,279 +2103,117 @@ KStream outerJoin(final KStream otherStream, *

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

github-actions[bot] commented on PR #18673: URL: https://github.com/apache/kafka/pull/18673#issuecomment-2623418927 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [KAFKA-15579] Create GetReplicaLogInfo* handlers [kafka]

github-actions[bot] commented on PR #18670: URL: https://github.com/apache/kafka/pull/18670#issuecomment-2623418950 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

github-actions[bot] commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2623418988 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

github-actions[bot] commented on PR #18463: URL: https://github.com/apache/kafka/pull/18463#issuecomment-2623419022 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18627:add allowed modules to JaasUtils [kafka]

gongxuanzhang commented on code in PR #18683: URL: https://github.com/apache/kafka/pull/18683#discussion_r1934947509 ## clients/src/test/java/org/apache/kafka/common/security/authenticator/ClientAuthenticationFailureTest.java: ## @@ -75,6 +76,7 @@ public void setup() throws Exce

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1934937573 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2054,23 +2057,26 @@ KStream outerJoin(final KStream otherStream,

Re: [PR] KAFKA-18171: Revert the strict config validation for 3.8 and 3.9 [kafka]

mingyen066 commented on PR #18741: URL: https://github.com/apache/kafka/pull/18741#issuecomment-2623369646 @AndrewJSchofield Yeah, this change should be backported to 3.8 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-18645: New consumer should align close timeout handling with classic consumer [kafka]

kirktrue commented on PR #18702: URL: https://github.com/apache/kafka/pull/18702#issuecomment-2623352548 `request.timeout.ms` is designed to apply to _each_ discrete network request whereas the close timeout applies to the _entire_ `KafkaConsumer.close()` call. If the user provides a timeou

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

junrao commented on code in PR #18277: URL: https://github.com/apache/kafka/pull/18277#discussion_r1934835870 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -432,23 +443,29 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2623324002 @junrao—I wasn't able to reproduce the flaky behavior in `StickyAssignorTest` locally. However, `StickyAssignorTest` is a proper test in that it doesn't create and use a `KafkaConsumer`,

Re: [PR] KAFKA-14964: ClientQuotaMetadataManager should not suppress exceptions [kafka]

fonsdant closed pull request #17309: KAFKA-14964: ClientQuotaMetadataManager should not suppress exceptions URL: https://github.com/apache/kafka/pull/17309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: remove close mention from contextual processors javadoc [kafka]

fonsdant commented on PR #18746: URL: https://github.com/apache/kafka/pull/18746#issuecomment-2623279792 @mjsax, as we have agreed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] MINOR: remove close mention from contextual processors javadoc [kafka]

fonsdant opened a new pull request, #18746: URL: https://github.com/apache/kafka/pull/18746 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] KAFKA-18441: Fix flaky KafkaAdminClientTest#testAdminClientApisAuthenticationFailure [kafka]

FrankYang0529 commented on code in PR #18735: URL: https://github.com/apache/kafka/pull/18735#discussion_r1934865082 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -1783,12 +1782,14 @@ public void testDescribeTopicsWithDescribeTopicPart

[jira] [Created] (KAFKA-18671) Failed handling of fetch response should log an error message

José Armando García Sancio created KAFKA-18671: -- Summary: Failed handling of fetch response should log an error message Key: KAFKA-18671 URL: https://issues.apache.org/jira/browse/KAFKA-18671

[jira] [Resolved] (KAFKA-15944) Flaky test - verifyStore[cache=false, log=true, supplier=ROCKS_KV, kind=DSL] – org.apache.kafka.streams.integration.PositionRestartIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-15944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-15944. - Resolution: Cannot Reproduce This ticket is over a year old. Looking into recent test hi

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on PR #18721: URL: https://github.com/apache/kafka/pull/18721#issuecomment-2623213556 Java 17: ``` Found 1 test failures: FAILED ❌ KafkaAdminClientTest > testAdminClientApisAuthenticationFailure() Found 3 flaky test failures: FLAKY ⚠️ EagerConsumerCoordinatorTe

Re: [PR] MINOR: Session windows should accept zero as session gap [kafka]

mjsax commented on PR #18734: URL: https://github.com/apache/kafka/pull/18734#issuecomment-2623212817 Fix for `KakfaAdminClientTest` test already on the way: https://github.com/apache/kafka/pull/18735 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1934829273 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -42,24 +42,24 @@ import static org.apache.kafka.streams.proce

Re: [PR] MINOR: Session windows should accept zero as session gap [kafka]

mjsax commented on PR #18734: URL: https://github.com/apache/kafka/pull/18734#issuecomment-2623207970 Java 17 passed. Java 23: ``` Found 1 test failures: FAILED ❌ KafkaAdminClientTest > testAdminClientApisAuthenticationFailure() Found 2 flaky test failures: FLAKY ⚠️ Kaf

[jira] [Created] (KAFKA-18670) Update Netty dependency to fix CVE-2024-47535

Jonathan Lopez created KAFKA-18670: -- Summary: Update Netty dependency to fix CVE-2024-47535 Key: KAFKA-18670 URL: https://issues.apache.org/jira/browse/KAFKA-18670 Project: Kafka Issue Type:

Re: [PR] KAFKA-18636 Fix how we handle Gradle exits in CI [kafka]

mumrah merged PR #18681: URL: https://github.com/apache/kafka/pull/18681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[PR] KAFKA-16540: enforce min.insync.replicas config invariants for ELR (#… [kafka]

CalvinConfluent opened a new pull request, #18745: URL: https://github.com/apache/kafka/pull/18745 …17952) If ELR is enabled, we need to set a cluster-level min.insync.replicas, and remove all broker-level overrides. The reason for this is that if brokers disagree about which partiti

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

jsancio commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1934795967 ## raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java: ## @@ -137,6 +99,14 @@ public KafkaRaftMetrics(Metrics metrics, String metricGrpPrefix, Qu

[jira] [Commented] (KAFKA-18669) Connector is restarted before it is started

[ https://issues.apache.org/jira/browse/KAFKA-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922237#comment-17922237 ] Anil Dasari commented on KAFKA-18669: - PR is only a KC change. Let me try to reprodu

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

jsancio commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1934789886 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2351,4 +2459,21 @@ private static ApiVersionsResponseData apiVersionsResponse(Erro

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1934784295 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2351,4 +2459,21 @@ private static ApiVersionsResponseData apiVersionsResponse(E

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

bbejeck commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1931048974 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1934780863 ## raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java: ## @@ -137,6 +99,14 @@ public KafkaRaftMetrics(Metrics metrics, String metricGrpPrefix,

Re: [PR] KAFKA-18649: complete ClearElrRecord handling [kafka]

cmccabe merged PR #18708: URL: https://github.com/apache/kafka/pull/18708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-18669) Connector is restarted before it is started

[ https://issues.apache.org/jira/browse/KAFKA-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922234#comment-17922234 ] Anil Dasari commented on KAFKA-18669: - Thanks [~gharris1727] for quick response. Bot

[jira] [Commented] (KAFKA-18669) Connector is restarted before it is started

[ https://issues.apache.org/jira/browse/KAFKA-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922233#comment-17922233 ] Greg Harris commented on KAFKA-18669: - Hi [~dasarianil] are you able to reproduce th

[jira] [Updated] (KAFKA-18669) Connector is restarted before it is started

[ https://issues.apache.org/jira/browse/KAFKA-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil Dasari updated KAFKA-18669: Description: I am setting up multiple Kafka Connect (KC) clusters on Amazon ECS, each with 2 node

[jira] [Updated] (KAFKA-18669) Connector is restarted before it is started

[ https://issues.apache.org/jira/browse/KAFKA-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil Dasari updated KAFKA-18669: Description: I am setting up multiple Kafka Connect (KC) clusters on Amazon ECS, each with 2 node

[jira] [Created] (KAFKA-18669) Connector is restarted before it is started

Anil Dasari created KAFKA-18669: --- Summary: Connector is restarted before it is started Key: KAFKA-18669 URL: https://issues.apache.org/jira/browse/KAFKA-18669 Project: Kafka Issue Type: Bug

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

m1a2st commented on PR #18548: URL: https://github.com/apache/kafka/pull/18548#issuecomment-2623012788 reslove it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] Refactoring: removed unwanted line breaks [kafka]

shahbazaamir opened a new pull request, #18744: URL: https://github.com/apache/kafka/pull/18744 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

Re: [PR] KAFKA-18171: Revert the strict config validation for 3.8 and 3.9 [kafka]

AndrewJSchofield commented on PR #18741: URL: https://github.com/apache/kafka/pull/18741#issuecomment-2623018045 @mingyen066 I guess you'd like a cherry-pick to 3.8 also? The change in behavior requiring strict validation seems reasonable for 4.0 so we probably ought to mention it in

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1934700897 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2351,4 +2459,21 @@ private static ApiVersionsResponseData apiVersionsResponse(E

Re: [PR] KAFKA-18171: Revert the strict config validation for 3.8 and 3.9 [kafka]

AndrewJSchofield merged PR #18741: URL: https://github.com/apache/kafka/pull/18741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18171: Revert the strict config validation for 3.8 and 3.9 [kafka]

AndrewJSchofield commented on PR #18741: URL: https://github.com/apache/kafka/pull/18741#issuecomment-2622983540 Test failures unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2622947501 Thanks for supporting 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1934700897 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -2351,4 +2459,21 @@ private static ApiVersionsResponseData apiVersionsResponse(E

[jira] [Resolved] (KAFKA-18442) Downgrades to 3.3.2 will fail from versions 3.6.0 and above when JBOD is enabled

[ https://issues.apache.org/jira/browse/KAFKA-18442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-18442. -- Resolution: Won't Fix So firstly, this is a real bug, which we cannot fix since 3.3 is no long

[jira] [Updated] (KAFKA-18442) Downgrades to 3.3.2 will fail from versions 3.6.0 and above when JBOD is enabled

[ https://issues.apache.org/jira/browse/KAFKA-18442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-18442: - Summary: Downgrades to 3.3.2 will fail from versions 3.6.0 and above when JBOD is enabled (was:

Re: [PR] KAFKA-18621: Add StreamsCoordinatorRecordHelpers [kafka]

lucasbru commented on PR #18669: URL: https://github.com/apache/kafka/pull/18669#issuecomment-2622877839 @cadonna Thanks for the comments. I think everything is addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-18621: Add StreamsCoordinatorRecordHelpers [kafka]

lucasbru commented on code in PR #18669: URL: https://github.com/apache/kafka/pull/18669#discussion_r1934659109 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsCoordinatorRecordHelpers.java: ## @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-18655: Implement the consumer group size counter with scheduled task [kafka]

jeffkbkim commented on code in PR #18717: URL: https://github.com/apache/kafka/pull/18717#discussion_r1934491508 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -719,7 +719,7 @@ private void scheduleClassicGroupSizeCounter(

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

lucasbru commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1934566623 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -42,24 +42,24 @@ import static org.apache.kafka.streams.pr

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2622828492 @junrao—the majority of the errors I see in the latest test run are not related. The following test failure occurs on both Java 17 and 23, but the issue has been filed several tim

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

lucasbru commented on PR #18721: URL: https://github.com/apache/kafka/pull/18721#issuecomment-2622819843 Updates look good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

lucasbru commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1934564538 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2097,276 +2102,113 @@ KStream outerJoin(final KStream otherStream, *

Re: [PR] KAFKA-15995: Initial API + make Producer/Consumer plugins Monitorable [kafka]

gharris1727 commented on PR #17511: URL: https://github.com/apache/kafka/pull/17511#issuecomment-2622804718 @mimaison I don't have any more comments, I think i'm ready to approve this. Can you check the build failures? I've rerun it several times and the ClientUtilsTest seems to be consiste

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

mjsax commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1934549683 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -906,13 +910,14 @@ private KStreamImpl repartitionForJoin(final String repart

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

mjsax commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1933226376 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -248,9 +248,9 @@ public KStream map(final KeyValueMapper processorParameters

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

mjsax commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1933226376 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -248,9 +248,9 @@ public KStream map(final KeyValueMapper processorParameters

Re: [PR] [KAFKA-18442] Remove broken upgrade-downgrade-upgrade path. [kafka]

josefk31 commented on PR #18424: URL: https://github.com/apache/kafka/pull/18424#issuecomment-2622787763 closing since https://github.com/apache/kafka/pull/18386 resolves this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [KAFKA-18442] Remove broken upgrade-downgrade-upgrade path. [kafka]

josefk31 closed pull request #18424: [KAFKA-18442] Remove broken upgrade-downgrade-upgrade path. URL: https://github.com/apache/kafka/pull/18424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

kirktrue commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1934523073 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -88,6 +87,7 @@ public class CommitRequestManager implements Reque

Re: [PR] KAFKA-18441: Fix flaky KafkaAdminClientTest#testAdminClientApisAuthenticationFailure [kafka]

AndrewJSchofield commented on code in PR #18735: URL: https://github.com/apache/kafka/pull/18735#discussion_r1934537849 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -1783,12 +1782,14 @@ public void testDescribeTopicsWithDescribeTopicP

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1934537661 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -42,24 +42,24 @@ import static org.apache.kafka.streams.proce

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

bbejeck commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1934500424 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -906,13 +910,14 @@ private KStreamImpl repartitionForJoin(final String repa

[jira] [Resolved] (KAFKA-18668) config/kraft/reconfig-server.properties no longer exists in quickstart

[ https://issues.apache.org/jira/browse/KAFKA-18668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-18668. - Resolution: Implemented [~mimaison] : Thanks for the info. That PR covers this need. Closing this jira.

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

mjsax commented on code in PR #18721: URL: https://github.com/apache/kafka/pull/18721#discussion_r1934494010 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2097,276 +2102,113 @@ KStream outerJoin(final KStream otherStream, *

[jira] [Commented] (KAFKA-18668) config/kraft/reconfig-server.properties no longer exists in quickstart

[ https://issues.apache.org/jira/browse/KAFKA-18668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922194#comment-17922194 ] Mickael Maison commented on KAFKA-18668: In the PR ([https://github.com/apache/k

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

bbejeck commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1934490626 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractStream.java: ## @@ -91,20 +91,20 @@ Set ensureCopartitionWith(final Collection ValueJoiner r

[jira] [Created] (KAFKA-18668) config/kraft/reconfig-server.properties no longer exists in quickstart

Jun Rao created KAFKA-18668: --- Summary: config/kraft/reconfig-server.properties no longer exists in quickstart Key: KAFKA-18668 URL: https://issues.apache.org/jira/browse/KAFKA-18668 Project: Kafka

Re: [PR] KAFKA-18569: New consumer close may wait on unneeded FindCoordinator [kafka]

lianetm commented on PR #18590: URL: https://github.com/apache/kafka/pull/18590#issuecomment-2622650554 Merged to trunk and cherry-picked to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-18644: improve generic type names for KStreamImpl and KTableImpl [kafka]

mjsax commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1934454572 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1103,26 +1108,28 @@ public KStream leftJoin(final GlobalKTable globalTab

Re: [PR] KAFKA-18649: complete ClearElrRecord handling [kafka]

cmccabe commented on code in PR #18708: URL: https://github.com/apache/kafka/pull/18708#discussion_r1934449433 ## metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java: ## @@ -54,6 +55,7 @@ public final class TopicsDelta { */ private final Set deletedTopicIds

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

lianetm commented on PR #18548: URL: https://github.com/apache/kafka/pull/18548#issuecomment-2622620368 @m1a2st could you solve the conflicts please? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-18569: New consumer close may wait on unneeded FindCoordinator [kafka]

lianetm merged PR #18590: URL: https://github.com/apache/kafka/pull/18590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-18498) Kafka Streams main thread does not release lock

[ https://issues.apache.org/jira/browse/KAFKA-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922189#comment-17922189 ] Bill Bejeck commented on KAFKA-18498: - issue resolved and merged to trunk > Kafka S

[jira] [Resolved] (KAFKA-18498) Kafka Streams main thread does not release lock

[ https://issues.apache.org/jira/browse/KAFKA-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-18498. - Resolution: Fixed > Kafka Streams main thread does not release lock > --

Re: [PR] KAFKA-13722: remove internal usage of old ProcessorContext [kafka]

mjsax merged PR #18698: URL: https://github.com/apache/kafka/pull/18698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-18498) Kafka Streams main thread does not release lock

[ https://issues.apache.org/jira/browse/KAFKA-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-18498: Fix Version/s: 4.1.0 > Kafka Streams main thread does not release lock > -

[jira] [Updated] (KAFKA-18498) Kafka Streams main thread does not release lock

[ https://issues.apache.org/jira/browse/KAFKA-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-18498: Affects Version/s: 4.1.0 > Kafka Streams main thread does not release lock > -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2622612299 Thanks for this PR. Really cool to have this migration guide! Merged to `trunk` and cherry-picked to `4.0` branch. Feel free to do a "MINOR" follow-up PR for the Javadocs issue

Re: [PR] KAFKA-18498: Update lock ownership from main thread [kafka]

bbejeck commented on PR #18732: URL: https://github.com/apache/kafka/pull/18732#issuecomment-2622607356 Merged #18732 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

lianetm commented on PR #18548: URL: https://github.com/apache/kafka/pull/18548#issuecomment-2622605776 @kirktrue any other comments on your side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-18498: Update lock ownership from main thread [kafka]

bbejeck merged PR #18732: URL: https://github.com/apache/kafka/pull/18732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

  1   2   3   >