Re: [PR] Add TransactionAbortableException and Timeout Exception handling instruction in docs [kafka]

2025-02-18 Thread via GitHub
k-raina commented on PR #18942: URL: https://github.com/apache/kafka/pull/18942#issuecomment-2667686271 @jolshan Yes, i will raise PR for 4.0 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] KAFKA-18828: Update share group metrics per new init and call mechanism. [kafka]

2025-02-18 Thread via GitHub
smjn opened a new pull request, #18962: URL: https://github.com/apache/kafka/pull/18962 * Due to recent changes in the group count metrics are initialized and updated, the current share group count code has become obsolete as well as non-functional. * The update method for the share-grou

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961026169 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unde

[jira] [Created] (KAFKA-18828) Update share group metrics code in group coordinator

2025-02-18 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-18828: --- Summary: Update share group metrics code in group coordinator Key: KAFKA-18828 URL: https://issues.apache.org/jira/browse/KAFKA-18828 Project: Kafka Is

[jira] [Created] (KAFKA-18827) Initialize share group state impl

2025-02-18 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-18827: --- Summary: Initialize share group state impl Key: KAFKA-18827 URL: https://issues.apache.org/jira/browse/KAFKA-18827 Project: Kafka Issue Type: Sub-task

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961009420 ## docs/zk2kraft.html: ## @@ -15,14 +15,13 @@ limitations under the License. --> - + + - + -Significant Cha

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1960998479 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unders

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960969024 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -111,12 +258,26 @@ private Map> computeTargetPartition

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960968611 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -111,12 +258,26 @@ private Map> computeTargetPartition

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960964532 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -72,36 +77,178 @@ private GroupAssignment assignHomoge

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960965421 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -111,12 +258,26 @@ private Map> computeTargetPartition

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-18 Thread via GitHub
bachmanity1 commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2667501190 @chia7712 can you have a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
frankvicky opened a new pull request, #18961: URL: https://github.com/apache/kafka/pull/18961 Reference: https://github.com/apache/kafka/pull/18365/files#r1960092384 The content of `upgrade.html` has become too large. This patch moves the embedded `zk2kraft` content into a separate page

Re: [PR] Support for base64 encode string keystore [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #17561: URL: https://github.com/apache/kafka/pull/17561#issuecomment-2667432037 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Support for base64 encode string keystore [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] closed pull request #17561: Support for base64 encode string keystore URL: https://github.com/apache/kafka/pull/17561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] MINOR: Update upgrade notes [kafka]

2025-02-18 Thread via GitHub
ijuma opened a new pull request, #18960: URL: https://github.com/apache/kafka/pull/18960 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

Re: [PR] KAFKA-18606: Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18861: URL: https://github.com/apache/kafka/pull/18861#issuecomment-2667405716 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18711: URL: https://github.com/apache/kafka/pull/18711#issuecomment-2667405849 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2667405748 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-2667405822 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18789: URL: https://github.com/apache/kafka/pull/18789#issuecomment-2667405797 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-10844: groupBy without shuffling [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18811: URL: https://github.com/apache/kafka/pull/18811#issuecomment-2667405773 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Update upgrade notes for 4.0.0 [kafka]

2025-02-18 Thread via GitHub
ijuma commented on PR #18960: URL: https://github.com/apache/kafka/pull/18960#issuecomment-2667401699 @chia7712 I didn't change the #include for kraft to zk, but cleaned up the page significantly. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Another default commit message test [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #58: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[PR] Another default commit message test [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #58: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/58 Hopefully this becomes the git body. Reviewers: David Arthur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Touch asf yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #57: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[PR] Touch asf yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #57: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/57 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Feb 18 test 2 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #56: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] PR Title Test 1 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #55: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (3/N) [kafka]

2025-02-18 Thread via GitHub
mjsax merged PR #18883: URL: https://github.com/apache/kafka/pull/18883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: fix Kafka Streams "smoke test" pass criteria [kafka]

2025-02-18 Thread via GitHub
mjsax commented on code in PR #18835: URL: https://github.com/apache/kafka/pull/18835#discussion_r1960802819 ## tests/kafkatest/tests/streams/streams_smoke_test.py: ## @@ -109,5 +109,7 @@ def test_streams(self, processing_guarantee, crash, metadata_quorum): if crash

[PR] Feb 18 test 2 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #56: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/56 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] PR Title Test 1 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #55: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/55 Here is the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-18364 migrating from zk to kraft document [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18365: URL: https://github.com/apache/kafka/pull/18365#discussion_r1960797682 ## docs/upgrade.html: ## @@ -38,6 +38,12 @@ Notable changes in 4 taken when it comes to kafka clients that are not part of Apache Kafka, please see

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-02-18 Thread via GitHub
agavra commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r1960767233 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

Re: [PR] Update asf.yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #54: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (4/N) [kafka]

2025-02-18 Thread via GitHub
mjsax merged PR #18884: URL: https://github.com/apache/kafka/pull/18884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2667217579 @chia7712 I addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (3/N) [kafka]

2025-02-18 Thread via GitHub
mjsax commented on code in PR #18883: URL: https://github.com/apache/kafka/pull/18883#discussion_r1960770603 ## streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java: ## @@ -18,38 +18,46 @@ import org.apache.kafka.common.utils.Bytes; import org.apac

[PR] Minor: Fix error when upgrade ELR [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent opened a new pull request, #18958: URL: https://github.com/apache/kafka/pull/18958 Fix a null ptr problem when upgrading ELR. It does not affect the UTs because the update is actually successful but it confuses the admin client. ``` Could not upgrade eligible.leader.rep

[PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-18 Thread via GitHub
apoorvmittal10 opened a new pull request, #18959: URL: https://github.com/apache/kafka/pull/18959 PR implements the final set of ShareGroupMetrics, RequestTopicPartitionsFetchRatio and TopicPartitionsAcquireTimeMs, as defined in KIP-1103: https://cwiki.apache.org/confluence/display/KAFKA/K

Re: [PR] MINOR: verify that internal StreamsConfig members are not public [kafka]

2025-02-18 Thread via GitHub
mjsax merged PR #18840: URL: https://github.com/apache/kafka/pull/18840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] Update asf.yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #54: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/54 Testing out https://github.com/apache/kafka/pull/18955/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Updated] (KAFKA-18826) Add Global Thread Metrics

2025-02-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18826: Component/s: streams > Add Global Thread Metrics > - > >

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960765911 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion

[jira] [Commented] (KAFKA-4650) Improve test coverage org.apache.kafka.streams.kstream.internals

2025-02-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928224#comment-17928224 ] Matthias J. Sax commented on KAFKA-4650: Thanks Lorcan. I'll take a look (might t

[jira] [Assigned] (KAFKA-4650) Improve test coverage org.apache.kafka.streams.kstream.internals

2025-02-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-4650: -- Assignee: Lorcan > Improve test coverage org.apache.kafka.streams.kstream.internals >

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2025-02-18 Thread via GitHub
m1a2st commented on PR #18891: URL: https://github.com/apache/kafka/pull/18891#issuecomment-2667203885 Thanks for @Parkerhiphop reminder :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-18 Thread via GitHub
frankvicky commented on PR #18844: URL: https://github.com/apache/kafka/pull/18844#issuecomment-2667179189 Run the native container with the latest commit: ![Screenshot from 2025-02-19 07-48-47](https://github.com/user-attachments/assets/03175a9c-c931-409c-b018-2a696a9d382e) -- Thi

[PR] MINOR: Fix Some Exceptions in MetaPropertiesEnsemble and MetadataQuorumCommand [kafka]

2025-02-18 Thread via GitHub
nihyxx opened a new pull request, #18957: URL: https://github.com/apache/kafka/pull/18957 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-18 Thread via GitHub
jsancio commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1960725101 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long, var shallowOffsetOfMaxTimestamp

[PR] MINOR: Add Append KRaft Version Record to BatchAccumulator [kafka]

2025-02-18 Thread via GitHub
nihyxx opened a new pull request, #18956: URL: https://github.com/apache/kafka/pull/18956 ### What This minor PR adds a function to append the KRaft Version Record in BatchAccumulator. This is needed to implement KRaft upgrade (https://issues.apache.org/jira/browse/KAFKA-16538). *

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-18 Thread via GitHub
jsancio commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1960722608 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long, var shallowOffsetOfMaxTimestamp

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960678323 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -48,40 +48,33 @@ public class ImageWriterOptionsTest { @Test public

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960688656 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -718,30 +710,14 @@ public void testRegistrationWithUnsupportedMetadataVersion

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #18391: URL: https://github.com/apache/kafka/pull/18391#issuecomment-2667111606 @manoj-mathivanan could you please merge trunk to run CI again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960706340 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -718,30 +710,14 @@ public void testRegistrationWithUnsupportedMetadataVersion

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-02-18 Thread via GitHub
ableegoldman commented on PR #18610: URL: https://github.com/apache/kafka/pull/18610#issuecomment-2667093088 Yep! Will take a look in the next day or so 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960696997 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -718,30 +710,14 @@ public void testRegistrationWithUnsupportedMetadataVers

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #18737: URL: https://github.com/apache/kafka/pull/18737#issuecomment-2667067831 @frankvicky could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
TaiJuWu commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1960679875 ## gradle/dependencies.gradle: ## @@ -54,10 +54,7 @@ versions += [ apacheds: "2.0.0-M24", argparse4j: "0.7.0", bcpkix: "1.78.1", - // Version >=3.1.2 includes

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960679302 ## metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java: ## @@ -29,30 +29,22 @@ public final class ImageWriterOptions { public static class

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960678323 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -48,40 +48,33 @@ public class ImageWriterOptionsTest { @Test public

[jira] [Resolved] (KAFKA-18799) Remove AdminUtils

2025-02-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18799. Fix Version/s: 4.1.0 Resolution: Fixed > Remove AdminUtils > - > >

Re: [PR] KAFKA-18799: Remove `AdminUtils` [kafka]

2025-02-18 Thread via GitHub
chia7712 merged PR #18946: URL: https://github.com/apache/kafka/pull/18946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-2667048506 > Is Kafka-site what im building or the main Kafka site. The changes you've made are difficult to review without seeing the rendered output. Our usual process is to build the site

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960653141 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -48,40 +48,33 @@ public class ImageWriterOptionsTest { @Test publ

Re: [PR] KAFKA-17367: Share coordinator impl. Broker side code. [2/N] [kafka]

2025-02-18 Thread via GitHub
apoorvmittal10 commented on code in PR #17011: URL: https://github.com/apache/kafka/pull/17011#discussion_r1960653197 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -150,6 +159,37 @@ public GroupCoordinatorMetric

Re: [PR] KAFKA-17411: Use shared cache for Task offset sums [kafka]

2025-02-18 Thread via GitHub
ableegoldman commented on PR #17715: URL: https://github.com/apache/kafka/pull/17715#issuecomment-2666999564 SG! Ping me again when it's ready 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-17411: Use shared cache for Task offset sums [kafka]

2025-02-18 Thread via GitHub
nicktelford commented on PR #17715: URL: https://github.com/apache/kafka/pull/17715#issuecomment-2666991999 @ableegoldman Yeah, that's not a surprise. I should be able to get to it next week, or maybe the week after. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-02-18 Thread via GitHub
ukpagrace commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-2666961015 Hey @chia7712 I have a question on the pr, you mentioned using the Kafka-site to build the trunk branch. Is Kafka-site what im building or the main Kafka site. -- This is

Re: [PR] KAFKA-17411: Use shared cache for Task offset sums [kafka]

2025-02-18 Thread via GitHub
ableegoldman commented on PR #17715: URL: https://github.com/apache/kafka/pull/17715#issuecomment-2666976336 hey @nicktelford sorry this PR was neglected for so long, is it still ready for review? might need to be rebased first? -- This is an automated message from the Apache Git Service.

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (3/N) [kafka]

2025-02-18 Thread via GitHub
bbejeck commented on code in PR #18883: URL: https://github.com/apache/kafka/pull/18883#discussion_r1960564551 ## streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java: ## @@ -18,38 +18,46 @@ import org.apache.kafka.common.utils.Bytes; import org.ap

[jira] [Resolved] (KAFKA-18684) Implement new base exception classes

2025-02-18 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-18684. --- Resolution: Done > Implement new base exception classes > --

[PR] KAFKA-18791 Use PR title and description as default commit [kafka]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #18955: URL: https://github.com/apache/kafka/pull/18955 This patch utilizes the new .asf.yaml parser (INFRA-26529) to allow us to set the default commit message for PRs. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
dajac commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960533479 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion implement

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
cmccabe commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960530407 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2666840092 I resolved the outstanding item, so no known issues remain in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
cmccabe commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960529339 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-02-18 Thread via GitHub
bbejeck commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r1960453578 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -259,10 +317,10 @@ public void shouldP

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
cmccabe commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960529339 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960528979 ## metadata/src/main/java/org/apache/kafka/image/FeaturesDelta.java: ## @@ -58,7 +59,14 @@ public void finishSnapshot() { public void replay(FeatureLevelRecord rec

Re: [PR] KAFKA-17125 Add integration test for StreamsGroup in Admin API [kafka]

2025-02-18 Thread via GitHub
aliehsaeedii commented on code in PR #18911: URL: https://github.com/apache/kafka/pull/18911#discussion_r1960526067 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -270,7 +285,7 @@ private void printOffsets(StreamsGroupDescription descripti

Re: [PR] Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960401444 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -130,7 +130,7 @@ public enum MetadataVersion { // Please move thi

Re: [PR] MINOR: Tweak default group coordinator config & upgrade notes [kafka]

2025-02-18 Thread via GitHub
dajac merged PR #18948: URL: https://github.com/apache/kafka/pull/18948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960333100 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -130,7 +130,7 @@ public enum MetadataVersion { // Please move this comment

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1960316872 ## gradle/dependencies.gradle: ## @@ -54,10 +54,7 @@ versions += [ apacheds: "2.0.0-M24", argparse4j: "0.7.0", bcpkix: "1.78.1", - // Version >=3.1.2 include

[PR] Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent opened a new pull request, #18954: URL: https://github.com/apache/kafka/pull/18954 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] KAFKA-17367: Share coordinator impl. Broker side code. [2/N] [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #17011: URL: https://github.com/apache/kafka/pull/17011#discussion_r1960309578 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -150,6 +159,37 @@ public GroupCoordinatorMetrics(Metr

[jira] [Assigned] (KAFKA-18824) Update docs of docker hub to add dynamic voters description

2025-02-18 Thread Alex Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Tran reassigned KAFKA-18824: - Assignee: Alex Tran > Update docs of docker hub to add dynamic voters description > ---

[PR] KAFKA-18826: Add global thread metrics [kafka]

2025-02-18 Thread via GitHub
bbejeck opened a new pull request, #18953: URL: https://github.com/apache/kafka/pull/18953 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Created] (KAFKA-18826) Add Global Thread Metrics

2025-02-18 Thread Bill Bejeck (Jira)
Bill Bejeck created KAFKA-18826: --- Summary: Add Global Thread Metrics Key: KAFKA-18826 URL: https://issues.apache.org/jira/browse/KAFKA-18826 Project: Kafka Issue Type: Task Affects Versions

[PR] Minor: update truncation test [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent opened a new pull request, #18952: URL: https://github.com/apache/kafka/pull/18952 Adjust the behavior accordingly for the KIP-966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2666525097 @junrao @chia7712 The tests for JDK 23 were all passing for the last run (the JDK 17 build failed, but it didn't look related to this PR). I think there's only one outstanding issue:

[jira] [Assigned] (KAFKA-14484) Move UnifiedLog to storage module

2025-02-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14484: -- Assignee: Mickael Maison (was: Satish Duggana) > Move UnifiedLog to storage module >

Re: [PR] KAFKA-18667: Add ducktape tests for simultaneous broker + controller failure [kafka]

2025-02-18 Thread via GitHub
mumrah merged PR #18757: URL: https://github.com/apache/kafka/pull/18757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
kamalcph commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1960245594 ## gradle/dependencies.gradle: ## @@ -54,10 +54,7 @@ versions += [ apacheds: "2.0.0-M24", argparse4j: "0.7.0", bcpkix: "1.78.1", - // Version >=3.1.2 include

Re: [PR] KAFKA-18198: Added check to prevent acknowledgements on initial ShareFetchRequest. [kafka]

2025-02-18 Thread via GitHub
ShivsundarR commented on code in PR #18944: URL: https://github.com/apache/kafka/pull/18944#discussion_r1960241628 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -177,8 +177,14 @@ public PollResult poll(long currentTim

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2665984323 @fonsdant I apologize, and while we typically prioritize the oldest PR, we are currently preparing for the 4.0.0 release, which may make us a little impolite :( If you have other

[jira] [Comment Edited] (KAFKA-18033) ShareConsumerTest is flaky

2025-02-18 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928176#comment-17928176 ] Shivsundar R edited comment on KAFKA-18033 at 2/18/25 5:42 PM: ---

  1   2   3   >