Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-03 Thread via GitHub
m1a2st commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2028167373 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java: ## @@ -38,12 +34,6 @@ import java.util.function.Consumer; import java.

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-03 Thread via GitHub
m1a2st commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2028124270 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -80,8 +80,9 @@ public class TopicConfig { "Moreover, it triggers the rolling of

Re: [PR] KAFKA-18713: Fix FK Left-Join result race condition [kafka]

2025-04-03 Thread via GitHub
nilmadhab commented on PR #19005: URL: https://github.com/apache/kafka/pull/19005#issuecomment-2777592878 > Thanks for this fix! Merged to `trunk`, and cherry-picked to `4.0` and `3.9` branches. You are welcome ! -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-03 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026362292 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-03 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2028100666 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] MINOR: Improve Javadoc for OffsetCommitCallback-consuming commitAsync… [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #12364: URL: https://github.com/apache/kafka/pull/12364#issuecomment-2777485328 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-15992 Make MM2 heartbeats topic name configurable [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #15200: URL: https://github.com/apache/kafka/pull/15200#issuecomment-2777485424 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] Kafka 8850: Updated documentation to clarify fetch.min.bytes behaviour. [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #16749: URL: https://github.com/apache/kafka/pull/16749#issuecomment-2777485472 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Created] (KAFKA-19083) Fix flaky MetricsDuringTopicCreationDeletionTest. testMetricsDuringTopicCreateDelete(String).quorum=kraft

2025-04-03 Thread Jira
黃竣陽 created KAFKA-19083: --- Summary: Fix flaky MetricsDuringTopicCreationDeletionTest. testMetricsDuringTopicCreateDelete(String).quorum=kraft Key: KAFKA-19083 URL: https://issues.apache.org/jira/browse/KAFKA-19083

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-03 Thread via GitHub
m1a2st commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2028015016 ## server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-19042: [4/N] Move PlaintextConsumerCallbackTest to client-integration-tests module [kafka]

2025-04-03 Thread via GitHub
m1a2st commented on PR #19298: URL: https://github.com/apache/kafka/pull/19298#issuecomment-2777470056 Hello @lianetm, Thanks for review. I agree that addtional `callbacks` folder is confusing, thus I move this test into `consumer` folder. -- This is an automated message from the A

Re: [PR] KAFKA-18390: Use LinkedHashMap instead of Map in creating MetricName and SensorBuilder (1/N) [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #19300: URL: https://github.com/apache/kafka/pull/19300#issuecomment-2777464581 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KIP1151 / KAFKA-19048: Minimal Movement Replica Balancing algorithm [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #19297: URL: https://github.com/apache/kafka/pull/19297#issuecomment-2777464600 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18960: The default type of ssh key used by vagrant is disabled … [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #19264: URL: https://github.com/apache/kafka/pull/19264#issuecomment-2777464625 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] WIP: Please ignore [kafka]

2025-04-03 Thread via GitHub
srdo closed pull request #19311: WIP: Please ignore URL: https://github.com/apache/kafka/pull/19311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira

[PR] KAFKA-18629: Utilize share group partition metadata for delete group. [kafka]

2025-04-03 Thread via GitHub
smjn opened a new pull request, #19363: URL: https://github.com/apache/kafka/pull/19363 * Currently, the delete share group code flow uses `group.subscribedTopicNames()` to fetch information about all the share partitions to which a share group is subscribed to. * However, this is incorr

[PR] [WIP]: Backport java 24 all2 [kafka]

2025-04-03 Thread via GitHub
showuon opened a new pull request, #19368: URL: https://github.com/apache/kafka/pull/19368 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-03 Thread via GitHub
mjsax commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2027993145 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -15776,6 +15779,76 @@ public void testStreamsGroupMemberEpochVa

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-03 Thread via GitHub
mjsax commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2028004070 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -16233,6 +16233,97 @@ public void testStreamsGroupMemberJoinin

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-03 Thread via GitHub
Rancho-7 commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2027985854 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -64,19 +70,26 @@ import static org.junit.jupiter.api.Assertions.asse

Re: [PR] MINOR: Remove DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest flaky annotation [kafka]

2025-04-03 Thread via GitHub
m1a2st commented on PR #19301: URL: https://github.com/apache/kafka/pull/19301#issuecomment-2777381537 Update the gradlew report: https://develocity.apache.org/scans/tests?search.rootProjectNames=kafka&search.startTimeMax=1743732586490&search.startTimeMin=174162240&search.tags=github,tru

Re: [PR] KAFKA-14768_KIP913: add new method to provide possibility for warming up first record's sending and reducing the max.block.ms safely. [kafka]

2025-04-03 Thread via GitHub
jiafu1115 commented on PR #13320: URL: https://github.com/apache/kafka/pull/13320#issuecomment-2777307525 ask for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` [kafka]

2025-04-03 Thread via GitHub
AndrewJSchofield commented on PR #19313: URL: https://github.com/apache/kafka/pull/19313#issuecomment-2774633881 > @AndrewJSchofield Thanks for your reply. Currently, Kafka does not seem to have global configuration limits (e.g., quota and `max.connections.per.ip` are broker-level configura

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-03 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2027851052 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -441,7 +441,6 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() { @Tes

Re: [PR] KAFKA-18713: Fix FK Left-Join result race condition [kafka]

2025-04-03 Thread via GitHub
mjsax commented on PR #19005: URL: https://github.com/apache/kafka/pull/19005#issuecomment-2777264524 Thanks for this fix! Merged to `trunk`, and cherry-picked to `4.0` and `3.9` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Assigned] (KAFKA-18042) Reject the produce request with lower producer epoch early.

2025-04-03 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18042: --- Assignee: TaiJuWu > Reject the produce request with lower producer epoch early. > -

Re: [PR] KAFKA-18713: Fix FK Left-Join result race condition [kafka]

2025-04-03 Thread via GitHub
mjsax merged PR #19005: URL: https://github.com/apache/kafka/pull/19005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-03 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2027851052 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -441,7 +441,6 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() { @Tes

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-04-03 Thread via GitHub
mjsax commented on PR #19188: URL: https://github.com/apache/kafka/pull/19188#issuecomment-2777165125 @fhussonnois -- Would be nice to get this into 3.9.1 bug-fix release. Code-freeze is April/9th. Can we get this done on time? -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-03 Thread via GitHub
TaiJuWu commented on PR #19286: URL: https://github.com/apache/kafka/pull/19286#issuecomment-2777162856 > https://github.com/apache/kafka/pull/19050/files#diff-6ecc777f37395e25591a118f0eef88d602c765a66adace6247f98cf4ea159bc9 I will add test after that PR get merged. -- This is an a

[jira] [Updated] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-04-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18713: Affects Version/s: 3.7.0 (was: 3.8.0) > Kafka Streams Left-Join

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-03 Thread via GitHub
Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2027508894 ## clients/src/main/java/org/apache/kafka/clients/consumer/OffsetCommitCallback.java: ## @@ -26,6 +26,7 @@ * A callback interface that the user can implement to trigg

Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]

2025-04-03 Thread via GitHub
ijuma commented on code in PR #19320: URL: https://github.com/apache/kafka/pull/19320#discussion_r2027719011 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -107,8 +107,6 @@ public class TopicConfig { public static final String MAX_MESSAGE_BY

Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]

2025-04-03 Thread via GitHub
chia7712 commented on PR #19320: URL: https://github.com/apache/kafka/pull/19320#issuecomment-2776952680 @ijuma thanks for all your reviews. we will file a minor patch tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-04-03 Thread via GitHub
ableegoldman commented on PR #19269: URL: https://github.com/apache/kafka/pull/19269#issuecomment-2776938325 Merged to trunk and cherry-picked to 4.0 thanks for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-04-03 Thread via GitHub
ableegoldman merged PR #19269: URL: https://github.com/apache/kafka/pull/19269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]

2025-04-03 Thread via GitHub
ijuma commented on code in PR #19320: URL: https://github.com/apache/kafka/pull/19320#discussion_r2027717639 ## clients/src/main/java/org/apache/kafka/common/ClusterResourceListener.java: ## @@ -24,7 +24,7 @@ * * Clients * There will be one invocation of {@link ClusterRe

[jira] [Commented] (KAFKA-19080) The constraint on segment.ms is not enforced at topic level

2025-04-03 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940821#comment-17940821 ] Jun Rao commented on KAFKA-19080: - [~iamoshione] : I mean that if a request tries to cha

Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]

2025-04-03 Thread via GitHub
chia7712 merged PR #19320: URL: https://github.com/apache/kafka/pull/19320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-03 Thread via GitHub
AndrewJSchofield commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2027666958 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListShareGroupOffsetsHandler.java: ## @@ -84,19 +84,23 @@ public DescribeShareGroupOffsetsReq

[jira] [Resolved] (KAFKA-18953) Add broker side handling for 2PC without keepPrepared

2025-04-03 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy resolved KAFKA-18953. -- Resolution: Fixed > Add broker side handling for 2PC without keepPrepared > --

[jira] [Commented] (KAFKA-19080) The constraint on segment.ms is not enforced at topic level

2025-04-03 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940810#comment-17940810 ] oshione gabriel esiemokhai commented on KAFKA-19080: what do you mea

Re: [PR] KAFKA-14523: Move DelayedRemoteListOffsets to the storage module [kafka]

2025-04-03 Thread via GitHub
mimaison commented on PR #19285: URL: https://github.com/apache/kafka/pull/19285#issuecomment-2776753269 Sure, done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] KAFKA-18629: Utilize share group partition metadata for delete group. [kafka]

2025-04-03 Thread via GitHub
smjn commented on PR #19363: URL: https://github.com/apache/kafka/pull/19363#issuecomment-2776736045 ### Internal topic o/p on after issuing delete call * __consumer_offsets ``` {"key":{"type":15,"data":{"groupId":"gs1"}},"value":{"version":0,"data":{"initializingTopics":[{"topicId"

Re: [PR] Minor: Add functionalinterface to the producer callback [kafka]

2025-04-03 Thread via GitHub
chia7712 commented on code in PR #19366: URL: https://github.com/apache/kafka/pull/19366#discussion_r2027583667 ## clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java: ## @@ -34,6 +34,7 @@ * The callback may be executed in any thread call

[jira] [Updated] (KAFKA-19082) Client side changes to enable 2PC

2025-04-03 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19082: - Description: h2. KafkaProducer API Changes New {{KafkaProducer.PreparedTxnState}} class is goin

[jira] [Updated] (KAFKA-19082) Client side changes to enable 2PC

2025-04-03 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19082: - Description: h2. Client Configuration Changes *transaction.two.phase.commit.enable* The default

[PR] Minor: Add functionalinterface to the producer callback [kafka]

2025-04-03 Thread via GitHub
Tombert opened a new pull request, #19366: URL: https://github.com/apache/kafka/pull/19366 The Callback interface is a perfect example of a place that can use the functionalinterface in Java. Strictly for Java, this isn't "required" since Java will automatically coerce, but for Clojure (an

[jira] [Updated] (KAFKA-18953) Add broker side handling for 2PC without keepPrepared

2025-04-03 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-18953: - Summary: Add broker side handling for 2PC without keepPrepared (was: Add broker side handling f

Re: [PR] Minor: Add functionalinterface to the producer callback [kafka]

2025-04-03 Thread via GitHub
chia7712 commented on code in PR #19366: URL: https://github.com/apache/kafka/pull/19366#discussion_r2027536151 ## clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java: ## @@ -34,6 +34,7 @@ * The callback may be executed in any thread call

[PR] MINOR: Backport Gradle upgrades to 3.9 [kafka]

2025-04-03 Thread via GitHub
srdo opened a new pull request, #19365: URL: https://github.com/apache/kafka/pull/19365 This is needed for building on Java 23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-03 Thread via GitHub
azhar2407 commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2027531080 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -441,7 +441,29 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {

Re: [PR] KAFKA-14523: Move DelayedRemoteListOffsets to the storage module [kafka]

2025-04-03 Thread via GitHub
chia7712 commented on PR #19285: URL: https://github.com/apache/kafka/pull/19285#issuecomment-2776565992 @mimaison could you please resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-03 Thread via GitHub
Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2027517614 ## clients/src/main/java/org/apache/kafka/clients/consumer/OffsetCommitCallback.java: ## @@ -26,6 +26,7 @@ * A callback interface that the user can implement to trigg

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-03 Thread via GitHub
chia7712 commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2027509827 ## clients/src/main/java/org/apache/kafka/clients/consumer/OffsetCommitCallback.java: ## @@ -26,6 +26,7 @@ * A callback interface that the user can implement to trig

Re: [PR] MINOR: Deduplicate topics of a topology for authorization check [kafka]

2025-04-03 Thread via GitHub
cadonna merged PR #19352: URL: https://github.com/apache/kafka/pull/19352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-03 Thread via GitHub
mjsax merged PR #19234: URL: https://github.com/apache/kafka/pull/19234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-19078) Implement automatic controller addition to cluster metadata partition

2025-04-03 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940759#comment-17940759 ] Kevin Wu commented on KAFKA-19078: -- Can only send the RemoveVoterRPC and/or AddVoterRPC

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-03 Thread via GitHub
m1a2st commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2027327151 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -766,7 +766,7 @@ class BrokerServer( CoreUtils.swallow(dataPlaneRequestHandlerPool.shutdown(), thi

[jira] [Commented] (KAFKA-19080) The constraint on segment.ms is not enforced at topic level

2025-04-03 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940756#comment-17940756 ] Jun Rao commented on KAFKA-19080: - [~m1a2st] : Yes, feel free to take it. Thanks. > The

Re: [PR] KAFKA-18816: Add KIP-877 support to KafkaPrincipalBuilder [kafka]

2025-04-03 Thread via GitHub
mimaison commented on PR #18935: URL: https://github.com/apache/kafka/pull/18935#issuecomment-2776351491 I looked into this further and I'm wondering if it makes sense to add KIP-877 support to this plugin. `KafkaPrincipalBuilder` instances are created for each `KafkaChannel`. In pra

[PR] MINOR VerifableProducer ducktape can set idempotency and retries [kafka]

2025-04-03 Thread via GitHub
josefk31 opened a new pull request, #19362: URL: https://github.com/apache/kafka/pull/19362 It is currently impossible to set both number of retries and idempotency in the DucktapeVerifiable producer. This change allows that to occur. I'm adding this because I'd like to set these vari

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-03 Thread via GitHub
m1a2st commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2027280728 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java: ## @@ -69,10 +70,42 @@ public void testCustomQuotaCallback

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-04-03 Thread via GitHub
TaiJuWu commented on PR #19277: URL: https://github.com/apache/kafka/pull/19277#issuecomment-2775730036 https://github.com/user-attachments/assets/7e319bde-9b42-4473-b82e-adfbe96317cb"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-03 Thread via GitHub
mimaison commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2027146996 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java: ## @@ -69,10 +70,42 @@ public void testCustomQuotaCallba

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-03 Thread via GitHub
mumrah commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2027246605 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListShareGroupOffsetsHandler.java: ## @@ -84,19 +84,23 @@ public DescribeShareGroupOffsetsRequest.Build

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-03 Thread via GitHub
TaiJuWu commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2027209374 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2654,7 +2655,7 @@ class ReplicaManager(val config: KafkaConfig, config.replicaSelectorClassName.ma

Re: [PR] KAFKA-19015: Remove share session from cache on share consumer connection drop [kafka]

2025-04-03 Thread via GitHub
chirag-wadhwa5 commented on PR #19329: URL: https://github.com/apache/kafka/pull/19329#issuecomment-2776080305 Thanks for the review. I have addressed all the comments in the latest commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

2025-04-03 Thread via GitHub
aliehsaeedii opened a new pull request, #17981: URL: https://github.com/apache/kafka/pull/17981 This PR and the future following ones aim to refactor the big `GroupMetadataManager` class and split it into multiple classes. This PR specifically introduces the `GroupStore` class, which contai

[PR] MINOR: rename metric variable name in Processor#accept [kafka]

2025-04-03 Thread via GitHub
gaurav-narula opened a new pull request, #19361: URL: https://github.com/apache/kafka/pull/19361 `Processor#accept` accepts a metric which tracks the amount of time for which the Acceptor thread was blocked. It's misleading to name it `acceptorIdlePercentMeter` and this change updates its n

[jira] [Commented] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-04-03 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940710#comment-17940710 ] Lorcan commented on KAFKA-19022: I am not sure about the KIP process as I'm quite new to

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-04-03 Thread via GitHub
chia7712 merged PR #19277: URL: https://github.com/apache/kafka/pull/19277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-03 Thread via GitHub
mimaison commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2027138995 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2654,7 +2655,7 @@ class ReplicaManager(val config: KafkaConfig, config.replicaSelectorClassName.m

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-03 Thread via GitHub
mimaison commented on PR #19050: URL: https://github.com/apache/kafka/pull/19050#issuecomment-2775985730 @Yunyung Sorry the PR was not fully complete. I updated the javadoc and added an integration test. It should be ready to review now. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-18893: Add KIP-877 support to ReplicaSelector [kafka]

2025-04-03 Thread via GitHub
mimaison commented on code in PR #19064: URL: https://github.com/apache/kafka/pull/19064#discussion_r2027131524 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2587,11 +2587,11 @@ class ReplicaManager(val config: KafkaConfig, new ReplicaAlterLogDirsManager(

[PR] KAFKA-19074: Remove the cached responseData from ShareFetchResponse [kafka]

2025-04-03 Thread via GitHub
TaiJuWu opened a new pull request, #19357: URL: https://github.com/apache/kafka/pull/19357 Jira: https://issues.apache.org/jira/browse/KAFKA-19074 Similar fix https://github.com/apache/kafka/pull/16532 https://github.com/apache/kafka/commit/2b8aff58b575c199ee8372e5689420c9d7735

[PR] MINOR: Added trace logs to hep debug SharePartition [kafka]

2025-04-03 Thread via GitHub
adixitconfluent opened a new pull request, #19358: URL: https://github.com/apache/kafka/pull/19358 ### What Added `trace` logs to help debug `nextFetchOffset` functionality within SharePartition. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-03 Thread via GitHub
lucasbru opened a new pull request, #19359: URL: https://github.com/apache/kafka/pull/19359 When a member indicates that the application should shut down, add all member IDs to a set inside the streams group and continouously set the status `SHUTDOWN_APPLICATION` for those members, until ea

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-03 Thread via GitHub
AndrewJSchofield commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026988588 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,241 @@ private long startOffsetDuringInitialization(long partitionDataStartO

[jira] [Resolved] (KAFKA-19075) Include all share group dynamic configs in extractShareGroupConfigMap method in ShareGroupConfig

2025-04-03 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19075. -- Fix Version/s: 4.1.0 Resolution: Fixed > Include all share group dynamic config

Re: [PR] KAFKA-19075: Included other share group dynamic configs in extractShareGroupConfigMap method in ShareGroupConfig [kafka]

2025-04-03 Thread via GitHub
AndrewJSchofield merged PR #19348: URL: https://github.com/apache/kafka/pull/19348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-19064) More exception handling for group coordinator events

2025-04-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-19064. - Fix Version/s: 4.1.0 Resolution: Fixed > More exception handling for group coordinator ev

Re: [PR] KAFKA-19064: Handle exceptions from deferred events in coordinator [kafka]

2025-04-03 Thread via GitHub
dajac merged PR #19333: URL: https://github.com/apache/kafka/pull/19333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-03 Thread via GitHub
chia7712 commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2026260113 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -87,7 +87,7 @@ public FetchResponseData data() { * We may also return INCONSI

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-03 Thread via GitHub
Yunyung commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2026783253 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -3741,6 +3735,34 @@ long findLogStartOffset(TopicIdPartition topicIdPartition, UnifiedLog log)

Re: [PR] [MINOR] Cleanup Storage Module [kafka]

2025-04-03 Thread via GitHub
sjhajharia commented on PR #19072: URL: https://github.com/apache/kafka/pull/19072#issuecomment-2775437567 Gentle reminder @chia7712 @m1a2st -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-03 Thread via GitHub
FrankYang0529 commented on code in PR #19319: URL: https://github.com/apache/kafka/pull/19319#discussion_r2026739834 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerCompressionTest.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Ap

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-03 Thread via GitHub
AndrewJSchofield commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r202677 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1212,7 +1223,8 @@ public void testAcquireWithMultipleBatchesAndMaxFetchRecords() thro

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-04-03 Thread via GitHub
cadonna commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2026582455 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java: ## @@ -407,30 +406,6 @@ public long position(final TopicPartition p

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-04-03 Thread via GitHub
cadonna commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2026582455 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java: ## @@ -407,30 +406,6 @@ public long position(final TopicPartition p

Re: [PR] KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` [kafka]

2025-04-03 Thread via GitHub
DL1231 commented on PR #19313: URL: https://github.com/apache/kafka/pull/19313#issuecomment-2774121074 @AndrewJSchofield Thanks for your reply. Currently, Kafka does not seem to have global configuration limits (e.g., quota and `max.connections.per.ip` are broker-level configurations). Perh

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-03 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026469750 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-14725: Interrupt source task poll thread when cancelled [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] commented on PR #14316: URL: https://github.com/apache/kafka/pull/14316#issuecomment-2774400112 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

2025-04-03 Thread via GitHub
github-actions[bot] closed pull request #17981: KAFKA-1826 [1/N]: Introducing GroupStore URL: https://github.com/apache/kafka/pull/17981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-03 Thread via GitHub
ijuma commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2026247449 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -87,7 +87,7 @@ public FetchResponseData data() { * We may also return INCONSISTE

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-03 Thread via GitHub
showuon commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2026362881 ## docs/ops.html: ## @@ -4026,13 +4026,14 @@ Broker Configurations -By default, Kafka server will not enable tiered storage feature. remote.log.storage.system.enabl

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-03 Thread via GitHub
showuon commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2026362881 ## docs/ops.html: ## @@ -4026,13 +4026,14 @@ Broker Configurations -By default, Kafka server will not enable tiered storage feature. remote.log.storage.system.enabl

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-03 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026360050 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

[jira] [Resolved] (KAFKA-18923) resource leak in RSM fetchIndex inputStream

2025-04-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-18923. --- Resolution: Fixed > resource leak in RSM fetchIndex inputStream > --

Re: [PR] KAFKA-18923: resource leak in RSM inputStream [kafka]

2025-04-03 Thread via GitHub
showuon merged PR #19111: URL: https://github.com/apache/kafka/pull/19111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

  1   2   >