Re: [PR] KAFKA-18855: Slice API for MemoryRecords [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield commented on code in PR #19581: URL: https://github.com/apache/kafka/pull/19581#discussion_r2069906803 ## clients/src/main/java/org/apache/kafka/common/record/Records.java: ## @@ -90,4 +91,18 @@ public interface Records extends TransferableRecords { * @ret

[jira] [Updated] (KAFKA-19225) Tiered Storage Support for Active Log Segment

2025-04-30 Thread Henry Cai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Cai updated KAFKA-19225: -- Description: This is the Jira for [KIP-1176|https://cwiki.apache.org/confluence/display/KAFKA/KIP-117

[jira] [Created] (KAFKA-19225) Tiered Storage Support for Active Log Segment

2025-04-30 Thread Henry Cai (Jira)
Henry Cai created KAFKA-19225: - Summary: Tiered Storage Support for Active Log Segment Key: KAFKA-19225 URL: https://issues.apache.org/jira/browse/KAFKA-19225 Project: Kafka Issue Type: New Featu

Re: [PR] [ KAFKA-17049 ] fix Incremental rebalances assign too many tasks for the same connector together [kafka]

2025-04-30 Thread via GitHub
github-actions[bot] commented on PR #16486: URL: https://github.com/apache/kafka/pull/16486#issuecomment-2844014363 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] feat(clients): MemberToRemove accepting memberId field on constructor… [kafka]

2025-04-30 Thread via GitHub
github-actions[bot] commented on PR #18738: URL: https://github.com/apache/kafka/pull/18738#issuecomment-2844014465 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18638 fix flasky testThrottledProducerConsumer.testThrottledProducerConsumer [kafka]

2025-04-30 Thread via GitHub
github-actions[bot] commented on PR #18689: URL: https://github.com/apache/kafka/pull/18689#issuecomment-2844014445 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-04-30 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2843999627 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-04-30 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2843999607 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18066: Fix mismatched StreamThread ID in log messages [kafka]

2025-04-30 Thread via GitHub
github-actions[bot] commented on PR #19517: URL: https://github.com/apache/kafka/pull/19517#issuecomment-2843999498 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-18574) Quarantined test list should be sorted

2025-04-30 Thread Harsh Kuddu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948616#comment-17948616 ] Harsh Kuddu commented on KAFKA-18574: - Hi [~kirktrue], I have noticed this issue hav

Re: [PR] MINOR: fix bug in TimeWindowedDeserializerTest [kafka]

2025-04-30 Thread via GitHub
mjsax merged PR #19570: URL: https://github.com/apache/kafka/pull/19570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-04-30 Thread via GitHub
kirktrue opened a new pull request, #19609: URL: https://github.com/apache/kafka/pull/19609 Change: `public List>> entries();` to: `public List entries();` and clean up the callers. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] KAFKA-18855: Slice API for MemoryRecords [kafka]

2025-04-30 Thread via GitHub
junrao commented on code in PR #19581: URL: https://github.com/apache/kafka/pull/19581#discussion_r2069620518 ## clients/src/main/java/org/apache/kafka/common/record/Records.java: ## @@ -90,4 +91,18 @@ public interface Records extends TransferableRecords { * @return The re

Re: [PR] KAFKA-19176: Update Transactional producer to translate retriable into abortable exceptions [kafka]

2025-04-30 Thread via GitHub
k-raina commented on code in PR #19522: URL: https://github.com/apache/kafka/pull/19522#discussion_r2069651376 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1073,6 +1074,11 @@ private void transitionTo(State target, RuntimeE

Re: [PR] KAFKA-19176: Update Transactional producer to translate retriable into abortable exceptions [kafka]

2025-04-30 Thread via GitHub
k-raina commented on code in PR #19522: URL: https://github.com/apache/kafka/pull/19522#discussion_r2069651376 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1073,6 +1074,11 @@ private void transitionTo(State target, RuntimeE

Re: [PR] KAFKA-19212: Correct the unclean leader election metric calculation [kafka]

2025-04-30 Thread via GitHub
CalvinConfluent commented on code in PR #19590: URL: https://github.com/apache/kafka/pull/19590#discussion_r2069651007 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetricsChanges.java: ## @@ -105,10 +114,25 @@ void handleTopicChange(TopicImage prev, To

Re: [PR] KAFKA-19212: Correct the unclean leader election metric calculation [kafka]

2025-04-30 Thread via GitHub
cmccabe commented on code in PR #19590: URL: https://github.com/apache/kafka/pull/19590#discussion_r2069562903 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetricsChanges.java: ## @@ -105,10 +114,25 @@ void handleTopicChange(TopicImage prev, TopicDelta

Re: [PR] WIP: Test against Java 24 [kafka]

2025-04-30 Thread via GitHub
srdo commented on PR #19514: URL: https://github.com/apache/kafka/pull/19514#issuecomment-2843288842 Status: This passes tests locally. As Gradle 8.14 has released, the only remaining roadblock is that the currently-newest version of Spotbugs crashes the build. The underlying bug is fixed i

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069409569 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java: ## @@ -477,6 +480,27 @@ private static void compileJavaSources(Path sou

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069409569 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java: ## @@ -477,6 +480,27 @@ private static void compileJavaSources(Path sou

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069403840 ## connect/runtime/src/test/resources/test-plugins/versioned-predicate/test/plugins/VersionedPredicate.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069399422 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/VersionedPluginBuilder.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-19015: Remove share session from cache on share consumer connection drop [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield commented on code in PR #19329: URL: https://github.com/apache/kafka/pull/19329#discussion_r2069394303 ## core/src/test/scala/unit/kafka/server/ShareGroupHeartbeatRequestTest.scala: ## @@ -592,6 +592,81 @@ class ShareGroupHeartbeatRequestTest(cluster: ClusterIn

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069375324 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/VersionedPluginBuilder.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069361342 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java: ## @@ -477,6 +480,27 @@ private static void compileJavaSources(Path sou

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069351324 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/VersionedPluginBuilder.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-14145) Faster propagation of high-watermark in KRaft topic partitions

2025-04-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14145: --- Parent: KAFKA-19223 Issue Type: Sub-task (was: Improvement)

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069354666 ## connect/runtime/src/test/resources/test-plugins/sampling-connector/test/plugins/VersionedSamplingSinkConnector.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the A

[jira] [Created] (KAFKA-19224) Faster HWM replication for ISR topic partitions

2025-04-30 Thread Jira
José Armando García Sancio created KAFKA-19224: -- Summary: Faster HWM replication for ISR topic partitions Key: KAFKA-19224 URL: https://issues.apache.org/jira/browse/KAFKA-19224 Project: K

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069337048 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/MultiVersionTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

[jira] [Created] (KAFKA-19223) Explicit HWM replication

2025-04-30 Thread Jira
José Armando García Sancio created KAFKA-19223: -- Summary: Explicit HWM replication Key: KAFKA-19223 URL: https://issues.apache.org/jira/browse/KAFKA-19223 Project: Kafka Issue Ty

[PR] KAFKA-19182: Move SchedulerTest to server module [kafka]

2025-04-30 Thread via GitHub
UladzislauBlok opened a new pull request, #19608: URL: https://github.com/apache/kafka/pull/19608 This PR moves SchedulerTest to server module and rewrite it with java. Please also check updated import control config! -- This is an automated message from the Apache Git Service. To r

Re: [PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Plugin Loading Isolation Tests [kafka]

2025-04-30 Thread via GitHub
snehashisp commented on code in PR #18325: URL: https://github.com/apache/kafka/pull/18325#discussion_r2069326619 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java: ## @@ -477,6 +480,27 @@ private static void compileJavaSources(Path sou

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-30 Thread via GitHub
chia7712 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2069288073 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +337,87 @@ static void throwIfRegularExpressionIsInvalid(

[jira] [Created] (KAFKA-19222) Invalid FENCED_MEMBER_EPOCH error to ConsumerGroupHeartbeat

2025-04-30 Thread Travis Bischel (Jira)
Travis Bischel created KAFKA-19222: -- Summary: Invalid FENCED_MEMBER_EPOCH error to ConsumerGroupHeartbeat Key: KAFKA-19222 URL: https://issues.apache.org/jira/browse/KAFKA-19222 Project: Kafka

[jira] [Assigned] (KAFKA-19213) Kafka java client ignores default properties

2025-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-19213: - Assignee: Kirk True > Kafka java client ignores default properties > --

Re: [PR] MINOR: Improve docs for client group configs [kafka]

2025-04-30 Thread via GitHub
lianetm merged PR #19605: URL: https://github.com/apache/kafka/pull/19605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-30 Thread via GitHub
squah-confluent commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2069188025 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +219,50 @@ void validateOffsetFetch( default boolean shouldE

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-30 Thread via GitHub
squah-confluent commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2069190560 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +337,87 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-30 Thread via GitHub
squah-confluent commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2069188025 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +219,50 @@ void validateOffsetFetch( default boolean shouldE

Re: [PR] MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor [kafka]

2025-04-30 Thread via GitHub
mjsax merged PR #19511: URL: https://github.com/apache/kafka/pull/19511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Move candidateClients set creation outside of task loop for StickyTaskAssignor [kafka]

2025-04-30 Thread via GitHub
mjsax commented on PR #19511: URL: https://github.com/apache/kafka/pull/19511#issuecomment-2842738026 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-30 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2069128680 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /** r

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-30 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2069123242 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /** r

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_relational_smoke_test [kafka]

2025-04-30 Thread via GitHub
lucasbru commented on PR #19604: URL: https://github.com/apache/kafka/pull/19604#issuecomment-2842605050 https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-04-30--001.1bc1644b-1cf2-4e1c-80eb-f194fc8a015e--1746027989--lucasbru--system_

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_relational_smoke_test [kafka]

2025-04-30 Thread via GitHub
lucasbru merged PR #19604: URL: https://github.com/apache/kafka/pull/19604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19221: Propagate IOException on LogSegment#close [kafka]

2025-04-30 Thread via GitHub
gaurav-narula commented on PR #19607: URL: https://github.com/apache/kafka/pull/19607#issuecomment-2842521035 CC: @soarez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (KAFKA-19221) IOException on log segment close shouldn't be ignored

2025-04-30 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula reassigned KAFKA-19221: - Assignee: Gaurav Narula > IOException on log segment close shouldn't be ignored > -

[PR] KAFKA-19221: Propagate IOException on LogSegment#close [kafka]

2025-04-30 Thread via GitHub
gaurav-narula opened a new pull request, #19607: URL: https://github.com/apache/kafka/pull/19607 Log segment closure results in right sizing the segment on disk along with the associated index files. This is specially important for TimeIndexes where a failure to right size may eventu

[jira] [Created] (KAFKA-19221) IOException on log segment close shouldn't be ignored

2025-04-30 Thread Gaurav Narula (Jira)
Gaurav Narula created KAFKA-19221: - Summary: IOException on log segment close shouldn't be ignored Key: KAFKA-19221 URL: https://issues.apache.org/jira/browse/KAFKA-19221 Project: Kafka Issue

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-04-30 Thread via GitHub
chia7712 commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2068992785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1306,7 +1306,10 @@ private Map beginningOrEndOffset(Collection();

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-30 Thread via GitHub
lianetm commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2068951006 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /**

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-30 Thread via GitHub
lianetm commented on PR #19595: URL: https://github.com/apache/kafka/pull/19595#issuecomment-2842454144 Thank you all for the feedback! Comments addressed and answers inline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-30 Thread via GitHub
lianetm commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2068968793 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /**

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-30 Thread via GitHub
CalvinConfluent commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2068961294 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2472,7 +2472,17 @@ class KafkaApis(val requestChannel: RequestChannel, val filteredProducerIds

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-30 Thread via GitHub
lianetm commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2068961420 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -100,7 +100,7 @@ public class ProducerConfig extends AbstractConfig {

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-30 Thread via GitHub
lianetm commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2068951006 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /**

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-04-30 Thread via GitHub
lianetm commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2068913749 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1306,7 +1306,10 @@ private Map beginningOrEndOffset(Collection();

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-30 Thread via GitHub
jolshan commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2068904148 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2472,7 +2472,17 @@ class KafkaApis(val requestChannel: RequestChannel, val filteredProducerIds = listT

[jira] [Resolved] (KAFKA-16718) Add AdminClient.deleteShareGroupOffsets

2025-04-30 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-16718. -- Fix Version/s: 4.1.0 Resolution: Fixed > Add AdminClient.deleteShareGroupOffset

Re: [PR] KAFKA-16718-4/n: ShareGroupCommand changes for DeleteShareGroupOffsets admin call [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield merged PR #19587: URL: https://github.com/apache/kafka/pull/19587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-30 Thread via GitHub
chia7712 commented on PR #19386: URL: https://github.com/apache/kafka/pull/19386#issuecomment-2842308811 @mumrah Sorry about the unclear commit message. It won't happen again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-30 Thread via GitHub
chia7712 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2068885949 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +337,87 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_relational_smoke_test [kafka]

2025-04-30 Thread via GitHub
lucasbru commented on code in PR #19604: URL: https://github.com/apache/kafka/pull/19604#discussion_r2068882446 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -784,17 +784,12 @@ def prop_file(self, node): for prop in self.per_node_server_prop_overrides.get(self.idx(n

Re: [PR] KAFKA-19210: resolved the flakiness in testShareGroupHeartbeatInitializeOnPartitionUpdate [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield merged PR #19601: URL: https://github.com/apache/kafka/pull/19601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-30 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2068862253 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +221,90 @@ void validateOffsetFetch( default boolean shouldExp

Re: [PR] KAFKA-19146: Merge OffsetAndEpoch from raft to server-common [kafka]

2025-04-30 Thread via GitHub
Mirai1129 commented on code in PR #19475: URL: https://github.com/apache/kafka/pull/19475#discussion_r2068854075 ## server-common/src/main/java/org/apache/kafka/server/common/OffsetAndEpoch.java: ## @@ -16,40 +16,11 @@ */ package org.apache.kafka.server.common; -public clas

Re: [PR] MINOR: Improve docs for client group configs [kafka]

2025-04-30 Thread via GitHub
dajac commented on code in PR #19605: URL: https://github.com/apache/kafka/pull/19605#discussion_r2068844719 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java: ## @@ -63,8 +63,10 @@ public abstract class AbstractHeartbeatRe

[PR] KAFKA-16894: Correct definition of ShareVersion [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield opened a new pull request, #19606: URL: https://github.com/apache/kafka/pull/19606 The ShareVersion feature does not make any metadata version changes. As a result, `SV_1` does not depend on any MV level, and no MV needs to be defined for the preview of KIP-932. -- This

Re: [PR] MINOR: Improve docs for client group configs [kafka]

2025-04-30 Thread via GitHub
dajac commented on code in PR #19605: URL: https://github.com/apache/kafka/pull/19605#discussion_r2068843867 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -192,7 +192,8 @@ public class CommonClientConfigs {

Re: [PR] KAFKA-19146: Merge OffsetAndEpoch from raft to server-common [kafka]

2025-04-30 Thread via GitHub
FrankYang0529 commented on code in PR #19475: URL: https://github.com/apache/kafka/pull/19475#discussion_r2068841287 ## server-common/src/main/java/org/apache/kafka/server/common/OffsetAndEpoch.java: ## @@ -16,40 +16,11 @@ */ package org.apache.kafka.server.common; -public

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-30 Thread via GitHub
mumrah commented on PR #19386: URL: https://github.com/apache/kafka/pull/19386#issuecomment-284599 @gongxuanzhang (et al.) -- I was reading through the Git log and noticed this rather vague commit message. Can we try to have more descriptive commit subjects? E.g., "Avoid unnecessary tra

Re: [PR] MINOR; Log remote replica id when rejecting vote [kafka]

2025-04-30 Thread via GitHub
jsancio merged PR #19600: URL: https://github.com/apache/kafka/pull/19600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19146: Merge OffsetAndEpoch from raft to server-common [kafka]

2025-04-30 Thread via GitHub
Mirai1129 commented on code in PR #19475: URL: https://github.com/apache/kafka/pull/19475#discussion_r2068775527 ## server-common/src/main/java/org/apache/kafka/server/common/OffsetAndEpoch.java: ## @@ -16,40 +16,11 @@ */ package org.apache.kafka.server.common; -public clas

[jira] [Updated] (KAFKA-19214) Clean up use of Optionals in RequestManagers.entries()

2025-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19214: -- Issue Type: Improvement (was: Bug) > Clean up use of Optionals in RequestManagers.entries() > ---

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-30 Thread via GitHub
chia7712 commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2068724036 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2472,7 +2472,17 @@ class KafkaApis(val requestChannel: RequestChannel, val filteredProducerIds = list

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_relational_smoke_test [kafka]

2025-04-30 Thread via GitHub
bbejeck commented on code in PR #19604: URL: https://github.com/apache/kafka/pull/19604#discussion_r2068707166 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -784,17 +784,12 @@ def prop_file(self, node): for prop in self.per_node_server_prop_overrides.get(self.idx(no

Re: [PR] KAFKA-19146: Merge OffsetAndEpoch from raft to server-common [kafka]

2025-04-30 Thread via GitHub
chia7712 commented on code in PR #19475: URL: https://github.com/apache/kafka/pull/19475#discussion_r2068692504 ## server-common/src/main/java/org/apache/kafka/server/common/OffsetAndEpoch.java: ## @@ -16,40 +16,11 @@ */ package org.apache.kafka.server.common; -public class

[PR] KAFKA-19202: Enable KIP-1071 in streams_relational_smoke_test [kafka]

2025-04-30 Thread via GitHub
lucasbru opened a new pull request, #19604: URL: https://github.com/apache/kafka/pull/19604 Enable next system test with KIP-1071. Also fixes the other KIP-1071 system tests, which now require enabling the unstable `streams.version` feature. -- This is an automated message fr

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-04-30 Thread via GitHub
chia7712 commented on PR #19578: URL: https://github.com/apache/kafka/pull/19578#issuecomment-2841869743 @kirktrue @lianetm Could you please take a look? This PR aligns the behavior of AsyncConsumer with classic consumer. -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-16894: Exploit share feature [3/N] [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield merged PR #19542: URL: https://github.com/apache/kafka/pull/19542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[PR] KAFKA-19204: Allow persister retry of initializing topics. [kafka]

2025-04-30 Thread via GitHub
smjn opened a new pull request, #19603: URL: https://github.com/apache/kafka/pull/19603 * Currently in the share group heartbeat flow, if we see a TP subscribed for the first time, we move that TP to initializing state in GC and let the GC send a persister request to share group initialize

[PR] KAFKA-19218: Add missing leader epoch to share group state summary response [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield opened a new pull request, #19602: URL: https://github.com/apache/kafka/pull/19602 When the persister is responding to a read share-group state summary request, it has no way of including the leader epoch in its response, even though it has the information to hand. This mea

[jira] [Assigned] (KAFKA-19220) add tests to ensure the internal configs don't return by public APIs by default

2025-04-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19220: -- Assignee: kangning.li (was: Chia-Ping Tsai) > add tests to ensure the internal confi

[jira] [Commented] (KAFKA-19220) add tests to ensure the internal configs don't return by public APIs by default

2025-04-30 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948434#comment-17948434 ] kangning.li commented on KAFKA-19220: - [~chia7712]  I am insteresd in this issue, cl

[jira] [Created] (KAFKA-19220) add tests to ensure the internal configs don't return by public APIs by default

2025-04-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19220: -- Summary: add tests to ensure the internal configs don't return by public APIs by default Key: KAFKA-19220 URL: https://issues.apache.org/jira/browse/KAFKA-19220 P

[jira] [Commented] (KAFKA-18068) Fixing typo in ProducerConfig

2025-04-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948432#comment-17948432 ] Chia-Ping Tsai commented on KAFKA-18068: [~mingyen066] it would be useful if we

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-30 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2841576173 > @OmniaGM : Thanks for addressing all the comments. LGTM > > @jolshan : Feel free to merge it. Thanks for reviewing this and merging. It is finally merged before hitting exa

[jira] [Assigned] (KAFKA-19217) ShareConsumerTest.testComplexShareConsumer is unreliable

2025-04-30 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan reassigned KAFKA-19217: --- Assignee: Sushant Mahajan > ShareConsumerTest.testComplexShareConsumer is unreliabl

[jira] [Created] (KAFKA-19219) improve KRaft migration log

2025-04-30 Thread Luke Chen (Jira)
Luke Chen created KAFKA-19219: - Summary: improve KRaft migration log Key: KAFKA-19219 URL: https://issues.apache.org/jira/browse/KAFKA-19219 Project: Kafka Issue Type: Improvement Affects Ver

Re: [PR] KAFKA-19160;KAFKA-19164; Improve performance of fetching stable offsets [kafka]

2025-04-30 Thread via GitHub
squah-confluent commented on code in PR #19497: URL: https://github.com/apache/kafka/pull/19497#discussion_r2068324511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -192,10 +193,165 @@ public OffsetMetadataManager build()

Re: [PR] KAFKA-16894: Exploit share feature [3/N] [kafka]

2025-04-30 Thread via GitHub
AndrewJSchofield commented on code in PR #19542: URL: https://github.com/apache/kafka/pull/19542#discussion_r2068323373 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -10935,7 +11343,20 @@ class KafkaApisTest extends Logging { @Test def testShareGrou

[jira] [Created] (KAFKA-19218) Add missing leader epoch to read share group state summary response

2025-04-30 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19218: Summary: Add missing leader epoch to read share group state summary response Key: KAFKA-19218 URL: https://issues.apache.org/jira/browse/KAFKA-19218 Project:

[PR] KAFKA-19210: resolved the flakiness in testShareGroupHeartbeatInitializeOnPartitionUpdate [kafka]

2025-04-30 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19601: URL: https://github.com/apache/kafka/pull/19601 The test testShareGroupHeartbeatInitializeOnPartitionUpdate was flaky earlier. The shareGroupStatePartitionMetadataRecord that is created during heartbeat contains 2 topics to be initialized,

[jira] [Created] (KAFKA-19217) ShareConsumerTest.testComplexShareConsumer is unreliable

2025-04-30 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19217: Summary: ShareConsumerTest.testComplexShareConsumer is unreliable Key: KAFKA-19217 URL: https://issues.apache.org/jira/browse/KAFKA-19217 Project: Kafka

[jira] [Created] (KAFKA-19216) Eliminate flakiness in kafka.server.share.SharePartitionTest

2025-04-30 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19216: Summary: Eliminate flakiness in kafka.server.share.SharePartitionTest Key: KAFKA-19216 URL: https://issues.apache.org/jira/browse/KAFKA-19216 Project: Kafka

[PR] MINOR : Update KafkaRaftClient.java INFO log [kafka]

2025-04-30 Thread via GitHub
nicolasguyomar opened a new pull request, #19600: URL: https://github.com/apache/kafka/pull/19600 Nit : Adding the replicaId in the id mismatch log to be able to troubleshoot which node has a potential network configuration problem that could cause a vote request to land on the "wrong" brok

[jira] [Assigned] (KAFKA-18068) Fixing typo in ProducerConfig

2025-04-30 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung reassigned KAFKA-18068: -- Assignee: Ming-Yen Chung > Fixing typo in ProducerConfig > --

[PR] Minor printing share group describe result in sorted order [kafka]

2025-04-30 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19599: URL: https://github.com/apache/kafka/pull/19599 This PR sorts the information that is printed when kafka-share-groups.sh --describe is used -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] HOTFIX: Fix IQv2EndpointToPartitionsIntegrationTest [kafka]

2025-04-30 Thread via GitHub
Yunyung commented on PR #19597: URL: https://github.com/apache/kafka/pull/19597#issuecomment-2841089377 The method was removed in #19509. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

  1   2   >