Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2072336376 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1645,6 +1606,7 @@ private Consumer streamThreadLeaveConsumerGroup(final long remaini

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2072336376 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1645,6 +1606,7 @@ private Consumer streamThreadLeaveConsumerGroup(final long remaini

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2072334931 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1645,6 +1606,7 @@ private Consumer streamThreadLeaveConsumerGroup(final long remaini

Re: [PR] KAFKA-19131: Adjust remote storage reader thread maximum pool size to avoid illegal argument [kafka]

2025-05-02 Thread via GitHub
kamalcph commented on PR #19629: URL: https://github.com/apache/kafka/pull/19629#issuecomment-2848468509 This is a bug-fix, so porting the change to 4.0 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] KAFKA-19131: Fix error when adjusting the remote log reader threads dynamically [kafka]

2025-05-02 Thread via GitHub
kamalcph opened a new pull request, #19629: URL: https://github.com/apache/kafka/pull/19629 The remote storage reader thread pool use same count for both maximum and core size. If users adjust the pool size larger than original value, it throws `IllegalArgumentException`. Updated both value

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2072333954 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1776,22 +1780,28 @@ private long advanceNowAndComputeLatency() {

Re: [PR] KAFKA-18537: Fix flaky RemoteIndexCacheTest#testCleanerThreadShutdown [kafka]

2025-05-02 Thread via GitHub
apalan60 commented on PR #19628: URL: https://github.com/apache/kafka/pull/19628#issuecomment-2848465207 I reproduced the original failure by looping the full `RemoteIndexCacheTest` 100 times. Before this change the test would intermittently fail within those 100 runs due to the cleaner

[PR] KAFKA-18537: Fix flaky RemoteIndexCacheTest#testCleanerThreadShutdown [kafka]

2025-05-02 Thread via GitHub
apalan60 opened a new pull request, #19628: URL: https://github.com/apache/kafka/pull/19628 Add a wait for cleaner thread shutdown in `testCleanerThreadShutdown` to eliminate flakiness. After calling `cache.close()`, the test now uses `TestUtils.waitForCondition` to poll until the backgroun

Re: [PR] KAFKA-19215: Handle share partition fetch lock cleanly in DelayedShareFetch to avoid a member incorrectly releasing a share partition's fetch lock [kafka]

2025-05-02 Thread via GitHub
AndrewJSchofield commented on code in PR #19598: URL: https://github.com/apache/kafka/pull/19598#discussion_r2072332551 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1343,21 +1346,30 @@ public boolean maybeAcquireFetchLock() { } /** - * Rel

Re: [PR] MINOR: Change info log to debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
AndrewJSchofield merged PR #19624: URL: https://github.com/apache/kafka/pull/19624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: fix bug in MockConsumer [kafka]

2025-05-02 Thread via GitHub
frankvicky merged PR #19627: URL: https://github.com/apache/kafka/pull/19627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] MINOR: replace .stream().forEach() with .forEach() [kafka]

2025-05-02 Thread via GitHub
chia7712 commented on code in PR #19626: URL: https://github.com/apache/kafka/pull/19626#discussion_r2072321157 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4487,7 +4487,7 @@ public void handleResponse(AbstractResponse abstractResponse)

Re: [PR] MINOR: Remove unnecessary Optional from offsetsToSnapshot [kafka]

2025-05-02 Thread via GitHub
chia7712 merged PR #19613: URL: https://github.com/apache/kafka/pull/19613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18171: Unexpected Change in bootstrap.servers Behavior After Upgrade to 3.8.0 [kafka]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #18706: URL: https://github.com/apache/kafka/pull/18706#issuecomment-2848406098 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2848398256 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2848398244 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-19123 the buffer of forwarded request should be released after receiving the reponse from controller [kafka]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #19566: URL: https://github.com/apache/kafka/pull/19566#issuecomment-2848398183 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18066: Fix mismatched StreamThread ID in log messages [kafka]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #19517: URL: https://github.com/apache/kafka/pull/19517#issuecomment-2848398196 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Remove unnecessary Optional from offsetsToSnapshot [kafka]

2025-05-02 Thread via GitHub
Yunyung commented on code in PR #19613: URL: https://github.com/apache/kafka/pull/19613#discussion_r2072290801 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -2416,15 +2416,14 @@ public static void rebuildProducerState(ProducerStateManage

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-05-02 Thread via GitHub
xijiu commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2072281764 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -994,8 +994,8 @@ public void testBeginningOffsetsWithZeroTimeout()

[jira] [Commented] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-02 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949112#comment-17949112 ] Jun Rao commented on KAFKA-19234: - It seems that the Fetch request does the right thing.

[PR] MINOR: fix bug in MockConsumer [kafka]

2025-05-02 Thread via GitHub
mjsax opened a new pull request, #19627: URL: https://github.com/apache/kafka/pull/19627 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[jira] [Created] (KAFKA-19235) STALE_MEMBER_EPOCH is mostly non-recoverable and forces lost commits when leaving a group (KIP-848)

2025-05-02 Thread Travis Bischel (Jira)
Travis Bischel created KAFKA-19235: -- Summary: STALE_MEMBER_EPOCH is mostly non-recoverable and forces lost commits when leaving a group (KIP-848) Key: KAFKA-19235 URL: https://issues.apache.org/jira/browse/KAFKA-

[PR] MINOR: replace .stream().forEach() with .forEach() [kafka]

2025-05-02 Thread via GitHub
yunchipang opened a new pull request, #19626: URL: https://github.com/apache/kafka/pull/19626 replace all applicable `.stream().forEach()` in codebase with just `.forEach()`. Reviewers: @chia7712 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-05-02 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2072181804 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -396,57 +396,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorized

[jira] [Comment Edited] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949028#comment-17949028 ] Justine Olshan edited comment on KAFKA-19234 at 5/2/25 9:24 PM: --

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-05-02 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2072162665 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -396,57 +396,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorize

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-05-02 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2072160983 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -396,57 +396,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorize

[jira] [Commented] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949028#comment-17949028 ] Justine Olshan commented on KAFKA-19234: relevant previous discussion here: KAFK

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-05-02 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2072160576 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -396,57 +396,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorize

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-05-02 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2072158783 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -396,57 +396,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorize

[jira] [Commented] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949021#comment-17949021 ] Travis Bischel commented on KAFKA-19233: Sorry, I wrote FENCED_LEADER_EPOCH abov

[jira] [Updated] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-19233: --- Description: If a group is on generation > 1 and a member is fenced, the member cannot rejo

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-02 Thread via GitHub
junrao commented on PR #19592: URL: https://github.com/apache/kafka/pull/19592#issuecomment-2848096085 @apoorvmittal10 : Since you requested a self review, I will let you review it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Comment Edited] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949009#comment-17949009 ] Travis Bischel edited comment on KAFKA-19233 at 5/2/25 8:48 PM: --

[jira] [Comment Edited] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949009#comment-17949009 ] Travis Bischel edited comment on KAFKA-19233 at 5/2/25 8:47 PM: --

[jira] [Comment Edited] (KAFKA-19222) Invalid FENCED_MEMBER_EPOCH error to ConsumerGroupHeartbeat

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949018#comment-17949018 ] Travis Bischel edited comment on KAFKA-19222 at 5/2/25 8:45 PM: --

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-05-02 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2072132880 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -396,57 +396,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorized

[jira] [Commented] (KAFKA-19222) Invalid FENCED_MEMBER_EPOCH error to ConsumerGroupHeartbeat

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949018#comment-17949018 ] Travis Bischel commented on KAFKA-19222: Re-issuing with all fields is the solut

[jira] [Updated] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-02 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-19234: Description: In [https://github.com/apache/kafka/pull/15968/files], we changed the authorization logic sl

[jira] [Created] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-02 Thread Jun Rao (Jira)
Jun Rao created KAFKA-19234: --- Summary: broker should return UNAUTHORIZATION error for non-existing topic in produce request Key: KAFKA-19234 URL: https://issues.apache.org/jira/browse/KAFKA-19234 Project: K

[jira] [Commented] (KAFKA-18574) Quarantined test list should be sorted

2025-05-02 Thread Harsh Kuddu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949010#comment-17949010 ] Harsh Kuddu commented on KAFKA-18574: - Hi [~kirktrue], I have sent an email to get p

Re: [PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-05-02 Thread via GitHub
kirktrue commented on code in PR #19609: URL: https://github.com/apache/kafka/pull/19609#discussion_r2072110596 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -154,16 +153,12 @@ void runOnce() { lastPollTimeMs = cu

[jira] [Commented] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949009#comment-17949009 ] Travis Bischel commented on KAFKA-19233: What has you thinking (1) did not happe

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-05-02 Thread via GitHub
lianetm commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2072105523 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -994,8 +994,8 @@ public void testBeginningOffsetsWithZeroTimeout

Re: [PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-05-02 Thread via GitHub
kirktrue commented on code in PR #19609: URL: https://github.com/apache/kafka/pull/19609#discussion_r2072105412 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -154,16 +153,12 @@ void runOnce() { lastPollTimeMs = cu

Re: [PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-05-02 Thread via GitHub
kirktrue commented on code in PR #19609: URL: https://github.com/apache/kafka/pull/19609#discussion_r2072104421 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -382,7 +382,7 @@ public void testFetcherCloseClosesFetchSessio

Re: [PR] KAFKA-19214: Clean up use of Optionals in RequestManagers.entries() [kafka]

2025-05-02 Thread via GitHub
kirktrue commented on code in PR #19609: URL: https://github.com/apache/kafka/pull/19609#discussion_r2072104073 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -117,9 +116,9 @@ public void testEnsureCloseStopsRunningThre

Re: [PR] KAFKA-19182: Move SchedulerTest to server module [kafka]

2025-05-02 Thread via GitHub
UladzislauBlok commented on PR #19608: URL: https://github.com/apache/kafka/pull/19608#issuecomment-2847990255 One failed flaky test: PlaintextConsumerTest > testCloseLeavesGroupOnInterrupt(String).groupProtocol=classic Not related to current change -- This is an automated message from

[jira] [Commented] (KAFKA-19222) Invalid FENCED_MEMBER_EPOCH error to ConsumerGroupHeartbeat

2025-05-02 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948969#comment-17948969 ] Lianet Magrans commented on KAFKA-19222:  Hey [~twmb] ! When implementing the pr

[jira] [Commented] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948964#comment-17948964 ] Lianet Magrans commented on KAFKA-19233: Hi [~twmb] ! When a member is fenced, i

[jira] [Assigned] (KAFKA-18537) Fix flaky RemoteIndexCacheTest#testCleanerThreadShutdown

2025-05-02 Thread HongYi Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HongYi Chen reassigned KAFKA-18537: --- Assignee: HongYi Chen > Fix flaky RemoteIndexCacheTest#testCleanerThreadShutdown >

[jira] [Commented] (KAFKA-18537) Fix flaky RemoteIndexCacheTest#testCleanerThreadShutdown

2025-05-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948961#comment-17948961 ] Chia-Ping Tsai commented on KAFKA-18537: It should be test by TestUtils.waitForC

[jira] [Commented] (KAFKA-18957) Impossible to recover hanging transactions in Kafka 3.9 in KRaft mode using EOS

2025-05-02 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948960#comment-17948960 ] Travis Bischel commented on KAFKA-18957: As a point of consolation, I have not r

[jira] [Commented] (KAFKA-17091) Add @FunctionalInterface to Streams interfaces

2025-05-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948952#comment-17948952 ] Matthias J. Sax commented on KAFKA-17091: - Fixed via [https://github.com/apache/

[jira] [Updated] (KAFKA-17091) Add @FunctionalInterface to Streams interfaces

2025-05-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17091: Labels: (was: need-kip) > Add @FunctionalInterface to Streams interfaces > -

[jira] [Assigned] (KAFKA-17091) Add @FunctionalInterface to Streams interfaces

2025-05-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-17091: --- Assignee: (was: Ray McDermott) > Add @FunctionalInterface to Streams interfaces

Re: [PR] KAFKA-17091: Add @FunctionalInterface to Streams interfaces [kafka]

2025-05-02 Thread via GitHub
mjsax commented on PR #16544: URL: https://github.com/apache/kafka/pull/16544#issuecomment-2847788380 Fixed via https://github.com/apache/kafka/pull/19234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-02 Thread via GitHub
adixitconfluent commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r2071960339 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -248,6 +250,8 @@ private void processAcquiredTopicPartitionsForLocalLogFetch(LinkedHashM

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-05-02 Thread via GitHub
chia7712 commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2071933799 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1306,7 +1306,10 @@ private Map beginningOrEndOffset(Collection();

Re: [PR] MINOR: improve AdjustStreamThreadCountTest [kafka]

2025-05-02 Thread via GitHub
mjsax commented on code in PR #19617: URL: https://github.com/apache/kafka/pull/19617#discussion_r2071933067 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java: ## @@ -239,10 +241,30 @@ public void shouldAddAndRemoveT

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-05-02 Thread via GitHub
xijiu commented on PR #19578: URL: https://github.com/apache/kafka/pull/19578#issuecomment-2847734750 @lianetm That's indeed the case. The suggestions are very clear, and I will fix them soon. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-02 Thread via GitHub
junrao commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r2071876211 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -274,6 +276,32 @@ private void processAcquiredTopicPartitionsForLocalLogFetch(LinkedHashMap has l

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_standby_replica_test.py [kafka]

2025-05-02 Thread via GitHub
lucasbru commented on PR #19625: URL: https://github.com/apache/kafka/pull/19625#issuecomment-2847678577 https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-05-02--001.2516e1f2-7702-48ec-a5ba-54bce7a4f328--1746204646--lucasbru--system_

Re: [PR] MINOR: Change info log to debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
smjn commented on code in PR #19624: URL: https://github.com/apache/kafka/pull/19624#discussion_r2071865341 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java: ## @@ -322,7 +322,7 @@ private CompletableFuture performRecordPruning(

Re: [PR] MINOR: Change info log to debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
smjn commented on code in PR #19624: URL: https://github.com/apache/kafka/pull/19624#discussion_r2071865341 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java: ## @@ -322,7 +322,7 @@ private CompletableFuture performRecordPruning(

[jira] [Updated] (KAFKA-19153) Add OAuth integration tests

2025-05-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19153: -- Summary: Add OAuth integration tests (was: Add OAuth integration tests using Keycloak) > Add OAuth i

Re: [PR] KAFKA-19232: Handle Share session limit reached exception in clients. [kafka]

2025-05-02 Thread via GitHub
AndrewJSchofield commented on code in PR #19619: URL: https://github.com/apache/kafka/pull/19619#discussion_r2071867706 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareSessionHandler.java: ## @@ -219,7 +219,8 @@ private String topicIdPartitionsToLogStr

Re: [PR] MINOR: Change info log to debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
smjn commented on code in PR #19624: URL: https://github.com/apache/kafka/pull/19624#discussion_r2071865341 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java: ## @@ -322,7 +322,7 @@ private CompletableFuture performRecordPruning(

Re: [PR] MINOR: Change info log to debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
smjn commented on code in PR #19624: URL: https://github.com/apache/kafka/pull/19624#discussion_r2071865341 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java: ## @@ -322,7 +322,7 @@ private CompletableFuture performRecordPruning(

Re: [PR] MINOR: Change info log to debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
apoorvmittal10 commented on code in PR #19624: URL: https://github.com/apache/kafka/pull/19624#discussion_r2071834228 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java: ## @@ -322,7 +322,7 @@ private CompletableFuture performReco

[jira] [Updated] (KAFKA-19222) Invalid FENCED_MEMBER_EPOCH error to ConsumerGroupHeartbeat

2025-05-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19222: -- Component/s: clients consumer > Invalid FENCED_MEMBER_EPOCH error to ConsumerGroupHea

[jira] [Updated] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19233: -- Component/s: clients consumer > Members cannot rejoin with epoch=0 for KIP-848 >

[PR] KAFKA-19202: Enable KIP-1071 in streams_standby_replica_test.py [kafka]

2025-05-02 Thread via GitHub
lucasbru opened a new pull request, #19625: URL: https://github.com/apache/kafka/pull/19625 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some com

[jira] [Created] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-02 Thread Travis Bischel (Jira)
Travis Bischel created KAFKA-19233: -- Summary: Members cannot rejoin with epoch=0 for KIP-848 Key: KAFKA-19233 URL: https://issues.apache.org/jira/browse/KAFKA-19233 Project: Kafka Issue Type

Re: [PR] MINOR: Change info log to debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
apoorvmittal10 commented on code in PR #19624: URL: https://github.com/apache/kafka/pull/19624#discussion_r2071834228 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java: ## @@ -322,7 +322,7 @@ private CompletableFuture performReco

[jira] [Updated] (KAFKA-19228) Formatting with `--no-initial-controllers` flag should not write kraft version control record

2025-05-02 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu updated KAFKA-19228: - Description: The current implementation of this flag will write kraft version 1 to the `bootstrap.check

[jira] [Updated] (KAFKA-19228) Formatting with `--no-initial-controllers` flag should not write kraft version control record

2025-05-02 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu updated KAFKA-19228: - Description: The current implementation of this flag will write kraft version 1 to the bootstrap metada

Re: [PR] KAFKA-19078: Implement automatic controller addition to cluster metadata partition [kafka]

2025-05-02 Thread via GitHub
kevin-wu24 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2071812359 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3328,6 +3405,23 @@ private UpdateRaftVoterRequestData buildUpdateVoterRequest() {

Re: [PR] KAFKA-19207: Move ForwardingManagerMetrics and ForwardingManagerMetricsTest to server module [kafka]

2025-05-02 Thread via GitHub
FrankYang0529 commented on PR #19574: URL: https://github.com/apache/kafka/pull/19574#issuecomment-2847556462 @chia7712 I addressed all comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] MINOR: Change info log debug for scheduled timer tasks. [kafka]

2025-05-02 Thread via GitHub
smjn opened a new pull request, #19624: URL: https://github.com/apache/kafka/pull/19624 * We have a 2 perpetual timer tasks in ShareCoordinatorService to do internal topic cleanup and snapshot cold partitions respectively. * There are a few info level logs being printed as part of the pro

[PR] (WIP)KAFKA-19203 Replace `ApiError#exception` by `Error#exception` for KafkaAdminClient [kafka]

2025-05-02 Thread via GitHub
jim0987795064 opened a new pull request, #19623: URL: https://github.com/apache/kafka/pull/19623 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add som

[PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-02 Thread via GitHub
kirktrue opened a new pull request, #19622: URL: https://github.com/apache/kafka/pull/19622 Rename `AccessTokenRetriever` and `AccessTokenValidator` to `JwtRetriever` and `JwtValidator`, respectively. Also converting the factory pattern classes `AccessTokenRetrieverFactory` and `AccessToken

[jira] [Commented] (KAFKA-18996) Expose addReadOnlyStateStore in DSL (StreamsBuilder)

2025-05-02 Thread Siddhartha Devineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948922#comment-17948922 ] Siddhartha Devineni commented on KAFKA-18996: - Here is the PR for this imple

[PR] KAFKA-18996 Expose addReadOnlyStateStore in DSL (StreamsBuilder) [kafka]

2025-05-02 Thread via GitHub
siddharthaDevineni opened a new pull request, #19621: URL: https://github.com/apache/kafka/pull/19621 KIP-1174: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=354453959 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] MINOR: Remove unnecessary Optional from offsetsToSnapshot [kafka]

2025-05-02 Thread via GitHub
chia7712 commented on code in PR #19613: URL: https://github.com/apache/kafka/pull/19613#discussion_r2071664068 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -2443,11 +2442,9 @@ public static void rebuildProducerState(ProducerStateManage

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-05-02 Thread via GitHub
lianetm commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2071621283 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1634,7 +1635,8 @@ public Map beginningOffsets(Collection par * @param parti

Re: [PR] KAFKA-19087: Move TransactionState to transaction-coordinator module [kafka]

2025-05-02 Thread via GitHub
FrankYang0529 commented on PR #19568: URL: https://github.com/apache/kafka/pull/19568#issuecomment-2847215953 @chia7712 Fixed conflicts. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] MINOR: Ignoring test_broker_failure until the the failure is resolved [kafka]

2025-05-02 Thread via GitHub
chirag-wadhwa5 closed pull request #19620: MINOR: Ignoring test_broker_failure until the the failure is resolved URL: https://github.com/apache/kafka/pull/19620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-19204: Allow persister retry of initializing topics. [kafka]

2025-05-02 Thread via GitHub
AndrewJSchofield merged PR #19603: URL: https://github.com/apache/kafka/pull/19603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Commented] (KAFKA-14056) Test reading of old messages formats in ZK-to-KRaft upgrade test

2025-05-02 Thread Dhiyaneshwaran Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948899#comment-17948899 ] Dhiyaneshwaran Radhakrishnan commented on KAFKA-14056: -- Since this

[jira] [Comment Edited] (KAFKA-14056) Test reading of old messages formats in ZK-to-KRaft upgrade test

2025-05-02 Thread Dhiyaneshwaran Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948896#comment-17948896 ] Dhiyaneshwaran Radhakrishnan edited comment on KAFKA-14056 at 5/2/25 12:40 PM: ---

[jira] [Comment Edited] (KAFKA-14056) Test reading of old messages formats in ZK-to-KRaft upgrade test

2025-05-02 Thread Dhiyaneshwaran Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948896#comment-17948896 ] Dhiyaneshwaran Radhakrishnan edited comment on KAFKA-14056 at 5/2/25 12:39 PM: ---

[jira] [Commented] (KAFKA-14056) Test reading of old messages formats in ZK-to-KRaft upgrade test

2025-05-02 Thread Dhiyaneshwaran Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948896#comment-17948896 ] Dhiyaneshwaran Radhakrishnan commented on KAFKA-14056: -- Hi all, I’

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
ableegoldman commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2071546806 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -2013,6 +2024,12 @@ public Map> clientInstanceIds(final Duration ti

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
ableegoldman commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2071532836 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1776,22 +1780,28 @@ private long advanceNowAndComputeLatency() {

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
ableegoldman commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2071529203 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1181,7 +1180,6 @@ private Optional removeStreamThread(final long timeoutMs) throws Tim

[PR] MINOR: Ignoring test_broker_failure until the the failure is resolved [kafka]

2025-05-02 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19620: URL: https://github.com/apache/kafka/pull/19620 Previous few nightly runs show that the system test `test_broker_failure` is failing. This PR marks that test with @ignore until the test is fixed -- This is an automated message from the Apa

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-02 Thread via GitHub
ableegoldman commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2071526999 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1181,7 +1180,6 @@ private Optional removeStreamThread(final long timeoutMs) throws Tim

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-05-02 Thread via GitHub
xijiu commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2071504565 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1306,7 +1306,10 @@ private Map beginningOrEndOffset(Collection(); R

  1   2   >