Re: [PR] MINOR: Use block instead of backtick [kafka]

2025-07-05 Thread via GitHub
frankvicky merged PR #20107: URL: https://github.com/apache/kafka/pull/20107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[PR] KAFKA-19466: LogConcurrencyTest should close the log when the test completes; migrate LogConcurrencyTest [kafka]

2025-07-05 Thread via GitHub
Yunyung opened a new pull request, #20110: URL: https://github.com/apache/kafka/pull/20110 - Fix testUncommittedDataNotConsumedFrequentSegmentRolls() and testUncommittedDataNotConsumed(), which call createLog() but never close the log when the tests complete. - Move LogConcurrencyTest to

Re: [PR] KAFKA-19457: Make share group init retry interval configurable. [kafka]

2025-07-05 Thread via GitHub
TaiJuWu commented on code in PR #20104: URL: https://github.com/apache/kafka/pull/20104#discussion_r2187996371 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -437,6 +445,8 @@ public GroupCoordinatorConfig(AbstractConfig c

Re: [PR] KAFKA-19457: Make share group init retry interval configurable. [kafka]

2025-07-05 Thread via GitHub
TaiJuWu commented on code in PR #20104: URL: https://github.com/apache/kafka/pull/20104#discussion_r2187996371 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -437,6 +445,8 @@ public GroupCoordinatorConfig(AbstractConfig c

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-07-05 Thread via GitHub
github-actions[bot] commented on PR #19199: URL: https://github.com/apache/kafka/pull/19199#issuecomment-3040738868 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17037:KIP-919 supports for `describeClientQuotas` and `alterClientQuotas` [kafka]

2025-07-05 Thread via GitHub
github-actions[bot] closed pull request #17339: KAFKA-17037:KIP-919 supports for `describeClientQuotas` and `alterClientQuotas` URL: https://github.com/apache/kafka/pull/17339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-17037:KIP-919 supports for `describeClientQuotas` and `alterClientQuotas` [kafka]

2025-07-05 Thread via GitHub
github-actions[bot] commented on PR #17339: URL: https://github.com/apache/kafka/pull/17339#issuecomment-3040738797 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-19048: Minimal movement replica balancing algorithm for reassignment [kafka]

2025-07-05 Thread via GitHub
github-actions[bot] commented on PR #19858: URL: https://github.com/apache/kafka/pull/19858#issuecomment-3040702264 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Move partitions == 0 logic from waitForTopic to waitTopicDeletion [kafka]

2025-07-05 Thread via GitHub
TaiJuWu commented on code in PR #20108: URL: https://github.com/apache/kafka/pull/20108#discussion_r2187884704 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java: ## @@ -258,7 +258,52 @@ default Set supportedGroupProtocols() {

Re: [PR] KAFKA-19457: Make share group init retry interval configurable. [kafka]

2025-07-05 Thread via GitHub
DL1231 commented on PR #20104: URL: https://github.com/apache/kafka/pull/20104#issuecomment-3040517846 Thanks for the patch, LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-07-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17999332#comment-17999332 ] Kirk True commented on KAFKA-19259: --- [~goyarpit] the fetch eviction rate issue was fou

Re: [PR] MINOR: Use block instead of backtick [kafka]

2025-07-05 Thread via GitHub
m1a2st commented on PR #20107: URL: https://github.com/apache/kafka/pull/20107#issuecomment-3040479294 > why does "class path of the" have a weird format in the attached picture? That was the format used in Chrome search results. ![CleanShot 2025-07-06 at 08 24 52@2x](https://g

[PR] Backport KAFKA-19397 to 4.1 [kafka]

2025-07-05 Thread via GitHub
jim0987795064 opened a new pull request, #20109: URL: https://github.com/apache/kafka/pull/20109 Backport of [KAFKA-19397](https://github.com/apache/kafka/pull/19964) to the 4.1 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] MINOR: Move partitions == 0 logic from waitForTopic to waitTopicDeletion [kafka]

2025-07-05 Thread via GitHub
jim0987795064 opened a new pull request, #20108: URL: https://github.com/apache/kafka/pull/20108 ## Changes - The partitions == 0 branch has been moved from **waitForTopic** to **waitTopicDeletion**. ## Reasons - Clarify the responsibility of each helper method makes the

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-05 Thread via GitHub
chia7712 commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2187641399 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -1335,11 +1335,14 @@ object TestUtils extends Logging { case Failure(e) => throw e } -

Re: [PR] MINOR: Use block instead of backtick [kafka]

2025-07-05 Thread via GitHub
chia7712 commented on PR #20107: URL: https://github.com/apache/kafka/pull/20107#issuecomment-3039781619 why does "class path of the" have a weird format in the attached picture? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (KAFKA-19221) IOException on log segment close shouldn't be ignored

2025-07-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19221: --- Fix Version/s: (was: 4.2.0) > IOException on log segment close shouldn't be ignored > --

Re: [PR] KAFKA-19221: Backport to 4.0 [kafka]

2025-07-05 Thread via GitHub
chia7712 merged PR #20072: URL: https://github.com/apache/kafka/pull/20072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Use block instead of backtick [kafka]

2025-07-05 Thread via GitHub
Yunyung commented on PR #20107: URL: https://github.com/apache/kafka/pull/20107#issuecomment-3039570274 Thanks for the PR, I see that many other places in the docs also use backticks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-19430) Don't fail on RecordCorruptedException

2025-07-05 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17998828#comment-17998828 ] Uladzislau Blok commented on KAFKA-19430: - [~mjsax] Hey. I could handle this, if

[jira] [Assigned] (KAFKA-19430) Don't fail on RecordCorruptedException

2025-07-05 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-19430: --- Assignee: Uladzislau Blok > Don't fail on RecordCorruptedException > --

Re: [PR] KAFKA-19299: Fix race condition in RemoteIndexCacheTest [kafka]

2025-07-05 Thread via GitHub
UladzislauBlok commented on PR #19927: URL: https://github.com/apache/kafka/pull/19927#issuecomment-3039484578 @chia7712 @FrankYang0529 Hey Guys, sorry for the ping. This PR was waiting for sometime. Could please take a look? -- This is an automated message from the Apache Git Service. T

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-05 Thread via GitHub
jim0987795064 commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2187469009 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2873,23 +2873,41 @@ class PlaintextAdminIntegrationTest extends BaseAdmi

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-05 Thread via GitHub
frankvicky commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2187343781 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2873,23 +2873,41 @@ class PlaintextAdminIntegrationTest extends BaseAdminIn

Re: [PR] MINOR: Migrate CoordinatorLoaderImplTest from Scala to Java [kafka]

2025-07-05 Thread via GitHub
frankvicky commented on code in PR #20089: URL: https://github.com/apache/kafka/pull/20089#discussion_r2187224213 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -640,7 +642,8 @@ class BrokerServer( val serde = new ShareCoordinatorRecordSerde val loader =

Re: [PR] MINOR: Migrate CoordinatorLoaderImplTest from Scala to Java [kafka]

2025-07-05 Thread via GitHub
frankvicky commented on code in PR #20089: URL: https://github.com/apache/kafka/pull/20089#discussion_r2187192871 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorLoaderImpl.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Softw

Re: [PR] MINOR: Use block instead of backtick [kafka]

2025-07-05 Thread via GitHub
m1a2st commented on PR #20107: URL: https://github.com/apache/kafka/pull/20107#issuecomment-3038892351 ![CleanShot 2025-07-05 at 20 50 13](https://github.com/user-attachments/assets/7ca2ba46-ba9c-4c90-99b8-777212439411) ![CleanShot 2025-07-05 at 20 45 51](https://github.com/user-attachme

[PR] MINOR: Use block instead of backtick [kafka]

2025-07-05 Thread via GitHub
m1a2st opened a new pull request, #20107: URL: https://github.com/apache/kafka/pull/20107 When writing HTML, it's recommended to use the element instead of backticks for inline code formatting. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-19457: Make share group init retry interval configurable. [kafka]

2025-07-05 Thread via GitHub
smjn commented on PR #20104: URL: https://github.com/apache/kafka/pull/20104#issuecomment-3038536701 @AndrewJSchofield Thanks for the comments, incorporated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov