[PR] MINOR: Improve RLMM doc [kafka]

2025-08-04 Thread via GitHub
mapan1984 opened a new pull request, #20306: URL: https://github.com/apache/kafka/pull/20306 Improve RLMM doc: 1. Distinguish RLMM configs from other tiered storage configs, all RLMM configs need to start with a specific prefix, but the original documentation miss description. 2. Adde

[jira] [Resolved] (KAFKA-18205) Refactor share coordinator and related classes for better readability and organization

2025-08-04 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan resolved KAFKA-18205. - Resolution: Fixed This was a placeholder and the coordinator is in better shape over mul

[jira] [Created] (KAFKA-19580) Upgrade spotbug to 4.9.4

2025-08-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19580: -- Summary: Upgrade spotbug to 4.9.4 Key: KAFKA-19580 URL: https://issues.apache.org/jira/browse/KAFKA-19580 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-19580) Upgrade spotbug to 4.9.4

2025-08-04 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012028#comment-18012028 ] xuanzhang gong commented on KAFKA-19580: hello,I will fix it > Upgrade spotbug

[jira] [Resolved] (KAFKA-19579) Add missing metrics for document tiered storage

2025-08-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19579. Fix Version/s: 4.2.0 Resolution: Fixed > Add missing metrics for document tiered st

Re: [PR] KAFKA-19579: Add missing metrics for doc tiered storage [kafka]

2025-08-04 Thread via GitHub
chia7712 merged PR #20304: URL: https://github.com/apache/kafka/pull/20304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2253137334 ## docs/documentation/compatibility.html: ## @@ -30,7 +30,7 @@ JDK Compatibility Across Kafka Versions Kafka Version Java 11

[jira] [Assigned] (KAFKA-19580) Upgrade spotbug to 4.9.4

2025-08-04 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuanzhang gong reassigned KAFKA-19580: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > Upgrade spotbug to 4.9.4 >

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2253131387 ## build.gradle: ## @@ -72,6 +72,12 @@ ext { "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED" ) + if (JavaVersion.current().isCompatibleWi

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3153286964 @jaredharley thanks for spotting that and provide a fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (KAFKA-19576) Fix typo in state-change log filename after rotate

2025-08-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19576. Resolution: Fixed trunk: https://github.com/apache/kafka/commit/66b3c07954c94ed2f3c7dec95

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3153284745 @mimaison I cherry-pick #19996 to 4.1 branch to eliminate conflicts @clolov The cherry-pick to 4.0 had many conflicts, so I made some modifications locally. Pleas feel free to rais

Re: [PR] MINOR: The upgrade.html file contains duplicate IDs on the same page [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #19996: URL: https://github.com/apache/kafka/pull/19996#issuecomment-3153255832 I just cherry-picked this PR to 4.1 to merge #20269 without conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 merged PR #20269: URL: https://github.com/apache/kafka/pull/20269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-08-04 Thread via GitHub
github-actions[bot] closed pull request #19199: KAFKA-16616: refactor mergeWith and updatePartitionLeadership URL: https://github.com/apache/kafka/pull/19199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-08-04 Thread via GitHub
github-actions[bot] commented on PR #19199: URL: https://github.com/apache/kafka/pull/19199#issuecomment-3153187766 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18171: Unexpected Change in bootstrap.servers Behavior After Upgrade to 3.8.0 [kafka]

2025-08-04 Thread via GitHub
github-actions[bot] commented on PR #18706: URL: https://github.com/apache/kafka/pull/18706#issuecomment-3153187642 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-19479: at_least_once mode in Kafka Streams silently drops messages when the producer fails with MESSAGE_TOO_LARGE, violating delivery guarantees [kafka]

2025-08-04 Thread via GitHub
github-actions[bot] commented on PR #20254: URL: https://github.com/apache/kafka/pull/20254#issuecomment-3153158682 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]

2025-08-04 Thread via GitHub
m1a2st commented on PR #20275: URL: https://github.com/apache/kafka/pull/20275#issuecomment-3153136639 @Yunyung, Thanks for the comment! Maybe we can import ApiException to simplify the resolution of this issue. -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (KAFKA-16768) SocketServer leaks accepted SocketChannel instances due to race condition

2025-08-04 Thread Chang-Yu Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012007#comment-18012007 ] Chang-Yu Huang commented on KAFKA-16768: Hello [~gharris1727] may you review my

Re: [PR] MINOR: add missing section to TOC [kafka]

2025-08-04 Thread via GitHub
mjsax commented on PR #20305: URL: https://github.com/apache/kafka/pull/20305#issuecomment-3152940688 Plan to cherry-pick to 4.1, and 4.0 branches, and also update `kafka-site` directly in case either 4.0.1 or 4.1.0 does not pick it up. -- This is an automated message from the Apache Git

[PR] MINOR: add missing section to TOC [kafka]

2025-08-04 Thread via GitHub
mjsax opened a new pull request, #20305: URL: https://github.com/apache/kafka/pull/20305 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] MINOR: Improve skip-record-metadata description [kafka]

2025-08-04 Thread via GitHub
showuon merged PR #20291: URL: https://github.com/apache/kafka/pull/20291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Cleanup Tools Module (2/n) [kafka]

2025-08-04 Thread via GitHub
sjhajharia commented on PR #20096: URL: https://github.com/apache/kafka/pull/20096#issuecomment-3152835017 Thanks @chia7712 Updated the PR with the changes suggested. Requesting a re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] MINOR: Cleanup Tools Module (2/n) [kafka]

2025-08-04 Thread via GitHub
sjhajharia commented on code in PR #20096: URL: https://github.com/apache/kafka/pull/20096#discussion_r2252814674 ## tools/src/test/java/org/apache/kafka/tools/TopicCommandTest.java: ## @@ -257,7 +257,7 @@ public void testCreateTopicDoesNotRetryThrottlingQuotaExceededException(

Re: [PR] KAFKA-19479: at_least_once mode in Kafka Streams silently drops messages when the producer fails with MESSAGE_TOO_LARGE, violating delivery guarantees [kafka]

2025-08-04 Thread via GitHub
junrao commented on PR #20254: URL: https://github.com/apache/kafka/pull/20254#issuecomment-3152755901 @mjsax : Hmm, the splitting code has some logic to chain the response futures. When we append a record to a new batch after a split, we create a new future for the record and chain it to t

Re: [PR] KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-08-04 Thread via GitHub
lucliu1108 commented on code in PR #20244: URL: https://github.com/apache/kafka/pull/20244#discussion_r2252738353 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -4363,6 +4364,170 @@ class PlaintextAdminIntegrationTest extends BaseAdminIn

Re: [PR] KAFKA-19340: Move DelayedRemoteFetch to the storage module [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #19876: URL: https://github.com/apache/kafka/pull/19876#issuecomment-3152001635 ``` > Compilation failed; see the compiler output below. /home/chia7712/project/kafka/server/src/main/java/org/apache/kafka/server/purgatory/DelayedRemoteFetch.java:165: error: e

Re: [PR] KAFKA-19565 Integration test for Streams-related Admin APIs[2/N] [kafka]

2025-08-04 Thread via GitHub
aliehsaeedii commented on PR #20266: URL: https://github.com/apache/kafka/pull/20266#issuecomment-3152074944 Thanks @lucliu1108 it's a high level review. Please either add tests for listing streams groups as well or modify one of the existing tests. -- This is an automated message

Re: [PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]

2025-08-04 Thread via GitHub
Yunyung commented on PR #20275: URL: https://github.com/apache/kafka/pull/20275#issuecomment-3152073381 I see the reason for the IDE warning: `ApiException` is not imported. https://github.com/user-attachments/assets/7b5a8cb2-e1bd-4e43-b312-c01413b26664"; /> -- This is an automated

Re: [PR] KAFKA-19340: Move DelayedRemoteFetch to the storage module [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #19876: URL: https://github.com/apache/kafka/pull/19876#discussion_r2252338186 ## server/src/main/java/org/apache/kafka/server/purgatory/DelayedRemoteFetch.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] MINOR: Upgrade Spotbugs to 4.9.1 [kafka]

2025-08-04 Thread via GitHub
chia7712 merged PR #20294: URL: https://github.com/apache/kafka/pull/20294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-08-04 Thread via GitHub
aliehsaeedii commented on code in PR #20244: URL: https://github.com/apache/kafka/pull/20244#discussion_r2251478203 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -4363,6 +4364,170 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

[PR] MINOR: Add comprehensive test coverage for StorageTool format command feature validation [kafka]

2025-08-04 Thread via GitHub
sjhajharia opened a new pull request, #20303: URL: https://github.com/apache/kafka/pull/20303 ### Summary Adds comprehensive test coverage for the StorageTool format command feature validation, including tests for valid feature overrides, invalid feature detection, and multiple feature s

Re: [PR] KAFKA-19579: Add missing metrics for doc tiered storage [kafka]

2025-08-04 Thread via GitHub
majialoong commented on PR #20304: URL: https://github.com/apache/kafka/pull/20304#issuecomment-3151823844 Hi , @chia7712 @kamalcph , when have time, please review this PR , thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[PR] KAFKA-19579: Add missing metrics for doc tiered storage [kafka]

2025-08-04 Thread via GitHub
majialoong opened a new pull request, #20304: URL: https://github.com/apache/kafka/pull/20304 Add missing metrics for document tiered storage - kafka.log.remote:type=RemoteLogManager,name=RemoteLogReaderFetchRateAndTimeMs:Introduced in [KIP-1018](https://cwiki.apache.org/confluence/

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
jaredharley commented on code in PR #20269: URL: https://github.com/apache/kafka/pull/20269#discussion_r2252211934 ## docs/upgrade.html: ## @@ -494,6 +497,10 @@ Nota See https://cwiki.apache.org/confluence/x/B40ODg";>KIP-890 and https:/

[jira] [Created] (KAFKA-19579) Add missing metrics for document tiered storage

2025-08-04 Thread majialong (Jira)
majialong created KAFKA-19579: - Summary: Add missing metrics for document tiered storage Key: KAFKA-19579 URL: https://issues.apache.org/jira/browse/KAFKA-19579 Project: Kafka Issue Type: Task

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20269: URL: https://github.com/apache/kafka/pull/20269#discussion_r2252195582 ## docs/upgrade.html: ## @@ -494,6 +497,10 @@ Nota See https://cwiki.apache.org/confluence/x/B40ODg";>KIP-890 and https://cw

Re: [PR] MINOR: Cleanup Tools Module (2/n) [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20096: URL: https://github.com/apache/kafka/pull/20096#discussion_r2252170199 ## tools/src/test/java/org/apache/kafka/tools/TopicCommandTest.java: ## @@ -236,9 +236,9 @@ public void testParseAssignmentPartitionsOfDifferentSize() { public vo

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
jaredharley commented on code in PR #20269: URL: https://github.com/apache/kafka/pull/20269#discussion_r2252176331 ## docs/upgrade.html: ## @@ -494,6 +497,10 @@ Nota See https://cwiki.apache.org/confluence/x/B40ODg";>KIP-890 and https:/

[jira] [Updated] (KAFKA-19576) Fix typo in state-change log filename after rotate

2025-08-04 Thread Jared Harley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Harley updated KAFKA-19576: - Description: The log4j2 config file was incorrectly rotating the state-change.log to {{stage-ch

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20269: URL: https://github.com/apache/kafka/pull/20269#discussion_r2252039800 ## docs/upgrade.html: ## @@ -494,6 +497,10 @@ Nota See https://cwiki.apache.org/confluence/x/B40ODg";>KIP-890 and https://cw

[jira] [Assigned] (KAFKA-19576) Fix typo in state-change log filename after rotate

2025-08-04 Thread Jared Harley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Harley reassigned KAFKA-19576: Assignee: Jared Harley > Fix typo in state-change log filename after rotate > ---

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
jaredharley commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3151485016 Hello all, thank you for the feedback. I've just pushed the changes to the update page as requested - please let me know if you'd like to see any changes to the wording. I am i

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3151476616 create https://issues.apache.org/jira/browse/KAFKA-19578 to trace the flaky > Ideally we'd want to merge this quickly so we can start building new RCs for 4.1.0 and 4.0.1. If @jare

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-04 Thread via GitHub
Yunyung commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2251967584 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -221,4 +303,156 @@ private static KafkaProducer createKafkaProducer(Optional(producerProps);

[jira] [Created] (KAFKA-19578) Fix flaky RemoteLogManagerTest#testCopyQuota

2025-08-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19578: -- Summary: Fix flaky RemoteLogManagerTest#testCopyQuota Key: KAFKA-19578 URL: https://issues.apache.org/jira/browse/KAFKA-19578 Project: Kafka Issue Type:

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-04 Thread via GitHub
Yunyung commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2251888324 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -77,21 +87,35 @@ static int mainNoExit(String... args) { } // Visible for testing

Re: [PR] MINOR: improve the min.insync.replicas doc [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20237: URL: https://github.com/apache/kafka/pull/20237#issuecomment-3151452032 > Yes this needs backporting to 4.1. Go ahead if you can, otherwise I'll do it tomorrow morning my time. Thanks! done https://github.com/apache/kafka/commit/cdc7a4e2b737a614259003

Re: [PR] MINOR: improve the min.insync.replicas doc [kafka]

2025-08-04 Thread via GitHub
mimaison commented on PR #20237: URL: https://github.com/apache/kafka/pull/20237#issuecomment-3151439439 Yes this needs backporting to 4.1. Go ahead if you can, otherwise I'll do it tomorrow morning my time. Thanks! -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] MINOR: improve the min.insync.replicas doc [kafka]

2025-08-04 Thread via GitHub
chia7712 merged PR #20237: URL: https://github.com/apache/kafka/pull/20237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
mimaison commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3151435718 Ideally we'd want to merge this quickly so we can start building new RCs for 4.1.0 and 4.0.1. If @jaredharley is not able to push an update, we can merge this as is and do the cleanup in

Re: [PR] MINOR: improve the min.insync.replicas doc [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20237: URL: https://github.com/apache/kafka/pull/20237#issuecomment-3151431838 @mimaison Should we backport it to 4.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
srdo commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2251929489 ## build.gradle: ## @@ -72,6 +72,12 @@ ext { "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED" ) + if (JavaVersion.current().isCompatibleWith(J

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2251889407 ## build.gradle: ## @@ -72,6 +72,12 @@ ext { "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED" ) + if (JavaVersion.current().isCompatibleWi

Re: [PR] MINOR: Cleanup Tools Module (2/n) [kafka]

2025-08-04 Thread via GitHub
sjhajharia commented on PR #20096: URL: https://github.com/apache/kafka/pull/20096#issuecomment-3151259133 Gentle reminder @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Cleanup Server Module [kafka]

2025-08-04 Thread via GitHub
sjhajharia commented on PR #20180: URL: https://github.com/apache/kafka/pull/20180#issuecomment-3151258216 Gentle reminder @chia7712 TIA! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] MINOR: Cleanup Connect Module (3/n) [kafka]

2025-08-04 Thread via GitHub
sjhajharia commented on PR #20156: URL: https://github.com/apache/kafka/pull/20156#issuecomment-3151255283 Gentle reminder @chia7712 @m1a2st TIA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
srdo commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2251698418 ## build.gradle: ## @@ -72,6 +72,12 @@ ext { "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED" ) + if (JavaVersion.current().isCompatibleWith(J

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
srdo commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2251698418 ## build.gradle: ## @@ -72,6 +72,12 @@ ext { "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED" ) + if (JavaVersion.current().isCompatibleWith(J

[PR] KAFKA-19574: Improve producer and consumer config files [kafka]

2025-08-04 Thread via GitHub
fvaleri opened a new pull request, #20302: URL: https://github.com/apache/kafka/pull/20302 This is an attempt at improving the client configuration files. We now have sections and comments similar to the other properties files. -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-19574: Improve producer and consumer config files [kafka]

2025-08-04 Thread via GitHub
fvaleri commented on PR #20302: URL: https://github.com/apache/kafka/pull/20302#issuecomment-3151000604 @showuon fyi. Let me know if you want to add or remove anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Commented] (KAFKA-19577) Allow to configure custom `ReplicaPlacer` implementation

2025-08-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011893#comment-18011893 ] Chia-Ping Tsai commented on KAFKA-19577: That might be a bit workaround, but it

Re: [PR] KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-08-04 Thread via GitHub
aliehsaeedii commented on PR #20244: URL: https://github.com/apache/kafka/pull/20244#issuecomment-3150901770 Thanks, @lucliu1108, for the PR. I added a couple of comments/suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (KAFKA-19577) Allow to configure custom `ReplicaPlacer` implementation

2025-08-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011891#comment-18011891 ] Chia-Ping Tsai commented on KAFKA-19577: We could make it pluggable by exposing

Re: [PR] KAFKA-19513: Flaky test: AclControlManagerTest.testDeleteExceedsMaxRecords() [kafka]

2025-08-04 Thread via GitHub
ryu001 commented on PR #20276: URL: https://github.com/apache/kafka/pull/20276#issuecomment-3150889124 Hi @DL1231 , thanks for checking. I think it would be difficult to reproduce this issue on local env, my assumption is because of the resource constraints on CI server. I checked seve

[jira] [Commented] (KAFKA-19577) Allow to configure custom `ReplicaPlacer` implementation

2025-08-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011888#comment-18011888 ] Mickael Maison commented on KAFKA-19577: it looks like https://cwiki.apache.org

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-04 Thread via GitHub
Rancho-7 commented on PR #20301: URL: https://github.com/apache/kafka/pull/20301#issuecomment-3150815090 The updated usage of the tool with argument parser: ``` (base) lansg:bin/ (KAFKA-19011✗) $ ./kafka-e2e-latency.sh --bootstrap-server localhost:9092 --topic test-topic --num-rec

[PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-04 Thread via GitHub
Rancho-7 opened a new pull request, #20301: URL: https://github.com/apache/kafka/pull/20301 jira: https://issues.apache.org/jira/browse/KAFKA-19011 This PR improves the usability and maintainability of the `kafka-e2e-latency.sh` tool: - Replaces fixed-index argument parsing wit

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2251556852 ## build.gradle: ## @@ -72,6 +72,12 @@ ext { "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED" ) + if (JavaVersion.current().isCompatibleWi

[jira] [Assigned] (KAFKA-19577) Allow to configure custom `ReplicaPlacer` implementation

2025-08-04 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-19577: --- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Allow to configure custom `ReplicaPlacer` implementation > -

[jira] [Created] (KAFKA-19577) Allow to configure custom `ReplicaPlacer` implementation

2025-08-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19577: -- Summary: Allow to configure custom `ReplicaPlacer` implementation Key: KAFKA-19577 URL: https://issues.apache.org/jira/browse/KAFKA-19577 Project: Kafka

[jira] [Updated] (KAFKA-19577) Allow to configure custom `ReplicaPlacer` implementation

2025-08-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19577: --- Labels: need-kip (was: ) > Allow to configure custom `ReplicaPlacer` implementation > -

Re: [PR] KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-08-04 Thread via GitHub
aliehsaeedii commented on code in PR #20244: URL: https://github.com/apache/kafka/pull/20244#discussion_r2251481198 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -4363,6 +4364,170 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

Re: [PR] KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-08-04 Thread via GitHub
aliehsaeedii commented on code in PR #20244: URL: https://github.com/apache/kafka/pull/20244#discussion_r2251478203 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -4363,6 +4364,170 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

Re: [PR] KAFKA-16913 - Support external schemas in JSONConverter [kafka]

2025-08-04 Thread via GitHub
mimaison commented on PR #19449: URL: https://github.com/apache/kafka/pull/19449#issuecomment-3150684942 @frankvicky @edoardocomar Do you have any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-08-04 Thread via GitHub
aliehsaeedii commented on code in PR #20244: URL: https://github.com/apache/kafka/pull/20244#discussion_r2251454216 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -4363,6 +4364,170 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
clolov commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3150439337 I am happy to cut a new release candidate for 4.0.1 including this change. As Mickael mentioned, I would treat this as a bug and include it as a bug fix 😊 -- This is an automated messag

[PR] KAFKA-16768: SocketServer leaks accepted SocketChannel instances due to race condition [kafka]

2025-08-04 Thread via GitHub
jack2012aa opened a new pull request, #20300: URL: https://github.com/apache/kafka/pull/20300 ## Description `Processor` and `Acceptor` in `SocketServer` may produce a race condition when a processor was closed but its acceptor assigns a socket channel to it. The channel will remain open

[jira] [Resolved] (KAFKA-19437) Review incidence of null metadata image in share coordinator

2025-08-04 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-19437. --- Resolution: Fixed > Review incidence of null metadata image in share coordinator > -

Re: [PR] MINOR: Add missing test coverage for OffsetFetchResponse.errorCounts() [kafka]

2025-08-04 Thread via GitHub
chia7712 merged PR #20263: URL: https://github.com/apache/kafka/pull/20263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Add missing test coverage for OffsetFetchResponse.errorCounts() [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20263: URL: https://github.com/apache/kafka/pull/20263#issuecomment-3149870256 there is already PR #20276 for the flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
srdo commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2250949063 ## .github/actions/run-gradle/action.yml: ## @@ -97,6 +97,8 @@ runs: -Pkafka.cluster.test.repeat=$TEST_REPEAT \ -Pkafka.test.verbose=$TEST_VERBOSE \

[jira] [Updated] (KAFKA-19576) Fix typo in state-change log filename after rotate

2025-08-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19576: --- Priority: Blocker (was: Minor) > Fix typo in state-change log filename after rotate > -

Re: [PR] KAFKA-19576 Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3149828651 open https://issues.apache.org/jira/browse/KAFKA-19576 for tracing. @jaredharley please take over the jira -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Created] (KAFKA-19576) Fix typo in state-change log filename after rotate

2025-08-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19576: -- Summary: Fix typo in state-change log filename after rotate Key: KAFKA-19576 URL: https://issues.apache.org/jira/browse/KAFKA-19576 Project: Kafka Issue

[jira] [Updated] (KAFKA-19576) Fix typo in state-change log filename after rotate

2025-08-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19576: --- Fix Version/s: 4.0.1 4.1.0 > Fix typo in state-change log filename after

Re: [PR] MINOR: Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3149821295 > notable changes in 4.0.0 to indicate the name has changed. sounds good. @jaredharley could you please also add a note [here](https://github.com/apache/kafka/blob/trunk/docs/upgra

[jira] [Assigned] (KAFKA-19532) Kafka request metric discrepancies

2025-08-04 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves India Limited reassigned KAFKA-19532: - Assignee: (was: Ksolves India Limited) > Kafka request metric discr

Re: [PR] MINOR: Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
showuon commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3149744382 Thanks @mimaison ! @jaredharley , could you help add a note [here](https://github.com/apache/kafka/blob/trunk/docs/upgrade.html#L54) to mention about this change? -- This is an auto

Re: [PR] MINOR: Upgrade Spotbugs to 4.9.1 [kafka]

2025-08-04 Thread via GitHub
srdo commented on code in PR #20294: URL: https://github.com/apache/kafka/pull/20294#discussion_r2250864440 ## gradle/spotbugs-exclude.xml: ## @@ -550,4 +550,173 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read + Review

Re: [PR] MINOR: Upgrade Spotbugs to 4.9.1 [kafka]

2025-08-04 Thread via GitHub
srdo commented on code in PR #20294: URL: https://github.com/apache/kafka/pull/20294#discussion_r2250866288 ## gradle/dependencies.gradle: ## @@ -123,7 +123,7 @@ versions += [ scoverage: "2.0.11", slf4j: "1.7.36", snappy: "1.1.10.7", - spotbugs: "4.8.6", + spotbugs: "

Re: [PR] MINOR: Fix typo in state-change log filename after rotate [kafka]

2025-08-04 Thread via GitHub
mimaison commented on PR #20269: URL: https://github.com/apache/kafka/pull/20269#issuecomment-3149712257 I think it's fine to merge this as this renaming was accidental and unwanted. However we should probably add a note in notable changes in 4.0.0 to indicate the name has changed. I

Re: [PR] MINOR: Run CI with Java 24 [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20295: URL: https://github.com/apache/kafka/pull/20295#discussion_r2250799163 ## .github/actions/run-gradle/action.yml: ## @@ -97,6 +97,8 @@ runs: -Pkafka.cluster.test.repeat=$TEST_REPEAT \ -Pkafka.test.verbose=$TEST_VERBOSE \

Re: [PR] MINOR: Replace boundPort with brokerBoundPort [kafka]

2025-08-04 Thread via GitHub
chia7712 merged PR #20297: URL: https://github.com/apache/kafka/pull/20297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18607) Update jfreechart dependency

2025-08-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18607. Fix Version/s: 4.2.0 Resolution: Fixed > Update jfreechart dependency > ---

Re: [PR] KAFKA-18607: Update jfreechart dependency [kafka]

2025-08-04 Thread via GitHub
mimaison merged PR #20264: URL: https://github.com/apache/kafka/pull/20264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Upgrade Spotbugs to 4.9.1 [kafka]

2025-08-04 Thread via GitHub
chia7712 commented on code in PR #20294: URL: https://github.com/apache/kafka/pull/20294#discussion_r2250792060 ## build.gradle: ## @@ -37,7 +37,7 @@ plugins { id 'org.nosphere.apache.rat' version "0.8.1" id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVers

[jira] [Assigned] (KAFKA-19575) Revisit gradle/spotbugs-exclude.xml

2025-08-04 Thread Chang Chi Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chang Chi Hsu reassigned KAFKA-19575: - Assignee: Chang Chi Hsu (was: Chia-Ping Tsai) > Revisit gradle/spotbugs-exclude.xml >

  1   2   >