[PR] KAFKA-19553: Add comprehensive unit tests for TemperatureDemo streams example [kafka]

2025-08-08 Thread via GitHub
shubhu15 opened a new pull request, #20330: URL: https://github.com/apache/kafka/pull/20330 This PR enhances test coverage for the Kafka Streams TemperatureDemo example by adding comprehensive unit tests using TopologyTestDriver. The tests validate that the temperature monitoring topology

Re: [PR] KAFKA-19537: Improve Exit Code Handling in StreamsGroupCommand [kafka]

2025-08-08 Thread via GitHub
github-actions[bot] commented on PR #20293: URL: https://github.com/apache/kafka/pull/20293#issuecomment-3169965221 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19571: Race condition between log segment flush and file deletion causing log dir to go offline [kafka]

2025-08-08 Thread via GitHub
github-actions[bot] commented on PR #20289: URL: https://github.com/apache/kafka/pull/20289#issuecomment-3169965265 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Clarification of topic configuration 'retention.bytes' [kafka]

2025-08-08 Thread via GitHub
github-actions[bot] commented on PR #19051: URL: https://github.com/apache/kafka/pull/19051#issuecomment-3169967281 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-13152: Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with "{statestore.cache}/{input.buffer}.max.bytes" [kafka]

2025-08-08 Thread via GitHub
github-actions[bot] commented on PR #20292: URL: https://github.com/apache/kafka/pull/20292#issuecomment-3169965243 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Feature/openj9 integration [kafka]

2025-08-08 Thread via GitHub
github-actions[bot] commented on PR #20197: URL: https://github.com/apache/kafka/pull/20197#issuecomment-3169965565 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19582 the current assignments shown by ReassignPartitionsCommand should include the log directories [kafka]

2025-08-08 Thread via GitHub
m1a2st commented on code in PR #20319: URL: https://github.com/apache/kafka/pull/20319#discussion_r2264166649 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -436,29 +437,50 @@ public void testGenerateAssignmentWithFewerBrokers() th

[PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-08 Thread via GitHub
shashankhs11 opened a new pull request, #20329: URL: https://github.com/apache/kafka/pull/20329 Updated Streams Configuration documentation to stay latest with version `4.0.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Comment Edited] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-08-08 Thread Shashank (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012934#comment-18012934 ] Shashank edited comment on KAFKA-15307 at 8/8/25 11:03 PM: --- Hi

[jira] [Commented] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-08-08 Thread Shashank (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012934#comment-18012934 ] Shashank commented on KAFKA-15307: -- Hi [~mjsax] , I picked up this PR since I did not h

[jira] [Assigned] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-08-08 Thread Shashank (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashank reassigned KAFKA-15307: Assignee: Shashank (was: Mahesh Sambaram) > Kafka Streams configuration docs outdated >

[jira] [Comment Edited] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-08-08 Thread Shashank (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012934#comment-18012934 ] Shashank edited comment on KAFKA-15307 at 8/8/25 11:03 PM: --- Hi

[PR] Metrics: use String.intern() to reduce duplicate metric names and tags [kafka]

2025-08-08 Thread via GitHub
stevenschlansker opened a new pull request, #20328: URL: https://github.com/apache/kafka/pull/20328 While diagnosing an out of memory condition, our profiler alerted us that tens of megabytes of our heap was used to store redundant String objects. In particular, the strings `thread_id

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-08-08 Thread via GitHub
chia7712 commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2263648458 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,689 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] KAFKA-19426: TopicBasedRemoteLogMetadataManager's initial should happen after the broker ready. [kafka]

2025-08-08 Thread via GitHub
Yunyung commented on PR #20203: URL: https://github.com/apache/kafka/pull/20203#issuecomment-3169213458 Thanks for the update. This looks good. Let's see if anyone else has any feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (KAFKA-19585) Avoid noisy NPE logs when closing consumer after constructor failures

2025-08-08 Thread Francis Godinho (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012915#comment-18012915 ] Francis Godinho commented on KAFKA-19585: - Hi [~lianetm], I'm new to contributin

Re: [PR] KAFKA-19582 the current assignments shown by ReassignPartitionsCommand should include the log directories [kafka]

2025-08-08 Thread via GitHub
Yunyung commented on code in PR #20319: URL: https://github.com/apache/kafka/pull/20319#discussion_r2262947299 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -922,14 +924,17 @@ private static void verifyBrokerIds(Admin adminClient,

Re: [PR] KAFKA-19582 the current assignments shown by ReassignPartitionsCommand should include the log directories [kafka]

2025-08-08 Thread via GitHub
Yunyung commented on code in PR #20319: URL: https://github.com/apache/kafka/pull/20319#discussion_r2263576388 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -436,29 +437,50 @@ public void testGenerateAssignmentWithFewerBrokers() t

Re: [PR] KAFKA-19591 solving issues with `gradlew` content: an old template version (i.e. file `unixStartScript.txt`) was being referenced [kafka]

2025-08-08 Thread via GitHub
dejan2609 commented on PR #20327: URL: https://github.com/apache/kafka/pull/20327#issuecomment-3168589355 Note: please pardon me for force-pushing (I had to fix commit message typo error). -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [Work in progress] [KAFKA-19174] Gradle version upgrade 8 -->> 9 [kafka]

2025-08-08 Thread via GitHub
dejan2609 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3168501977 Pending: I will also explain second problem (specific to Gradle 9, that is). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-19591 solving issues with `gradlew` content: an old template version (i.e. file `unixStartScript.txt` was being referenced) [kafka]

2025-08-08 Thread via GitHub
dejan2609 commented on PR #20327: URL: https://github.com/apache/kafka/pull/20327#issuecomment-3168493375 Pending: I will also explain another build problem (specific to Gradle 9, that is). -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-19591 solving issues with `gradlew` content: an old template version (i.e. file `unixStartScript.txt` was being referenced) [kafka]

2025-08-08 Thread via GitHub
dejan2609 commented on PR #20327: URL: https://github.com/apache/kafka/pull/20327#issuecomment-3168488025 Note: this PR is related to Gradle upgrade from 8 to 9: #19513 (they can be combined into one, but I prefer to keep them separated). Looping @chia7712 here (he was interested in Gradl

Re: [PR] [Work in progress] [KAFKA-19174] Gradle version upgrade 8 -->> 9 [kafka]

2025-08-08 Thread via GitHub
dejan2609 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3168442040 @chia7712 feel free to check this related PR: https://github.com/apache/kafka/pull/20327 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Updated] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19591: --- Description: {panel:bgColor=#ce} *_Prologue: Kafka developers can't commit jar's

[PR] KAFKA-19591 solving issues with `gradlew` content: an old template version (i.e. file `unixStartScript.txt` was being referenced) [kafka]

2025-08-08 Thread via GitHub
dejan2609 opened a new pull request, #20327: URL: https://github.com/apache/kafka/pull/20327 JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-19591 **_Intro:_** Groovy file unixStartScript.txt (that servers as a template for a gradlew) path/module was changed in Gradle version

[jira] [Updated] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19591: --- Description: {panel:title= _Kafka developers can't commit jar's into Gir repo (that

[jira] [Updated] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19591: --- Description: {panel:bgColor=#ce} _Kafka developers can't commit jar's into Gir r

[jira] [Updated] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19591: --- Description: {panel:bgColor=#ce} *_Prologue: Kafka developers can't commit jar's

[jira] [Updated] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19591: --- Description: {panel:bgColor=#ce} *_Prologue: Kafka developers can't commit jar's

[jira] [Updated] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19591: --- Description: {panel:bgColor=#ce} *_Prologue: Kafka developers can't commit jar's

[jira] [Updated] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19591: --- Description: {panel:title=Kafka developers can't commit jar's into Gir repo (that in

[jira] [Created] (KAFKA-19591) `gradlew` is referencing an old Groovy template version

2025-08-08 Thread Jira
Dejan Stojadinović created KAFKA-19591: -- Summary: `gradlew` is referencing an old Groovy template version Key: KAFKA-19591 URL: https://issues.apache.org/jira/browse/KAFKA-19591 Project: Kafka

Re: [PR] KAFKA-19078: Automatic controller addition to cluster metadata partition [kafka]

2025-08-08 Thread via GitHub
jsancio commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2263100630 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3271,13 +3317,57 @@ private long pollFollowerAsVoter(FollowerState state, long currentTimeMs)

Re: [PR] KAFKA-19567: Added the check for underlying partition being the leader in delayedShareFetch tryComplete method [kafka]

2025-08-08 Thread via GitHub
apoorvmittal10 commented on code in PR #20280: URL: https://github.com/apache/kafka/pull/20280#discussion_r2262923031 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -757,30 +766,37 @@ private void processRemoteFetchOrException( * Case a: The partiti

Re: [PR] KAFKA-19567: Added the check for underlying partition being the leader in delayedShareFetch tryComplete method [kafka]

2025-08-08 Thread via GitHub
chirag-wadhwa5 commented on code in PR #20280: URL: https://github.com/apache/kafka/pull/20280#discussion_r2262877509 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -765,7 +774,10 @@ private boolean maybeCompletePendingRemoteFetch() { for (Topi

Re: [PR] KAFKA-19567: Added the check for underlying partition being the leader in delayedShareFetch tryComplete method [kafka]

2025-08-08 Thread via GitHub
chirag-wadhwa5 commented on code in PR #20280: URL: https://github.com/apache/kafka/pull/20280#discussion_r2262861759 ## core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: ## @@ -1288,6 +1357,62 @@ public void testRemoteStorageFetchTryCompleteReturnsFalse() {

[PR] KAFKA-10357 Refactor makeReady to reduce complexity and support upcoming KIP-698 changes [kafka]

2025-08-08 Thread via GitHub
k-apol opened a new pull request, #20326: URL: https://github.com/apache/kafka/pull/20326 This PR reduces the cyclomatic complexity of the makeReady method by extracting parts of its logic into smaller, well-named helper methods. This structural cleanup makes the code easier to understa

[jira] [Updated] (KAFKA-19590) Have a way to set config to admin client only in TopicBasedRemoteLogMetadataManager

2025-08-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19590: --- Labels: need-kip (was: ) > Have a way to set config to admin client only in > TopicBasedRe

[jira] [Assigned] (KAFKA-19590) Have a way to set config to admin client only in TopicBasedRemoteLogMetadataManager

2025-08-08 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-19590: Assignee: Lan Ding > Have a way to set config to admin client only in > TopicBasedRemoteLogMetad

Re: [PR] MINOR: Remove SPAM URL in Streams Documentation [kafka]

2025-08-08 Thread via GitHub
mimaison merged PR #20321: URL: https://github.com/apache/kafka/pull/20321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19590) Have a way to set config to admin client only in TopicBasedRemoteLogMetadataManager

2025-08-08 Thread Luke Chen (Jira)
Luke Chen created KAFKA-19590: - Summary: Have a way to set config to admin client only in TopicBasedRemoteLogMetadataManager Key: KAFKA-19590 URL: https://issues.apache.org/jira/browse/KAFKA-19590 Project

Re: [PR] MINOR: Improve RLMM doc [kafka]

2025-08-08 Thread via GitHub
showuon commented on code in PR #20306: URL: https://github.com/apache/kafka/pull/20306#discussion_r2262400531 ## docs/configuration.html: ## @@ -329,8 +329,23 @@ 3.11 Tiered Storage Configs Below is the Tiered Storage configuration. + + 3.11.1 RLMM Configs + Below is

Re: [PR] MINOR: Improve RLMM doc [kafka]

2025-08-08 Thread via GitHub
showuon commented on code in PR #20306: URL: https://github.com/apache/kafka/pull/20306#discussion_r2262397463 ## docs/configuration.html: ## @@ -329,8 +329,23 @@ 3.11 Tiered Storage Configs Below is the Tiered Storage configuration. + + 3.11.1 RLMM Configs + Below is

Re: [PR] MINOR: Improve RLMM doc [kafka]

2025-08-08 Thread via GitHub
chia7712 commented on code in PR #20306: URL: https://github.com/apache/kafka/pull/20306#discussion_r2262298636 ## docs/configuration.html: ## @@ -329,8 +329,23 @@ 3.11 Tiered Storage Configs Below is the Tiered Storage configuration. + + 3.11.1 RLMM Configs + Below is

Re: [PR] KAFKA-16913 - Support external schemas in JSONConverter [kafka]

2025-08-08 Thread via GitHub
chia7712 commented on code in PR #19449: URL: https://github.com/apache/kafka/pull/19449#discussion_r2262325640 ## connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java: ## @@ -340,13 +351,16 @@ public SchemaAndValue toConnectData(String topic, byte[] valu

Re: [PR] KAFKA-16913 - Support external schemas in JSONConverter [kafka]

2025-08-08 Thread via GitHub
chia7712 commented on code in PR #19449: URL: https://github.com/apache/kafka/pull/19449#discussion_r2262327689 ## connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java: ## @@ -340,13 +351,16 @@ public SchemaAndValue toConnectData(String topic, byte[] valu

Re: [PR] MINOR: Improve RLMM doc [kafka]

2025-08-08 Thread via GitHub
chia7712 merged PR #20306: URL: https://github.com/apache/kafka/pull/20306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] PoC: Add `rewrite` support for `RemoveUnusedImports` [kafka]

2025-08-08 Thread via GitHub
Pankraz76 commented on PR #20314: URL: https://github.com/apache/kafka/pull/20314#issuecomment-3166878447 kindly request some feedback on enabler @ravikalla -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [Work in progress] [KAFKA-19174] Gradle version upgrade 8 -->> 9 [kafka]

2025-08-08 Thread via GitHub
chia7712 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3166859319 @dejan2609 thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.