[
https://issues.apache.org/jira/browse/KAFKA-19652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018722#comment-18018722
]
Ritvik Gupta edited comment on KAFKA-19652 at 9/8/25 5:40 AM:
jack2012aa commented on code in PR #20461:
URL: https://github.com/apache/kafka/pull/20461#discussion_r2329119008
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3108,34 +3109,52 @@ public DescribeLogDirsRequest.Builder createRequest(int
ti
[
https://issues.apache.org/jira/browse/KAFKA-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018724#comment-18018724
]
Chang-Yu Huang commented on KAFKA-9825:
---
Hello [~dulvinw], are you still working fo
[
https://issues.apache.org/jira/browse/KAFKA-19652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018722#comment-18018722
]
Ritvik Gupta edited comment on KAFKA-19652 at 9/8/25 4:21 AM:
[
https://issues.apache.org/jira/browse/KAFKA-19652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018722#comment-18018722
]
Ritvik Gupta commented on KAFKA-19652:
--
Hi,
Updating here on behalf of [~gargsha]
github-actions[bot] commented on PR #19926:
URL: https://github.com/apache/kafka/pull/19926#issuecomment-3264474943
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #19882:
URL: https://github.com/apache/kafka/pull/19882#issuecomment-3264474873
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #20292:
URL: https://github.com/apache/kafka/pull/20292#issuecomment-3264447900
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20254:
URL: https://github.com/apache/kafka/pull/20254#issuecomment-3264447960
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20362:
URL: https://github.com/apache/kafka/pull/20362#issuecomment-3264447808
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19870:
URL: https://github.com/apache/kafka/pull/19870#issuecomment-3264448211
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
tanvp112 commented on PR #11326:
URL: https://github.com/apache/kafka/pull/11326#issuecomment-3264431866
@chia7712 [KAFKA-17632](https://issues.apache.org/jira/browse/KAFKA-17632)
is not on the 3.9 release note. The 3.9.1 image was built ~4 months ago. Are we
expecting 3.9.2 for this fix an
shashankhs11 commented on code in PR #20501:
URL: https://github.com/apache/kafka/pull/20501#discussion_r2328919512
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1853,14 +1812,20 @@ public void
shouldReleaseLockForUnassignedT
DL1231 opened a new pull request, #20502:
URL: https://github.com/apache/kafka/pull/20502
Add the explanation of `null` for DeleteAclsRequest#ResourceNameFilter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
yunchipang commented on code in PR #20497:
URL: https://github.com/apache/kafka/pull/20497#discussion_r2328964104
##
.github/scripts/requirements.txt:
##
@@ -14,4 +14,4 @@
# limitations under the License.
PyYAML~=6.0
pytz==2024.2
-requests==2.32.3
+requests==2.32.4
Review Co
Toshiki Murakami created KAFKA-19685:
Summary: Revoked partitions are included in currentOffsets passed
to preCommit on task stop
Key: KAFKA-19685
URL: https://issues.apache.org/jira/browse/KAFKA-19685
chia7712 commented on PR #20446:
URL: https://github.com/apache/kafka/pull/20446#issuecomment-3264160374
It seems the word `maxBatchSize` is still used in code case. Should we align
them in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
shashankhs11 commented on code in PR #20501:
URL: https://github.com/apache/kafka/pull/20501#discussion_r2328920064
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1911,14 +1876,14 @@ public void
shouldComputeOffsetSumForRestor
shashankhs11 opened a new pull request, #20501:
URL: https://github.com/apache/kafka/pull/20501
This is the first part of cleaning up of the tests in `TaskManagerTest`
- Removed dead tests
- Added new tests as suggested earlier
--
This is an automated message from the Apache Git Serv
chia7712 commented on PR #17930:
URL: https://github.com/apache/kafka/pull/17930#issuecomment-3264170073
the flaky is traced by https://issues.apache.org/jira/browse/KAFKA-14533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-19475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19475.
Resolution: Invalid
we need the writelock to update both `overriddenQuotas` and `quota` to
chia7712 merged PR #20180:
URL: https://github.com/apache/kafka/pull/20180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #20461:
URL: https://github.com/apache/kafka/pull/20461#discussion_r2328877321
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3108,34 +3109,52 @@ public DescribeLogDirsRequest.Builder createRequest(int
time
[
https://issues.apache.org/jira/browse/KAFKA-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
majialong reassigned KAFKA-19684:
-
Assignee: majialong (was: Chia-Ping Tsai)
> Move Gauge#value to MetricValueProvider
>
chia7712 commented on code in PR #20334:
URL: https://github.com/apache/kafka/pull/20334#discussion_r2328874446
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -1906,16 +1906,29 @@ private int deleteSegments(List deletable,
SegmentDeletion
[
https://issues.apache.org/jira/browse/KAFKA-19683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018691#comment-18018691
]
Shashank commented on KAFKA-19683:
--
Hi [~lucasbru], since the tests in the cleanup of t
jack2012aa commented on code in PR #20461:
URL: https://github.com/apache/kafka/pull/20461#discussion_r2328869514
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3108,34 +3109,52 @@ public DescribeLogDirsRequest.Builder createRequest(int
ti
[
https://issues.apache.org/jira/browse/KAFKA-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018690#comment-18018690
]
Chia-Ping Tsai commented on KAFKA-19684:
we may need to keep the method in `Guav
[
https://issues.apache.org/jira/browse/KAFKA-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018689#comment-18018689
]
Chia-Ping Tsai commented on KAFKA-19684:
the main benefit is to remove the type
Chia-Ping Tsai created KAFKA-19684:
--
Summary: Move Gauge#value to MetricValueProvider
Key: KAFKA-19684
URL: https://issues.apache.org/jira/browse/KAFKA-19684
Project: Kafka
Issue Type: Impro
[
https://issues.apache.org/jira/browse/KAFKA-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-19684:
---
Labels: need-kip (was: )
> Move Gauge#value to MetricValueProvider
> --
chia7712 commented on code in PR #20461:
URL: https://github.com/apache/kafka/pull/20461#discussion_r2328841515
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3108,34 +3109,52 @@ public DescribeLogDirsRequest.Builder createRequest(int
time
chia7712 commented on PR #20496:
URL: https://github.com/apache/kafka/pull/20496#issuecomment-3263994584
```
Gradle Test Run :core:test > Gradle Test Executor 33 >
PlaintextAdminIntegrationTest > testListGroups() FAILED
org.opentest4j.AssertionFailedError: expected: but was:
chia7712 commented on code in PR #20497:
URL: https://github.com/apache/kafka/pull/20497#discussion_r2328799629
##
.github/scripts/requirements.txt:
##
@@ -14,4 +14,4 @@
# limitations under the License.
PyYAML~=6.0
pytz==2024.2
-requests==2.32.3
+requests==2.32.4
Review Comm
dependabot[bot] commented on PR #20473:
URL: https://github.com/apache/kafka/pull/20473#issuecomment-3263964066
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
chia7712 closed pull request #20473: Bump requests from 2.32.3 to 2.32.4 in
/.github/scripts
URL: https://github.com/apache/kafka/pull/20473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
chia7712 commented on PR #20497:
URL: https://github.com/apache/kafka/pull/20497#issuecomment-3263963489
@yunchipang could you please address this comment
https://github.com/apache/kafka/pull/19940/files#r2328677238 ?
--
This is an automated message from the Apache Git Service.
To respond
jim0987795064 opened a new pull request, #20500:
URL: https://github.com/apache/kafka/pull/20500
- **Changes:** each append writes a new MemoryRecords batch instead of
reusing a single batch object.
- **Reasons:** If we reuse the same batch, its baseoffset will keep
accumulating.
--
T
AndrewJSchofield commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2321188973
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.
[
https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018673#comment-18018673
]
ally heev commented on KAFKA-19672:
---
It might be possible that printWindow is called a
[
https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018671#comment-18018671
]
ally heev commented on KAFKA-19672:
---
> I think the main reason is that this is a perfo
Yunyung commented on PR #20473:
URL: https://github.com/apache/kafka/pull/20473#issuecomment-3263894286
Duplicate of https://github.com/apache/kafka/pull/20497.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
chia7712 merged PR #20451:
URL: https://github.com/apache/kafka/pull/20451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lkokhreidze closed pull request #20488: [MINOR] Fix typo in the ConsoleConsumer
cli tool for the headers.separator
URL: https://github.com/apache/kafka/pull/20488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
lianetm merged PR #19980:
URL: https://github.com/apache/kafka/pull/19980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
github-actions[bot] commented on PR #19397:
URL: https://github.com/apache/kafka/pull/19397#issuecomment-3260306909
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
[
https://issues.apache.org/jira/browse/KAFKA-19666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashank updated KAFKA-19666:
-
Description:
This is the first step in the parent task: To clean up all the integration
tests related t
[
https://issues.apache.org/jira/browse/KAFKA-19683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashank updated KAFKA-19683:
-
Description: See
https://github.com/apache/kafka/pull/20392#issuecomment-3241457533
> Clean up TaskMana
Shashank created KAFKA-19683:
Summary: Clean up TaskManagerTest
Key: KAFKA-19683
URL: https://issues.apache.org/jira/browse/KAFKA-19683
Project: Kafka
Issue Type: Sub-task
Components: s
[
https://issues.apache.org/jira/browse/KAFKA-19666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashank updated KAFKA-19666:
-
Reviewer: Lucas Brutschy
> Clean up integration tests related to state-updater
> ---
aheev commented on code in PR #20385:
URL: https://github.com/apache/kafka/pull/20385#discussion_r2328743775
##
tests/kafkatest/services/performance/share_consumer_performance.py:
##
@@ -100,7 +100,7 @@ def start_cmd(self, node):
for key, value in self.args().items():
aheev commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3263872229
@Yunyung _ConsumerPerformanceService_ and _ShareConsumerPerformanceService_
are used in `benchmark_test.py`(which uses DEV_BRANCH and
`test_performance_services.py`(which uses LATEST_2_1 an
lkokhreidze opened a new pull request, #20488:
URL: https://github.com/apache/kafka/pull/20488
[MINOR] Fix typo in the ConsoleConsumer cli tool for the headers.separator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ShivsundarR commented on code in PR #20283:
URL: https://github.com/apache/kafka/pull/20283#discussion_r2321249906
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##
@@ -1116,19 +1116,23 @@ private boolean processBackgroundEvents() {
ShivsundarR opened a new pull request, #20474:
URL: https://github.com/apache/kafka/pull/20474
*What*
- Currently in `ShareConsumerImpl`, we were not resetting
`background-event-queue-size` metric to 0 after draining the events from the
queue.
- This PR fixes it by using `Backgro
github-actions[bot] commented on PR #19921:
URL: https://github.com/apache/kafka/pull/19921#issuecomment-3260306954
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
AndrewJSchofield commented on PR #20324:
URL: https://github.com/apache/kafka/pull/20324#issuecomment-3257648976
> I'd like to realign the core conversation to the approach in this PR (and
#20363) which is the elimination of `addAndGet()` on the common path. The
performance bottleneck in `A
appchemist commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2328740679
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1313,6 +1301,7 @@ public KStream process(
processNode.setV
appchemist commented on PR #18800:
URL: https://github.com/apache/kafka/pull/18800#issuecomment-3263864453
Since the existing commit had conflicts when rebasing onto the latest trunk,
I created a new commit instead.
--
This is an automated message from the Apache Git Service.
To respond t
AndrewJSchofield merged PR #20490:
URL: https://github.com/apache/kafka/pull/20490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
mimaison commented on PR #17609:
URL: https://github.com/apache/kafka/pull/17609#issuecomment-3258227374
This does not move ReplicationQuotaManager, ClientRequestQuotaManager and
QuotaFactory to the server module. These classes are still in core, they were
just rewritten in Java.
We
appchemist commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2328735171
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java:
##
@@ -93,6 +99,23 @@ public String nodeName() {
return nodeName;
appchemist commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2328738608
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java:
##
@@ -20,19 +20,25 @@
import org.apache.kafka.streams.processor.interna
elmoctarebnou commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2328737784
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -69,6 +69,11 @@ public class GroupCoordinatorConfig {
[
https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 reassigned KAFKA-19672:
---
Assignee: (was: 黃竣陽)
> Producer performance test failing in parsing aggregate statistics
>
mimaison commented on PR #19912:
URL: https://github.com/apache/kafka/pull/19912#issuecomment-3258330228
Absolutely not! The KIP has to be voted first.
If you want to introduce an API change, it's your job convincing maintainers
to vote on your KIP. Only after the vote has passed (see
appchemist commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2321804961
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1306,7 +1306,12 @@ public KStream process(
final ProcessorToSt
lianetm commented on PR #20472:
URL: https://github.com/apache/kafka/pull/20472#issuecomment-3258430275
Thank you all for the reviews. Comments addressed adding missing exceptions
to the KafkaConsumer (and checked the ShareKafkaConsumer has them already
consistently).
--
This is an auto
[
https://issues.apache.org/jira/browse/KAFKA-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 reassigned KAFKA-19672:
---
Assignee: 黃竣陽
> Producer performance test failing in parsing aggregate statistics
> ---
edoardocomar commented on PR #20485:
URL: https://github.com/apache/kafka/pull/20485#issuecomment-3257883002
I think it makes sense to backport to 4.0.1 and 4.1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AndrewJSchofield commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3258847490
@aheev I would merge latest changes into this branch. I find the test fails
on your branch, and passes on trunk. I can't see that this PR would cause the
tests to fail, so I'd up
chia7712 merged PR #20334:
URL: https://github.com/apache/kafka/pull/20334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ksolves India Limited resolved KAFKA-14085.
---
Resolution: Fixed
> Clean up usage of asserts in KafkaProducer
> ---
shashankhs11 opened a new pull request, #20499:
URL: https://github.com/apache/kafka/pull/20499
clean up `EosIntegrationTest.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
chia7712 merged PR #20429:
URL: https://github.com/apache/kafka/pull/20429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Chia-Ping Tsai created KAFKA-19676:
--
Summary: EpochState should override close to avoid throwing
IOException
Key: KAFKA-19676
URL: https://issues.apache.org/jira/browse/KAFKA-19676
Project: Kafka
mimaison commented on code in PR #19940:
URL: https://github.com/apache/kafka/pull/19940#discussion_r2328677238
##
tests/setup.py:
##
@@ -48,7 +48,7 @@ def run(self):
license="apache2.0",
packages=find_packages(),
include_package_data=True,
- install_re
黃竣陽 created KAFKA-19681:
---
Summary: Optimize MetadataShell tool find command print warning
message intead of throwing exception
Key: KAFKA-19681
URL: https://issues.apache.org/jira/browse/KAFKA-19681
Project: Ka
chia7712 commented on PR #20495:
URL: https://github.com/apache/kafka/pull/20495#issuecomment-3262440333
the flaky is traced by https://issues.apache.org/jira/browse/KAFKA-14533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dejan2609 commented on PR #19513:
URL: https://github.com/apache/kafka/pull/19513#issuecomment-3263579498
Thank you for a review @chia7712.
Good points, will address them ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
80 matches
Mail list logo
