[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-11-02 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r741279732 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -474,9 +479,24 @@ public boolean

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-11-02 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r740365960 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-11-02 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r741279732 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -474,9 +479,24 @@ public boolean

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-11-02 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r741279732 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -474,9 +479,24 @@ public boolean

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-11-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r740365960 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-27 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r737632973 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-27 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r737632973 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-13 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r728049488 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -250,6 +248,9 @@ public void execute() {

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-13 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r728086626 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -378,7 +370,7 @@ private boolean sendRecords()

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-13 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r728049488 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -250,6 +248,9 @@ public void execute() {

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-11 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r726485900 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SubmittedRecordsTest.java ## @@ -0,0 +1,213 @@ +/* + * Licensed to the

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-11 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r726483980 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -495,56 +471,25 @@ public boolean

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-11 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r726483477 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -495,56 +471,25 @@ public boolean

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-11 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r726480832 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -246,6 +240,7 @@ public void execute() {

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-11 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r726477234 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-11 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r726477234 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720433703 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720419911 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720416578 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720395810 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -570,22 +512,21 @@ public boolean

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720389261 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -291,6 +286,13 @@ private void

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720384889 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720384099 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SubmittedRecordsTest.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to the

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720382154 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11323: KAFKA-12226: Commit source task offsets without blocking on batch delivery

2021-10-01 Thread GitBox
C0urante commented on a change in pull request #11323: URL: https://github.com/apache/kafka/pull/11323#discussion_r720382154 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache