[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-09 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r894111285 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,522 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-07 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r891907113 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-07 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r891901602 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-06 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r890754969 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-02 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r888026555 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTransactionContext.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-02 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r888026291 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -576,88 +672,42 @@ public boolean startTask( executor.submit(workerT

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-05-31 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r885745316 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1000,6 +1090,266 @@ WorkerMetricsGroup workerMetricsGroup() { return work

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-05-17 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r874800848 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1000,6 +1090,266 @@ WorkerMetricsGroup workerMetricsGroup() { return work

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-05-17 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r874762106 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -576,88 +672,42 @@ public boolean startTask( executor.submit(workerT

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-05-17 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r874759802 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -271,8 +278,10 @@ void doShutdown() { state = State.FAILED;

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-05-17 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r874754965 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -229,4 +229,4 @@ private void expectStore(Map key, byte[] keySeri

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-05-17 Thread GitBox
C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r874752916 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1000,6 +1090,266 @@ WorkerMetricsGroup workerMetricsGroup() { return work