[GitHub] [kafka] C0urante commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-02-15 Thread via GitHub
C0urante commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1107747315 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -389,22 +389,27 @@ public void logUnused() { private T

[GitHub] [kafka] C0urante commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-31 Thread via GitHub
C0urante commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1092632585 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -414,34 +414,51 @@ private T getConfiguredInstance(Object klass, Class t, Map T

[GitHub] [kafka] C0urante commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-31 Thread via GitHub
C0urante commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1092133488 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +479,22 @@ public List getConfiguredInstances(List classNames, Class t, M

[GitHub] [kafka] C0urante commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-30 Thread via GitHub
C0urante commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091084063 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M