[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175063429 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +58,170 @@ public void testOffsetTranslation() {

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1176509940 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +57,96 @@ public void testOffsetTranslation() { /

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175123889 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1174698662 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -25,17 +25,46 @@ import org.apache.kafka.common.utils.Utils; import org.a

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1151130958 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +58,120 @@ public void testOffsetTranslation() {

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1151128638 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -25,17 +25,37 @@ import org.apache.kafka.common.utils.Utils; import org.a

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1151128638 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -25,17 +25,37 @@ import org.apache.kafka.common.utils.Utils; import org.a

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1151124889 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1149500829 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -25,17 +25,37 @@ import org.apache.kafka.common.utils.Utils; import org.a