C0urante commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1290641476
########## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ########## @@ -43,6 +47,11 @@ public void configure(Map<String, ?> props) { log.info("Using custom remote topic separator: '{}'", separator); separatorPattern = Pattern.compile(Pattern.quote(separator)); } + + if (props.containsKey(INTERNAL_TOPIC_SEPARATOR_ENABLED_CONFIG)) { + log.info("Disable the usage of topic separator for internal topics"); Review Comment: I think the first part of this still needs to be addressed? Specifically, we should only emit the log statement if `isInternalTopicSeparatorEnabled` is `false`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org