[GitHub] [kafka] C0urante commented on pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-17 Thread GitBox
C0urante commented on PR #11781: URL: https://github.com/apache/kafka/pull/11781#issuecomment-1159226471 I've completed the remaining follow-up tasks. ### Audit of resource allocation and cleanup: - Documented ownership expectations more clearly with the `KafkaBasedLog` and `KafkaOffse

[GitHub] [kafka] C0urante commented on pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-16 Thread GitBox
C0urante commented on PR #11781: URL: https://github.com/apache/kafka/pull/11781#issuecomment-1158413497 Pushed the next draft which should fix the offset store startup bug and address outstanding review comments. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] C0urante commented on pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-15 Thread GitBox
C0urante commented on PR #11781: URL: https://github.com/apache/kafka/pull/11781#issuecomment-1157162231 Hey guys--thanks for the reviews, really appreciate the rapid responses here. I found a bug that's been a bit trickier to solve than expected and have had little time to work on it this

[GitHub] [kafka] C0urante commented on pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-10 Thread GitBox
C0urante commented on PR #11781: URL: https://github.com/apache/kafka/pull/11781#issuecomment-1152573511 Given that all merge conflicts have been resolved and https://github.com/apache/kafka/pull/11780 has already been approved, marking this as ready for review. -- This is an automated m

[GitHub] [kafka] C0urante commented on pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-02-17 Thread GitBox
C0urante commented on pull request #11781: URL: https://github.com/apache/kafka/pull/11781#issuecomment-1043995270 Converting to draft until upstream PRs are reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t