C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1579153067
Closing due to lack of interest; we can revisit this if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1299089574
I've updated the PR to not use a custom `SecurityManager`, and drop support
for catching direct calls to `System::exit`.
@divijvaidya @ijuma If you have time, let me know what you
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1297554373
@ijuma Sorry for the delay.
The tradeoff involved is whether we want to account for direct calls to
`System::exit` or not. If we're confident enough in our review process to catch
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1273689767
@ijuma It's partially that we sometimes have direct calls to `System::exit`
(although it's rare that these would make it past review), and partially that
we wouldn't have a way to automa
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1256672973
@showuon I've added some tests for the custom extension that should
demonstrate its effectiveness.
I should note that I also experimented with an approach that leveraged JUnit
5's
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1253949072
@divijvaidya Thank you for your thoughts. I don't quite agree that
attempting to terminate the JVM is a symptom rather than the root cause, since
there are cases where these attempts occ
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1253948953
@showuon Thanks for taking a look. I did some local testing by injecting
calls to `System::exit` into existing unit tests, both on the actual test
thread and on separate threads with a l
