[GitHub] [kafka] C0urante commented on pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

2023-01-30 Thread via GitHub
C0urante commented on PR #13148: URL: https://github.com/apache/kafka/pull/13148#issuecomment-1409001897 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] C0urante commented on pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

2023-01-30 Thread via GitHub
C0urante commented on PR #13148: URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408822680 @mimaison Yeah, that's correct. I'm hoping that the `verify` calls for `plugins::withClassLoader` will be sufficient for now. I've also added a small comment explaining why we perform th