[GitHub] [kafka] C0urante commented on pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

2023-03-29 Thread via GitHub
C0urante commented on PR #13433: URL: https://github.com/apache/kafka/pull/13433#issuecomment-1489363243 Thanks @gharris1727 and @urbandan for the review. I've tried to address all outstanding comments in my latest commit (including even the "wildly impractical" use case that I previously w

[GitHub] [kafka] C0urante commented on pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

2023-03-21 Thread via GitHub
C0urante commented on PR #13433: URL: https://github.com/apache/kafka/pull/13433#issuecomment-1478577830 cc @urbandan; I've tweaked this a bit (stopped tracking equivalent schemas while comparing default values since that was actually doing nothing and AFAICT is unnecessary, and copied the