C0urante commented on PR #14044: URL: https://github.com/apache/kafka/pull/14044#issuecomment-1642230322
The change from `private` to `protected` technically counts as a change to public interface, so we'd need a KIP for that. I'm also a little hesitant to upgrade the visibility of these members regardless since that would limit the compatibility of plugins that rely on them (most likely by subclassing `ConnectRecord`, `SinkRecord`, etc.), since that would render them [binary incompatible](https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.7) with older versions of Connect where the fields were still private. Can we reduce the scope here to use fields instead of methods wherever possible, but without altering the visibility of any parts of our public API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
