[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-14 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1677247712 Final note: I've filed [KAFKA-15342](https://issues.apache.org/jira/browse/KAFKA-15342) as a reminder to revert this change if we're able to upgrade to a version of Mockito that

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-13 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1676418306 Phew! The latest CI build completed with none of those failures. The `DynamicBrokerReconfiguration::testThreadPoolResize` test case continued to fail across both builds, but this test

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-13 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1676387751 After merging to trunk, the [next CI build](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka/detail/trunk/2096/tests) contained a high number of failures caused by

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-12 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1676095630 Thanks Divij! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674202980 @divijvaidya given that this touches on the strict stubbing feature that you've helped introduce to our tests, would you be interested in reviewing? @mumrah @ijuma based on

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674193833 As we can see with the [CI results for the first build](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14186/1/tests), unused stubbings were

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1673671924 I've opened this as a draft request to demonstrate that unused stubbings will be successfully reported with the proposed change to the Jenkinsfile. Once the build fails successfully