[GitHub] [kafka] C0urante commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-09-07 Thread via GitHub
C0urante commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1710880812 Ah, that makes more sense. Yeah, I've seen some of those too, would be nice to patch them. Thanks for your help on this one @philipnee! -- This is an automated message from the Apache

[GitHub] [kafka] C0urante commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-09-07 Thread via GitHub
C0urante commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1710250787 @philipnee I'm curious about the other tests as well. From what I could tell, the distinguishing factor is the use of a `MockTime` instance that has a non-zero auto-tick, in conjunction

[GitHub] [kafka] C0urante commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-09-05 Thread via GitHub
C0urante commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1707161908 @philipnee Let me know if you're still looking into this. Happy to wait on your analysis if you are, and if not, we can merge as-is. -- This is an automated message from the Apache Git

[GitHub] [kafka] C0urante commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-08-31 Thread via GitHub
C0urante commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1701836291 @philipnee If it helps, this test only fails for me about one out of every three runs, and only when running the entire suite of unit tests for `:connect:runtime`--I've never seen it fai

[GitHub] [kafka] C0urante commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-08-30 Thread via GitHub
C0urante commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1699632378 @philipnee I did my best to research the context here diligently, but I may be missing something (this is a bit outside my wheelhouse). If you have a moment, would you be willing to take