[GitHub] [kafka] C0urante commented on pull request #9826: KAFKA-10816: Initialize REST endpoints only after the herder has started

2021-04-10 Thread GitBox
C0urante commented on pull request #9826: URL: https://github.com/apache/kafka/pull/9826#issuecomment-817236934 I've taken a slightly different approach in https://github.com/apache/kafka/pull/10520, which modifies the root resource to be viable as both a startup and a readiness probe.

[GitHub] [kafka] C0urante commented on pull request #9826: KAFKA-10816: Initialize REST endpoints only after the herder has started

2021-04-06 Thread GitBox
C0urante commented on pull request #9826: URL: https://github.com/apache/kafka/pull/9826#issuecomment-814294461 @tombentley any plans to revisit this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] C0urante commented on pull request #9826: KAFKA-10816: Initialize REST endpoints only after the herder has started

2021-03-04 Thread GitBox
C0urante commented on pull request #9826: URL: https://github.com/apache/kafka/pull/9826#issuecomment-790751172 Thanks for taking this on, Tom! This seems fairly involved and I'm wondering if there's a simpler solution. The changes here cause `DistributedHerder::start` to block on