[GitHub] [kafka] DL1231 commented on a diff in pull request #13969: KAFKA-15154: Acquire lock when reading checkQuotas

2023-07-14 Thread via GitHub
DL1231 commented on code in PR #13969: URL: https://github.com/apache/kafka/pull/13969#discussion_r1263954988 ## clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java: ## @@ -366,4 +368,60 @@ public void testUpdatingMetricConfigIsReflectedInTheSensor() {

[GitHub] [kafka] DL1231 commented on a diff in pull request #13969: KAFKA-15154: Acquire lock when reading checkQuotas

2023-07-08 Thread via GitHub
DL1231 commented on code in PR #13969: URL: https://github.com/apache/kafka/pull/13969#discussion_r1257413847 ## clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java: ## @@ -250,7 +250,16 @@ public void checkQuotas() { checkQuotas(time.milliseconds());

[GitHub] [kafka] DL1231 commented on a diff in pull request #13969: KAFKA-15154: Acquire lock when reading checkQuotas

2023-07-08 Thread via GitHub
DL1231 commented on code in PR #13969: URL: https://github.com/apache/kafka/pull/13969#discussion_r1257413803 ## clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java: ## @@ -366,4 +368,60 @@ public void testUpdatingMetricConfigIsReflectedInTheSensor() {