[GitHub] [kafka] Gerrrr commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949398138 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java: ## @@ -38,8 +38,22 @@ public KP getPrimaryKey() { return pri

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949398138 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java: ## @@ -38,8 +38,22 @@ public KP getPrimaryKey() { return pri

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949396415 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionStoreReceiveProcessorSupplier.java: ## @@ -91,7 +91,7 @@ public void proces