[GitHub] [kafka] Gerrrr commented on pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on PR #12535: URL: https://github.com/apache/kafka/pull/12535#issuecomment-1219734073 I added an upgrade test back in https://github.com/apache/kafka/pull/12122. Unfortunately, it didn't catch these version check bugs. I am going to figure out why and improve the test. I'd

[GitHub] [kafka] Gerrrr commented on pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on PR #12535: URL: https://github.com/apache/kafka/pull/12535#issuecomment-1219722137 Test failure: ``` [2022-08-18T14:24:17.527Z] FetchRequestTestDowngrade > testTopicIdIsRemovedFromFetcherWhenControllerDowngrades() STARTED [2022-08-18T14:24:17.527Z] integrati

[GitHub] [kafka] Gerrrr commented on pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on PR #12535: URL: https://github.com/apache/kafka/pull/12535#issuecomment-1219496131 @vvcephei Can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi