[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-05-30 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1210141583 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-05-26 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1206778975 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-05-26 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1206702136 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-19 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-19 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-19 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-19 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-19 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1171099569 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-13 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-13 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-13 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-13 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-13 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-13 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165524375 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-11 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1162869801 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-05 Thread via GitHub
Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1158907492 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -291,24 +291,24 @@ private[group] class GroupCoordinatorAdapter( topics: util