[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

2021-04-27 Thread GitBox
JoelWee commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r621542393 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationTest.java ## @@ -151,6 +151,22 @@ public void shouldNotAllowToRes

[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

2021-04-27 Thread GitBox
JoelWee commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r621538528 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -205,6 +206,34 @@ private void add10InputE

[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

2021-04-27 Thread GitBox
JoelWee commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r621537903 ## File path: docs/streams/developer-guide/app-reset-tool.html ## @@ -78,6 +78,9 @@ Step 1: Run the application reset tool Invoke

[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

2020-08-12 Thread GitBox
JoelWee commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r469725796 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -646,22 +655,68 @@ private boolean isIntermediateTopic(final String topic) {

[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

2020-08-12 Thread GitBox
JoelWee commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r469722613 ## File path: docs/streams/developer-guide/app-reset-tool.html ## @@ -77,6 +77,7 @@ Step 1: Run the application reset tool