[GitHub] [kafka] KahnCheny commented on pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-06-01 Thread GitBox
KahnCheny commented on pull request #10746: URL: https://github.com/apache/kafka/pull/10746#issuecomment-852083759 merge trunk will be automatically updated, so I submit a new PR, Thanks for your and re-review ? https://github.com/apache/kafka/pull/10801 Luke Chen ***@***.***>

[GitHub] [kafka] KahnCheny commented on pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-05-26 Thread GitBox
KahnCheny commented on pull request #10746: URL: https://github.com/apache/kafka/pull/10746#issuecomment-848777456 jenkins pr-merge passes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] KahnCheny commented on pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-05-24 Thread GitBox
KahnCheny commented on pull request #10746: URL: https://github.com/apache/kafka/pull/10746#issuecomment-847563816 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [kafka] KahnCheny commented on pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-05-24 Thread GitBox
KahnCheny commented on pull request #10746: URL: https://github.com/apache/kafka/pull/10746#issuecomment-847490202 > @KahnCheny , thanks for the PR. LGTM! Could you also remove the `public` keyword in `ConsumerInterceptor` ? Thank you. Of course. -- This is an automated message f