[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672: Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833158538 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -535,24 +539,24 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672: Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833158352 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -35,6 +35,7 @@ import org.apache.kafka.common.network.{ListenerName,

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672: Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833158112 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -201,8 +202,11 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672 Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833094619 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig: K

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672 Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833089404 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -535,8 +538,8 @@ class DynamicBrokerConfig(private val kafkaConfig: K

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672 Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig: K

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672 Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig: K

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672 Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig: K

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #11920: KAFKA-13672 Race condition in DynamicBrokerConfig

2022-03-23 Thread GitBox
LiamClarkeNZ commented on a change in pull request #11920: URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig: K