[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267948092 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-19 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1267948092 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-18 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1266864272 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-18 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1266864272 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-18 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1266864272 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-18 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1266864272 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-18 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1266864272 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme

[GitHub] [kafka] Nickstery commented on a diff in pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-18 Thread via GitHub
Nickstery commented on code in PR #14004: URL: https://github.com/apache/kafka/pull/14004#discussion_r1266864272 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java: ## @@ -100,17 +100,29 @@ void handleSegmentWithCopySegme