[GitHub] [kafka] OmniaGM commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

OmniaGM commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1294403336 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ## @@ -43,6 +47,11 @@ public void configure(Map props) {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

OmniaGM commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1294402558 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ## @@ -43,6 +47,11 @@ public void configure(Map props) {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

OmniaGM commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1288843685 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -406,7 +406,6 @@ public void

[GitHub] [kafka] OmniaGM commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

OmniaGM commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1288843344 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ## @@ -43,6 +47,11 @@ public void configure(Map props) {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

OmniaGM commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1288843014 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DefaultReplicationIntegrationTest.java: ## @@ -0,0 +1,324 @@ +/* Review Comment: I