[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2022-02-08 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-1033258042 @guozhangwang @showuon In fact, I ran ConsumerBounceTest.testClose() several times locally yesterday, and the testCase can all pass. I guess the jenkins

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-11-11 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-966737404 Hi @guozhangwang @showuon and @hachikuji can you help to promote this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-30 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-955202193 According to our previous discussion, I re-modified and submitted the code, local debugging, regular expression subscription consumption, deleting or creating a topic

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang ,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible. But I still suggest that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang ,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible. But I still suggest that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-20 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang ,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible. But I still suggest that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-20 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang ,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible. But I still suggest that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-20 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang ,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible. But I still suggest that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-20 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang ,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible. But I still suggest that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-20 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang ,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible. But I still suggest that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528 @guozhangwang Thank you for your reply 1. I agree that deleting the poll(long) method will make the code changes easier, but this cannot solve the root cause,

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413 @guozhangwang To add, I think it is necessary to automatically clean up non-existent offsets in the `onJoinPrepare` method We now agree that offsetCommitTimer

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413 @guozhangwang To add, I think it is necessary to automatically clean up non-existent offsets in the `onJoinPrepare` method We now agree that offsetCommitTimer

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413 @guozhangwang To add, I think it is necessary to automatically clean up non-existent offsets in the `onJoinPrepare` method We now agree that offsetCommitTimer

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413 @guozhangwang To add, I think it is necessary to automatically clean up non-existent offsets in the `onJoinPrepare` method We now agree that offsetCommitTimer

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-13 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413 @guozhangwang To add, I think it is necessary to automatically clean up non-existent offsets in the `onJoinPrepare` method We now agree that offsetCommitTimer