[GitHub] [kafka] ableegoldman commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

[GitBox]

ableegoldman commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586918859



##########
File path: build.gradle
##########
@@ -974,8 +974,8 @@ project(':core') {
     from(project(':streams:streams-scala').configurations.runtime) { 
into("libs/") }
     from(project(':streams:test-utils').jar) { into("libs/") }
     from(project(':streams:test-utils').configurations.runtime) { 
into("libs/") }
-    from(project(':streams:examples').jar) { into("libs/") }
-    from(project(':streams:examples').configurations.runtime) { into("libs/") }
+    from(project(':streams-examples').jar) { into("libs/") }
+    from(project(':streams-examples').configurations.runtime) { into("libs/") }

Review comment:
       Huh, maybe we're not even using `connect` in the examples to begin with 
(or at least, not anymore)? That actually doesn't sound too surprising, I've 
never seen Connect being used in any streams stuff I've looked at
   
   > That seems independent of whether it's a submodule or not
   
   @ijuma WDYM? If the examples are a submodule of `streams`, and the examples 
depend on `connect`, then doesn't that mean the `streams` module will pull in 
`connect`? Even if we may turn out not to depend on `connect` to begin with...)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org