[GitHub] [kafka] ableegoldman commented on a change in pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-29 Thread GitBox
ableegoldman commented on a change in pull request #10608: URL: https://github.com/apache/kafka/pull/10608#discussion_r623325017 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -152,28 +150,6 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10608: URL: https://github.com/apache/kafka/pull/10608#discussion_r622719786 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -431,7 +397,7 @@ private void cleanRemove

[GitHub] [kafka] ableegoldman commented on a change in pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10608: URL: https://github.com/apache/kafka/pull/10608#discussion_r622718411 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java ## @@ -315,7 +314,7 @@ public void shouldC

[GitHub] [kafka] ableegoldman commented on a change in pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10608: URL: https://github.com/apache/kafka/pull/10608#discussion_r622718411 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java ## @@ -315,7 +314,7 @@ public void shouldC