[GitHub] [kafka] ableegoldman commented on a change in pull request #10615: KAFKA-12648: basic skeleton API for NamedTopology

2021-04-30 Thread GitBox
ableegoldman commented on a change in pull request #10615: URL: https://github.com/apache/kafka/pull/10615#discussion_r624064155 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/StickyTaskAssignorTest.java ## @@ -166,12 +166,18 @@ pub

[GitHub] [kafka] ableegoldman commented on a change in pull request #10615: KAFKA-12648: basic skeleton API for NamedTopology

2021-04-30 Thread GitBox
ableegoldman commented on a change in pull request #10615: URL: https://github.com/apache/kafka/pull/10615#discussion_r624061208 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/NamedTopology.java ## @@ -0,0 +1,42 @@ +/* + * Licens

[GitHub] [kafka] ableegoldman commented on a change in pull request #10615: KAFKA-12648: basic skeleton API for NamedTopology

2021-04-29 Thread GitBox
ableegoldman commented on a change in pull request #10615: URL: https://github.com/apache/kafka/pull/10615#discussion_r623644367 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/StickyTaskAssignorTest.java ## @@ -166,12 +166,18 @@ pub

[GitHub] [kafka] ableegoldman commented on a change in pull request #10615: KAFKA-12648: basic skeleton API for NamedTopology

2021-04-29 Thread GitBox
ableegoldman commented on a change in pull request #10615: URL: https://github.com/apache/kafka/pull/10615#discussion_r623529336 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java ## @@ -64,50 +97,98 @@ public static TaskId parse(final String tas