[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-17 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441782286 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java ## @@ -133,6 +142,25 @@ public static Sensor

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-17 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441781498 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java ## @@ -133,6 +142,25 @@ public static Sensor

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441175266 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java ## @@ -366,6 +369,37 @@ public void shouldThrowO

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441172228 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -160,18 +162,21 @@ public void postCommit() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441171975 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -235,7 +235,7 @@ public StateStore ge

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441161523 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -675,27 +670,6 @@ public static