[GitHub] [kafka] ableegoldman commented on a change in pull request #9984: KAFKA-12247: add timeout and static group rebalance to remove thread

[GitBox]

ableegoldman commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r566478398



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -69,6 +73,7 @@
 import org.apache.kafka.streams.state.internals.QueryableStoreProvider;
 import 
org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter;
 import org.apache.kafka.streams.state.internals.StreamThreadStateStoreProvider;
+import org.apache.kafka.common.errors.TimeoutException;

Review comment:
       nit: put this import above with the others (IDE often misplaces these 
since we follow a weird import ordering in places)

##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -180,6 +182,31 @@ public void shouldRemoveStreamThread() throws Exception {
         }
     }
 
+    @Test
+    public void shouldRemoveStreamThreadWithStaticMembership() throws 
Exception {
+        properties.put("group.instance.id", "test");

Review comment:
       ```suggestion
           properties.put(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG, "member-A");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org