ableegoldman commented on pull request #11609: URL: https://github.com/apache/kafka/pull/11609#issuecomment-1018402412
Hey @guozhangwang , thanks for the initial review and sorry for the delay, I've been sitting on this PR while I worked on the tests but should have pushed the non-testing code in the meantime. Anyways I've pushed the final iteration on this, redid the overall approach a bit and think it makes a lot more sense now. Lmk what you think, and I'll let you know when the testing code is done/ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org