[GitHub] [kafka] ableegoldman commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-17 Thread GitBox
ableegoldman commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645677485 @mjsax @vvcephei can we merge this? Checkstyle passed on all builds This is an automated message from the Apa

[GitHub] [kafka] ableegoldman commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-16 Thread GitBox
ableegoldman commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645097409 Rebased on trunk and removed the TaskManager MethodLength suppression as well (yay 🥳 ), can you kick off tests again @mjsax ? ---

[GitHub] [kafka] ableegoldman commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-12 Thread GitBox
ableegoldman commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-643484888 Non-urgent, but some nice cleanup after I noticed how many suppressions aren't necessary anymore @vvcephei @mjsax @guozhangwang