[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-15 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-692980127 One unrelated known-flaky test failure: `PurgeRepartitionTopicIntegrationTest.shouldRestoreState` This is an

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-15 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-692979445 Retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-14 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-692350073 Alright I decided to un-parametrize the tests so we could run the different task assignors with different inputs instead of relaxing the tests to allow for the slowest assign

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-14 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-692166978 Whoops, I forgot to undo the reversion of #9231 before pushing. It was giving me trouble compiling in my IDE so I just reverted it to unblock my testing for the time being

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-12 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663 Alright this should finally be ready for a final pass and merge @vvcephei @cadonna -- sorry for leaving this hanging for so long. After running a few different tests,

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-12 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-12 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663 Alright this should finally be ready for a final pass and merge @vvcephei @cadonna -- sorry for leaving this hanging for so long. After running a few different tests,

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-11 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663 Alright this should finally be ready for a final pass and merge @vvcephei @cadonna -- sorry for leaving this hanging for so long. After running a few different tests,

[GitHub] [kafka] ableegoldman commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-06-17 Thread GitBox
ableegoldman commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-645727513 call for review @vvcephei @cadonna This is an automated message from the Apache Git Service. To respond to t