ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-679399444
@guozhangwang can we finally merge this? 🙂
This is an automated message from the Apache Git Service.
To resp
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670282246
Oh I think I misread your original comment, editing my response above
This is an automated message from the A
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670281342
Hey @guozhangwang
Thanks for the review. You have some high-level questions so I'll try to
answer them here but let me know if you want to sync offline.
> the only
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-668252969
cc @guozhangwang for 2nd review & merge
This is an automated message from the Apache Git Service.
To respond
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-667445902
`EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta` failed,
all other tests passed
This is an
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-666757275
Addressed all your comments @cadonna, ready for another pass. One open
question about the MetricsIntegrationTest
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-665394762
call for review @vvcephei @cadonna @guozhangwang
This is an automated message from the Apache Git Service.
T
