[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-12-01 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-736766888 Merged to trunk This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733408778 @mjsax it's not a bugfix PR, this is only going to trunk. Well technically it is fixing a bug, but that bug was only merged to trunk a few weeks ago. Otherwise I would agree,

[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733283434 Also just FYI since the suggested renaming touched on a lot of files, the only logical changes are to the SourceGraphNode, StreamSourceNode, and StreamsBuilderTest classes

[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733282299 @mjsax @cadonna I addressed your feedback, lmk if there's anything else (to answer your question, Matthias, this fixes the problem because we use `instanceof StreamsSourceNod