[GitHub] [kafka] ahuang98 commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-12 Thread GitBox
ahuang98 commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r870770149 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-11 Thread GitBox
ahuang98 commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869745683 ## core/src/test/scala/unit/kafka/server/BrokerFeaturesTest.scala: ## @@ -25,10 +25,6 @@ import scala.jdk.CollectionConverters._ class BrokerFeaturesTest { -

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-10 Thread GitBox
ahuang98 commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869715273 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -70,13 +47,17 @@ object StorageTool extends Logging { case "format" => val directories

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-10 Thread GitBox
ahuang98 commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869544110 ## clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java: ## @@ -91,6 +97,23 @@ public static NodeApiVersions create(short apiKey, short minVersion,