[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-25 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r857807415 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-25 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r858015440 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859016703 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859155538 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859155538 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-27 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r860212157 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861323350 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-29 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861634032 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -271,4 +273,48 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-29 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861640274 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-29 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861651580 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-29 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861640274 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-29 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r862274077 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-05-02 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r863014438 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF