aindriu-aiven commented on code in PR #14159:
URL: https://github.com/apache/kafka/pull/14159#discussion_r1289206301
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java:
##########
@@ -145,10 +148,28 @@ public void testScanningMixOfValidAndInvalidPlugins()
throws Exception {
assertEquals(expectedClasses, classes);
}
+ @Test
+ public void testScannedPluingsForUndefinedVersion() {
+ PluginScanResult unversionedPluginsResult =
scan(filterPluginsResourceDir(TestPlugins.pluginPath(),
TestPlugins.TestPlugin.SAMPLING_HEADER_CONVERTER.resourceDir()));
Review Comment:
Thanks Manually committed to add TestPlugins dependency workaround
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java:
##########
@@ -145,10 +148,28 @@ public void testScanningMixOfValidAndInvalidPlugins()
throws Exception {
assertEquals(expectedClasses, classes);
}
+ @Test
+ public void testScannedPluingsForUndefinedVersion() {
+ PluginScanResult unversionedPluginsResult =
scan(filterPluginsResourceDir(TestPlugins.pluginPath(),
TestPlugins.TestPlugin.SAMPLING_HEADER_CONVERTER.resourceDir()));
+ assertFalse(unversionedPluginsResult.isEmpty());
+ unversionedPluginsResult.forEach(pluginDesc ->
assertEquals(PluginDesc.UNDEFINED_VERSION, pluginDesc.version()));
+ }
+
+ @Test
+ public void testScannedPluingsForVersion() {
+ PluginScanResult versionedPluginResult =
scan(filterPluginsResourceDir(TestPlugins.pluginPath(),
TestPlugins.TestPlugin.READ_VERSION_FROM_RESOURCE_V1.resourceDir()));
Review Comment:
Thanks Manually committed to add TestPlugins dependency workaround
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
