[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050074366 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1318,14 +1317,20 @@ class KafkaApis(val requestChannel: RequestChannel, trace("Sending topic

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050065115 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -248,7 +258,12 @@ class ZkMetadataCache(brokerId: Int, metadataVersion: MetadataVersion,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050065115 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -248,7 +258,12 @@ class ZkMetadataCache(brokerId: Int, metadataVersion: MetadataVersion,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050063855 ## core/src/main/scala/kafka/server/MetadataCache.scala: ## @@ -103,13 +110,18 @@ trait MetadataCache { def metadataVersion(): MetadataVersion def

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050049320 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -364,11 +399,13 @@ class BrokerToControllerRequestThread( } override def

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050047950 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -60,16 +60,24 @@ trait ZkFinalizedFeatureCache { * A cache for the state (e.g.,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050037434 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -276,17 +290,38 @@ case class BrokerToControllerQueueItem( ) class

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050036052 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -276,17 +290,38 @@ case class BrokerToControllerQueueItem( ) class

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050028258 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -276,17 +290,38 @@ case class BrokerToControllerQueueItem( ) class

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050026488 ## clients/src/main/resources/common/message/StopReplicaRequest.json: ## @@ -31,7 +31,7 @@ "fields": [ { "name": "ControllerId", "type": "int32",

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050026225 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -36,7 +36,7 @@ "fields": [ { "name": "ControllerId", "type": "int32",

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1048902572 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -355,6 +375,13 @@ class ZkMetadataCache(brokerId: Int, metadataVersion: MetadataVersion,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1042776473 ## clients/src/main/resources/common/message/EnvelopeRequest.json: ## @@ -16,10 +16,11 @@ { "apiKey": 58, "type": "request", - "listeners": ["controller"],

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1042536606 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractControlRequest.java: ## @@ -43,6 +49,8 @@ protected AbstractControlRequest(ApiKeys api, short